Apache.xs patch for get_client_block

2000-08-31 Thread joe
The mod_perl implementation of get_client_block has a memory leak. The following patch should keep it from from pissing in r-pool. diff -u /var/lib/cpan/build/mod_perl-1.24/src/modules/perl/Apache.xs /usr/src/mod_perl-1.24/src/modules/perl/Apache.xs ---

Re: Apache.xs patch for get_client_block

2000-08-31 Thread Doug MacEachern
On 31 Aug 2000 [EMAIL PROTECTED] wrote: The mod_perl implementation of get_client_block has a memory leak. The following patch should keep it from from pissing in r-pool. thanks joe. i don't see how allocating from r-pool is a "leak", but yeah, it is a waste of resources since Perl is going

Re: Apache.xs patch for get_client_block

2000-08-31 Thread joe
Doug, Sorry to belabor a dull issue, but I'm not sure I'm getting my point across. Most of the troubles I've run across in the mod_perl and libapreq code have to do with attempts to allocate memory resources for buffers at runtime. That's exactly what the BUFF API does, right? What I'm

Re: Apache.xs patch for get_client_block

2000-08-31 Thread Doug MacEachern
On 31 Aug 2000 [EMAIL PROTECTED] wrote: Doug, Sorry to belabor a dull issue, but I'm not sure I'm getting my point across. no problem, this is important stuff to understand. Most of the troubles I've run across in the mod_perl and libapreq code have to do with attempts to allocate

Re: Apache.xs patch for get_client_block

2000-08-31 Thread joe
Doug, Thanks for clearing this up for me - great explanation! I'll let you know how your patch works out. Btw: I've been playing with the keep-alive stuff you left lying around in Connection.xs. The naive implementation I made seems to work fine, once the headers are sent to the client. Are