Re: [PATCH] Apache2::RequestUtil->add_config

2006-01-07 Thread Torsten Foertsch
On Saturday 07 January 2006 10:17, Philippe M. Chiasson wrote: > Well, you could do add_config( > >   ProxyPassReverse http://... > ); > > No ? I tried that. But is not allowed inside a block: $r->add_config() has failed: cannot occur within section Torsten pgpW16Rg99acR.pgp Description:

Re: [PATCH] Apache2::RequestUtil->add_config

2006-01-08 Thread Torsten Foertsch
On Saturday 07 January 2006 18:39, Philip M. Gollucci wrote: > > As a more generic solution, this might make sense. On first glance, your > > patch looks sane, but I won't have the time to really look at it until > > Jan 15th, so if anybody else feels like writing a few tests for this and > > beat

Re: [PATCH] Apache2::RequestUtil->add_config

2006-01-18 Thread Torsten Foertsch
On Wednesday 18 January 2006 02:41, Philippe M. Chiasson wrote: > I've finally got around looking at this patch, and it looks good. I tweaked > it some (whitespace and formatting) and checked it in as r370001 & r370002. Thanks, Torsten pgpDgLxFq62MQ.pgp Description: PGP signature