Re: Apache::DBI patches

2005-08-10 Thread Dave Rolsky
On Wed, 10 Aug 2005, Philip M. Gollucci wrote: http://people.apache.org/~pgollucci/CPAN/Apache-DBI/Apache-DBI-0.100.tar.gz 0.100 0.99 ! The CPAN indexer may not like this, and the CPAN shell will certainly not like it. -dave /*===

Re: Apache::DBI patches

2005-08-10 Thread Philip M. Gollucci
Dave Rolsky wrote: 0.100 0.99 ! The CPAN indexer may not like this, and the CPAN shell will certainly not like it. Its not going to be indexed anyway as I don't have the perms. Ask does. But, thats a good catch. Whats the next version number after .99 ? Do I make a 1.00 or a 0.991?

Re: Apache::DBI patches

2005-08-10 Thread Dave Rolsky
On Wed, 10 Aug 2005, Philip M. Gollucci wrote: Its not going to be indexed anyway as I don't have the perms. Ask does. But, thats a good catch. Whats the next version number after .99 ? Do I make a 1.00 or a 0.991? That's up to you, I guess. As for perms, Ask can give you co-maintainership

Re: Apache::DBI patches

2005-08-09 Thread Philip M. Gollucci
Joe Thomas wrote: Hi Philip, I notice that you're maintaining a new version of Apache::DBI. About a year ago, I posted a couple of patches to the mod_perl list, and sent them to Ask, but never received any response. My patch fixes a problem with database rollback/cleanup when more than one

RE: Apache::DBI patches

2005-08-09 Thread Joe Thomas
I'll attempt take a look at this sometime this week. At first glance I think I have some questions about it. I'll get back to you after more thorough investigation. Please CC the modperl@perl.apache.org list as I'm not technically the maintainer, Ask still is, and its supposed to a

Re: Apache::DBI patches

2005-08-09 Thread Philip M. Gollucci
Joe Thomas wrote: I'll attempt take a look at this sometime this week. At first glance I think I have some questions about it. I'll get back to you after more thorough investigation. Please CC the modperl@perl.apache.org list as I'm not technically the maintainer, Ask still is, and its

RE: Apache::DBI patches

2005-08-09 Thread Joe Thomas
While you're at it, can you post 2 separate ones instead of 1. Here's the first patch. It moves $Idx from being a file-scoped variable to connect() scope. The cleanup handler is then passed a closure containing $Idx: $s-push_handlers(PerlCleanupHandler, sub { cleanup($Idx) }); or

RE: Apache::DBI patches

2005-08-09 Thread Joe Thomas
These patches were originally by Patrick Mulvany, and posted to mod_perl in 2003. I've made sure they apply to Apache-DBI-0.99, and are compatible with my re-scoping of $Idx. The ping patch looks obviously correct to me. It makes sure that the database is always pinged on connect() if

Re: Apache::DBI patches

2005-08-09 Thread Philip M. Gollucci
Hi, I agree with all 3 patches. Thanks for splitting them out. That made my life so much easier. HTH -- The URL http://people.apache.org/~pgollucci/CPAN/Apache-DBI/Apache-DBI-0.100.tar.gz has entered CPAN as file: $CPAN/authors/id/P/PG/PGOLLUCCI/Apache-DBI-0.100.tar.gz

Apache::DBI patches

2004-09-02 Thread Joe Thomas
A couple days ago, I posted a patch that fixed what I think is a real bug in Apache::DBI when a script uses more than one database handle: http://mathforum.org/epigone/modperl/stroblangnerm Basically, I removed $Idx as a file-scoped variable, because if a script used more than one database