cvs commit: modperl-2.0/xs/maps apache_functions.map
dougm 02/03/28 16:52:44 Modified:xs/maps apache_functions.map Log: fix to build against current httpd-2.0 Revision ChangesPath 1.46 +2 -2 modperl-2.0/xs/maps/apache_functions.map Index: apache_functions.map === RCS file: /home/cvs/modperl-2.0/xs/maps/apache_functions.map,v retrieving revision 1.45 retrieving revision 1.46 diff -u -r1.45 -r1.46 --- apache_functions.map 10 Mar 2002 00:14:23 - 1.45 +++ apache_functions.map 29 Mar 2002 00:52:44 - 1.46 -359,7 +359,7 ap_hook_process_connection ap_hook_translate_name ap_hook_type_checker - ap_hook_quick_handler +!ap_hook_quick_handler ap_hook_map_to_storage ap_hook_create_request ap_hook_error_log -422,7 +422,7 ap_run_get_mgmt_items ap_run_map_to_storage ap_run_pre_mpm - ap_run_quick_handler +!ap_run_quick_handler ap_invoke_handler ap_die
Re: cvs commit: modperl/t/net/perl util.pl
A casual user won't understand that documentation... Hell, I'm not even sure I completely understand the implications of it and when to use/not use escape_html based on it... I think an example is called for, but not in the POD... Maybe in the Guide? Issac Eric Cholet wrote: --On Sunday, March 24, 2002 21:57:54 + [EMAIL PROTECTED] wrote: dougm 02/03/24 13:57:53 Modified:.Changes STATUS src/modules/perl Util.xs t/net/perl util.pl Log: Submitted by: Geoff Young [EMAIL PROTECTED] Reviewed by:dougm properly escape highbit chars in Apache::Utils::escape_html This is uncool for those of us using a non-ASCII encoding and sending out lots of characters with the 8th bit set, e.g. in a French page many accented characters will be replaced by 6-byte sequences. If I'm sending out Content-type: text/html; charset=ISO-8859-1, and calling escape_html to escape '', '' and the like, I'm going to be serving quite a lot more bytes than before this patch. However escape_html () has no clue as to what the character set is, and whether it has been correctly specified in the Content-Type. It has also be mentionned here that escape_html is only valid for single-byte encodings. So this patch does the right thing to escape the odd 8 bit char in a mostly ASCII output, but users of other charsets should be warned not to use it. I use HTML::Entities::encode($_[0], '') myself. Therefore I propose a doc patch to clear this up: Index: Util.pm === RCS file: /home/cvs/modperl/Util/Util.pm,v retrieving revision 1.8 diff -u -r1.8 Util.pm --- Util.pm4 Mar 2000 20:55:47 -1.8 +++ Util.pm25 Mar 2002 18:19:37 - @@ -68,6 +68,13 @@ my $esc = Apache::Util::escape_html($html); +This function is unaware of its argument's character set and encoding. +It assumes a single-byte encoding and escapes all characters with the +8th bit set. Do not use it with multi-byte encodings such as utf8. +When using a single byte non-ASCII encoding such as ISO-8859-1, +consider specifying the character set in the Content-Type header, +and using HTML::Entities to avoid unnecessary escaping. + =item escape_uri This function replaces all unsafe characters in the $string with their -- Eric Cholet - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
mod_perl test report
mod_perl VERSION: 1.2601 Apache version: 1.3.24 Apache MMN: 19990320 (cd ../apache_1.3.24 PERL5LIB=/usr/local/src/nwapache/modperl/lib: make) === src === src/os/unix === src/os/unix === src/ap === src/ap === src/main === src/main === src/lib === src/lib === src/modules === src/modules/standard === src/modules/standard === src/modules/extra === src/modules/extra === src/modules/proxy === src/modules/proxy === src/modules/ssl === src/modules/ssl === src/modules/perl === src/modules/perl === src/modules cc -c -I. -I/usr/local/lib/perl5/5.6.1/mach/CORE -I./os/unix -I./include -funsigned-char -DMOD_SSL=208108 -DMOD_PERL -DUSE_PERL_SSI -DAPPLLIB_EXP=/usr/local/lib/perl5/5.6.1/BSDPAN -fno-strict-aliasing -I/usr/local/include -DEAPI -DAPPLLIB_EXP=/usr/local/lib/perl5/5.6.1/BSDPAN -fno-strict-aliasing -I/usr/local/include `./apaci` modules.c cc -c -I. -I/usr/local/lib/perl5/5.6.1/mach/CORE -I./os/unix -I./include -funsigned-char -DMOD_SSL=208108 -DMOD_PERL -DUSE_PERL_SSI -DAPPLLIB_EXP=/usr/local/lib/perl5/5.6.1/BSDPAN -fno-strict-aliasing -I/usr/local/include -DEAPI -DAPPLLIB_EXP=/usr/local/lib/perl5/5.6.1/BSDPAN -fno-strict-aliasing -I/usr/local/include `./apaci` buildmark.c cc -funsigned-char -DMOD_SSL=208108 -DMOD_PERL -DUSE_PERL_SSI -DAPPLLIB_EXP=/usr/local/lib/perl5/5.6.1/BSDPAN -fno-strict-aliasing -I/usr/local/include -DEAPI -DAPPLLIB_EXP=/usr/local/lib/perl5/5.6.1/BSDPAN -fno-strict-aliasing -I/usr/local/include `./apaci` -Wl,-E -o httpd buildmark.o modules.o modules/standard/libstandard.a modules/perl/libperl.a main/libmain.a ./os/unix/libos.a ap/libap.a-lcrypt -Wl,-E -L/usr/local/lib /usr/local/lib/perl5/5.6.1/mach/auto/DynaLoader/DynaLoader.a -L/usr/local/lib/perl5/5.6.1/mach/CORE -lperl -lm -lc -lcrypt -liconv -lutil === src/support === src/support +-+ | Before you install the package you now should prepare the SSL | | certificate system by running the 'make certificate' command. | | For different situations the following variants are provided: | | | | % make certificate TYPE=dummy(dummy self-signed Snake Oil cert) | | % make certificate TYPE=test (test cert signed by Snake Oil CA) | | % make certificate TYPE=custom (custom cert signed by own CA) | | % make certificate TYPE=existing (existing cert)| |CRT=/path/to/your.crt [KEY=/path/to/your.key]| | | | Use TYPE=dummywhen you're a vendor package maintainer, | | the TYPE=test when you're an admin but want to do tests only, | | the TYPE=custom when you're an admin willing to run a real server | | and TYPE=existing when you're an admin who upgrades a server. | | (The default is TYPE=test) | | | | Additionally add ALGO=RSA (default) or ALGO=DSA to select | | the signature algorithm used for the generated certificate. | | | | Use 'make certificate VIEW=1' to display the generated data.| | | | Thanks for using Apache mod_ssl. Ralf S. Engelschall| | [EMAIL PROTECTED]| | www.engelschall.com| +-+ === src cp t/conf/mod_perl_srm.conf t/conf/srm.conf ./apaci/load_modules.pl ../apache_1.3.24/src ../apache_1.3.24/src/httpd -f `pwd`/t/conf/httpd.conf -X -d `pwd`/t httpd listening on port 8529 will write error_log to: t/logs/error_log letting apache warm up...\c done /usr/bin/perl t/TEST 0 modules/actions.ok modules/cgi.FAILED test 4 Failed 1/5 tests, 80.00% okay modules/constants...ok modules/cookie..ok modules/embperl.skipped test on this platform modules/eperl...skipped test on this platform modules/fileok modules/httpdconf...ok modules/include.ok modules/log.ok modules/module..skipped test on this platform modules/perlrun.ok modules/perlrunxs...skipped test on this platform modules/psections...ok modules/request.ok modules/sandwichok modules/src.ok modules/ssi.ok modules/stage...ok modules/status..ok modules/symbol..ok modules/uri.ok modules/utilok internal/apiok internal/auth...ok internal/croak..ok internal/dirmagic...ok internal/error..ok internal/headersok internal/hooks..ok internal/http-get...ok internal/http-post..ok internal/proxy..ok internal/redirect...ok internal/rwrite.ok internal/stackedok internal/table..ok
