Re: svn commit: r935519 - in /perl/modperl/trunk: t/response/TestAPR/socket.pm xs/APR/Socket/APR__Socket.h xs/maps/apr_functions.map xs/tables/current/ModPerl/FunctionTable.pm

2010-04-19 Thread Philippe M. Chiasson
mpxs_APR__Socket_sock_get(pTHX_ apr_socket_t *sock) +{ +#ifdef WIN32 +return -1; /* not implemented */ +#else +apr_os_sock_t s; +apr_os_sock_get(s, sock); +return s; +#endif +} Will this work on *all* non WIN32 platforms ? -- Philippe M. Chiasson GPG

Re: svn commit: r781917 - in /perl/modperl/branches/1.x: Changes src/modules/perl/mod_perl.c

2009-06-05 Thread Philippe M. Chiasson
, NULL, NULL, NULL, NULL, NULL }; +char **temp_argv=argv; Small nit, shouldn't it be : char **temp_args = argv; Also, feels like that bit of code needs a warning/comment to explain why it's there, otherwise, it's tempting to optimize/clean it away. -- Philippe M. Chiasson GPG

Re: svn commit: r628359 - /perl/modperl/trunk/lib/ModPerl/WrapXS.pm

2008-02-17 Thread Philippe M. Chiasson
[EMAIL PROTECTED] wrote: Author: randyk Date: Sat Feb 16 08:59:58 2008 New Revision: 628359 URL: http://svn.apache.org/viewvc?rev=628359view=rev Log: replace amp; by print dhu! x 1_000_000; -- Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5 http

Re: svn commit: r617965 - /perl/modperl/trunk/ModPerl-Registry/t/conf/extra.conf.in

2008-02-03 Thread Philippe M. Chiasson
this took a similiar root to Apache-SizeLimit and is pulled in via and SVN external. Not sure if that's really planned for yet. It hasn't been done in any case, and it was unnecessary in the test suite. -- Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5 http

Re: svn commit: r420268 - /perl/modperl/trunk/t/modperl/local_env.t

2006-07-12 Thread Philippe M. Chiasson
: no forked: yes (variable process count) Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-25 Thread Philippe M. Chiasson
don't mind changing it for consistency's sake. A quick grep shows this is indeed the only instance, but there are quite a few similar usages in [httpd/modules/ldap/*, so I am not alone at the ASF ;-) Philippe M

Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-25 Thread Philippe M. Chiasson
within the mp source code. Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5 signature.asc Description

Re: svn commit: r124345 - in perl/modperl/trunk: . src/modules/perl t/htdocs/modperl t/htdocs/modperl/setupenv2 t/modperl t/response/TestModperl

2005-01-06 Thread Philippe M. Chiasson
' + }, + { +'type' = 'modperl_config_srv_t *', +'name' = 'scfg' + } +] + }, + { +'return_type' = 'void', 'name' = 'modperl_env_unload', 'args' = [] }, Philippe M

Re: cvs commit: modperl-2.0 Changes

2004-10-11 Thread Philippe M. Chiasson
-- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5 signature.asc Description: OpenPGP digital signature

Re: cvs commit: modperl-2.0/t/response/TestAPI command.pm

2004-08-12 Thread Philippe M. Chiasson
-args_how, Apache::ITERATE, 'args_how'); ok t_cmp($cmd-errmsg, qr/Subroutine name/, 'errmsg'); ok t_cmp($cmd-req_override, Apache::OR_ALL, 'req_override'); -- Philippe M. Chiasson m/gozer

Re: cvs commit: modperl-2.0/xs/tables/current/ModPerl FunctionTable.pm

2003-11-17 Thread Philippe M. Chiasson
On Mon, 2003-11-17 at 15:27, [EMAIL PROTECTED] wrote: geoff 2003/11/17 15:27:11 Modified:xs/maps apr_functions.map apr_structures.map apr_types.map xs/tables/current/ModPerl FunctionTable.pm Added: xs/APR/Finfo APR__Finfo.h Log: add access to

Re: cvs commit: modperl Makefile.PL

2003-07-10 Thread Philippe M. Chiasson
If it fixes a reported bug, it should get logged in Changes, IMO On Wed, 2003-07-09 at 09:16, [EMAIL PROTECTED] wrote: randyk 2003/07/08 18:16:53 Modified:.Makefile.PL Log: For Win32, - copy mod_perl.lib into Apache/libexec directory, if it exists - keep drive