Author: stas Date: Fri Dec 31 15:13:48 2004 New Revision: 123830 URL: http://svn.apache.org/viewcvs?view=rev&rev=123830 Log: clarify the usage of the confusing apr API, the returned bucket pointer is the same as the first argument, which is modified by reference.
Modified: perl/modperl/trunk/src/modules/perl/modperl_bucket.c Modified: perl/modperl/trunk/src/modules/perl/modperl_bucket.c Url: http://svn.apache.org/viewcvs/perl/modperl/trunk/src/modules/perl/modperl_bucket.c?view=diff&rev=123830&p1=perl/modperl/trunk/src/modules/perl/modperl_bucket.c&r1=123829&p2=perl/modperl/trunk/src/modules/perl/modperl_bucket.c&r2=123830 ============================================================================== --- perl/modperl/trunk/src/modules/perl/modperl_bucket.c (original) +++ perl/modperl/trunk/src/modules/perl/modperl_bucket.c Fri Dec 31 15:13:48 2004 @@ -83,8 +83,8 @@ return APR_ENOMEM; } - bucket = apr_bucket_pool_make(bucket, pv, bucket->length, pool); - if (bucket == NULL) { + /* changes bucket guts by reference */ + if (apr_bucket_pool_make(bucket, pv, bucket->length, pool) == NULL) { return APR_ENOMEM; }