Re: [PATCH] Module::Build::Compat should support 'perl' as a prerequisite

2007-07-23 Thread Andreas J. Koenig
On Mon, 23 Jul 2007 00:19:56 -0400, David Golden [EMAIL PROTECTED] said: At this point, I would suggest the following: * M::B::Compat be patched to add 'requires 5.XX' when it sees a 'perl' prerequisite (which I've written and will post shortly) * EU::MM, M::B and the

Re: [PATCH] Module::Build::Compat should support 'perl' as a prerequisite

2007-07-23 Thread Michael G Schwern
Andreas J. Koenig wrote: On Sat, 21 Jul 2007 19:03:03 -0700, Michael G Schwern [EMAIL PROTECTED] said: David Golden wrote: Well, EU::MM *cannot* be patched on the clients without configure_requires. So, the best it could do would be to warn the author about it at `make dist`

Re: [PATCH] Module::Build::Compat should support 'perl' as a prerequisite

2007-07-23 Thread demerphq
On 7/23/07, David Golden [EMAIL PROTECTED] wrote: On 7/23/07, Michael G Schwern [EMAIL PROTECTED] wrote: Are you suggeting that ExtUtils::MakeMaker go into Bundle::CPAN? That's a very good idea. While we're at it, ExtUtils::Install, ExtUtils::Command and ExtUtils::Manifest.

Re: [PATCH] Module::Build::Compat should support 'perl' as a prerequisite

2007-07-23 Thread Michael G Schwern
Eric Wilhelm wrote: # from Michael G Schwern # on Monday 23 July 2007 12:22 am: That part of the spec is currently written in a contradictory and implicit manner, the definition of requires, as written, is very clear that the keys are Perl modules, but that's a simple thing to fix in the

Re: [PATCH] Module::Build::Compat should support 'perl' as a prerequisite

2007-07-22 Thread David Golden
On 7/21/07, Michael G Schwern [EMAIL PROTECTED] wrote: Are you suggeting that ExtUtils::MakeMaker go into Bundle::CPAN? That's a very good idea. It's not?!? I always assumed it was since M::B was there. (In fact I just checked and it's there now, but that sneaky Andreas just released a new

Re: [PATCH] Module::Build::Compat should support 'perl' as a prerequisite

2007-07-19 Thread Michael G Schwern
David Golden wrote: Module::Build::Compat drops 'perl' from the list of prerequisites when generating a Makefile.PL and/or Makefile. While EU::MM doesn't handle 'perl' well (it issues a warning about a missing prerequisite), it does still write it into the Makefile PREREQ_PM line and into the

Re: [PATCH] Module::Build::Compat should support 'perl' as a prerequisite

2007-07-19 Thread Michael G Schwern
David Golden wrote: On 7/19/07, Michael G Schwern [EMAIL PROTECTED] wrote: The way MakeMaker traditionally handles a perl prerequisite is by sticking require 5.xxx at the top of the Makefile.PL. The CPAN tools can spot the resulting error message and take the appropriate action. Is this

Re: [PATCH] Module::Build::Compat should support 'perl' as a prerequisite

2007-07-19 Thread David Golden
On 7/19/07, Michael G Schwern [EMAIL PROTECTED] wrote: The way MakeMaker traditionally handles a perl prerequisite is by sticking require 5.xxx at the top of the Makefile.PL. The CPAN tools can spot the resulting error message and take the appropriate action. Is this documented anywhere? Or

Re: [PATCH] Module::Build::Compat should support 'perl' as a prerequisite

2007-07-19 Thread Eric Wilhelm
# from David Golden # on Thursday 19 July 2007 04:23 am: On 7/19/07, Eric Wilhelm [EMAIL PROTECTED] wrote: Presumably, the compatibility Makefile.PL isn't used for ./Build dist, so the META.yml shouldn't be affected, right? The distribution that triggered this investigation is Module::Mask,

[PATCH] Module::Build::Compat should support 'perl' as a prerequisite

2007-07-18 Thread David Golden
Module::Build::Compat drops 'perl' from the list of prerequisites when generating a Makefile.PL and/or Makefile. While EU::MM doesn't handle 'perl' well (it issues a warning about a missing prerequisite), it does still write it into the Makefile PREREQ_PM line and into the META.yml. By dropping