[Mono-dev] [PATCH] Avoid useless check in Convert.ToChar(ushort)

2008-11-15 Thread Kornél Pál
Hi, Please review and approve the patch. Thanks. Kornél Index: mcs/class/corlib/System/Convert.cs === --- mcs/class/corlib/System/Convert.cs (revision 118898) +++ mcs/class/corlib/System/Convert.cs (working copy) @@ -681,10

[Mono-dev] Possible mono bug in SoapFormatter

2008-11-15 Thread Sixes
I'm not sure whether this counts as a bug in mono, a bug in .NET or simply an incompatibility that is acceptable, as it's probably a programming bug on my part anyway. Using the SoapFormatter, I output a serializable struct to a pre-opened FileStream. I then output a second serializable struct

Re: [Mono-dev] Mono.Simd - slower than the normal implementation

2008-11-15 Thread Rodrigo Kumpera
Hi Alan, There a couple of issues with your code, let me get on them: -Until recently (last night), getters were not accelerated, which causes a significant slowdown. I fixed this in r118899. The generated code is not as good as it could be, but this will be fixed eventually. -Setters are still

Re: [Mono-dev] Possible mono bug in SoapFormatter

2008-11-15 Thread Robert Jordan
Hi, Sixes wrote: The difference occurs on Deserialize. .NET reads the first envelope and leaves the stream pointer at the end of the xml. Mono tries to read to the end of the file and complains about two root elements. I'm not sure which is correct behaviour. IIRC, MS.NET 1.1

Re: [Mono-dev] [PATCH] WindowsBase: System.ComponentModel

2008-11-15 Thread zer0keefie
I don't have commit access; feel free to check it in when you have a chance. ~Brian On Nov 14, 2008 6:35pm, Chris Toshok [EMAIL PROTECTED] wrote: awesome - you have commit access? If so, go for it. Otherwise I can get this in tonight. chris On Thu, Nov 13, 2008 at 10:05 PM, Brian O'Keefe

Re: [Mono-dev] Possible mono bug in SoapFormatter

2008-11-15 Thread Sixes
Robert Jordan wrote: IIRC, MS.NET 1.1 SoapFormatter used to behaves like this. So it's possible that Mono's SoapFormatter was not updated to match MS.NET 2.0. Please file a bug with a test case. But that was my point and why I didn't file a bug report at once. IMHO, mono is

Re: [Mono-dev] [PATCH] Avoid useless check in Convert.ToChar(ushort)

2008-11-15 Thread Gonzalo Paniagua Javier
On Sat, 2008-11-15 at 12:32 +0100, Kornél Pál wrote: Hi, Please review and approve the patch. Thanks. Go ahead and commit. Thanks. -Gonzalo ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com

Re: [Mono-dev] [PATCH] Avoid useless check in Convert.ToChar(ushort)

2008-11-15 Thread Andreas Färber
Am 15.11.2008 um 12:32 schrieb Kornél Pál: Index: mcs/class/corlib/System/Convert.cs === --- mcs/class/corlib/System/Convert.cs(revision 118898) +++ mcs/class/corlib/System/Convert.cs(working copy) @@ -681,10

Re: [Mono-dev] [PATCH] Avoid useless check in Convert.ToChar(ushort)

2008-11-15 Thread Kornél Pál
Andreas Färber wrote: Am 15.11.2008 um 12:32 schrieb Kornél Pál: Index: mcs/class/corlib/System/Convert.cs === --- mcs/class/corlib/System/Convert.cs(revision 118898) +++ mcs/class/corlib/System/Convert.cs(working

[Mono-dev] [PATCH] VB runtime: implement Asc and Chr correctly

2008-11-15 Thread Kornél Pál
Hi, Please review the attched patch. Note that I've added svn:eol-style native to all the files I've modified and source and project files thus would be included entirely in the diff file so I excluded them but the only addition would be adding StringsTest.vb. Kornél Index:

Re: [Mono-dev] standalone tests on buildbot

2008-11-15 Thread Atsushi Eno
IMO it is not time to do it yet because we are rather stuck in too separate build revisions to track regressions i.e. improving quality of monobuild is in higher precedence. Having those standalone tests in those builds makes current situation worse. Atsushi Eno Gert Driesen wrote: Hi, To

Re: [Mono-dev] Mono.Simd - slower than the normal implementation

2008-11-15 Thread Alan McGovern
Hey, On Sat, Nov 15, 2008 at 3:50 PM, Rodrigo Kumpera [EMAIL PROTECTED] wrote: Hi Alan, -Getters and setter are a hint of ill vectorized code. In this particular scenario, I'm not sure how i can get rid of the use of getters/setters unless I use even more unsafe code. I don't know whether it's

Re: [Mono-dev] Mono.Simd - slower than the normal implementation

2008-11-15 Thread Alan McGovern
Here's my benchmarking file anyway, it may prove useful. Alan. On Sun, Nov 16, 2008 at 2:37 AM, Alan McGovern [EMAIL PROTECTED] wrote: Hey, On Sat, Nov 15, 2008 at 3:50 PM, Rodrigo Kumpera [EMAIL PROTECTED] wrote: Hi Alan, -Getters and setter are a hint of ill vectorized code. In this