Re: [Mono-dev] Fwd: Could you please review/comment or approve?

2010-01-22 Thread Leszek Ciesielski
Both patches (Thad's and mine) commited. On Thu, Jan 21, 2010 at 6:32 PM, Miguel de Icaza mig...@novell.com wrote: Hello,   Let us get it in, ad if Carlos disapproves, he can comment/fix later. I'm pushing this patch for review once again... Or may I treat the silence as permission to

Re: [Mono-dev] Fwd: Could you please review/comment or approve?

2010-01-22 Thread Carlos Alberto Cortez
Hey! Sorry for the late review, but these patches got lost among a bunch of other patches to review. Anyway, the patches are fine. Thanks for taking a look at that, Carlos. 2010/1/22 Leszek Ciesielski skol...@gmail.com Both patches (Thad's and mine) commited. On Thu, Jan 21, 2010 at 6:32

[Mono-dev] Mac Boehm CG question

2010-01-22 Thread Tom Philpot
While investigating some performance problems in our application which uses the embedded Mono runtime on Mac OS X targeting 10.5 and 10.6, I noticed that several operations spent an extreme amount of time in GC_lock. That code lead me back to gcconfig.h where NO_PTHREAD_TRYLOCK is defined. I've

Re: [Mono-dev] Mac Boehm CG question

2010-01-22 Thread Rodrigo Kumpera
pthread mutexes on OSX are ridiculously slow. So no matter what you do, GC performance will be significantly worse than on linux. But we should check if this change is ok if it does give a nice boost. On Fri, Jan 22, 2010 at 8:05 PM, Tom Philpot tom.phil...@logos.com wrote: While

[Mono-dev] mono crash on exits when using COM.

2010-01-22 Thread tom hindle
Hi all, I have been investigating some seemingly random crash on exit problems that our application has been having. I have managed mostly reliably to reproduce the issue by following this set of steps: 1. Create a managed object ManagedObj 2. Create a COM object COMObj for which its rcw is

Re: [Mono-dev] mono crash on exits when using COM.

2010-01-22 Thread tom hindle
I have added a check in mono_gc_run_finalize (void *obj, void *data) (gc.c): --- if (suspend_finalizers) return; + if (mono_marshal_ccw_refcount(o) 0) + { + return; + } domain = o-vtable-domain; This seems to solve the problem. The ccw isn't freed, which means

[Mono-dev] [PATCH] Fix float.Parse, float.TryParse and XmlConvert.ToString for float.MaxValue, float.PositiveInfinity and TimeSpan.MinValue

2010-01-22 Thread Tiaan Geldenhuys
These patches fix the parsing of float.MaxValue and float.PositiveInfinity on the System.Single class, and the serialization of TimeSpan.MinValue on the System.Xml.XmlConvert.ToString method. Tests are included for the root-causes themselves, as well as for the System.Xml.Linq classes through