[Mono-dev] [PATCH] Fix Roles.IsUserInRole and enhance WebTest Framework

2010-02-11 Thread Tiaan Geldenhuys
The attached patch is a fix for System.Web.Security.Roles.IsUserInRole to prevent ASP.NET MVC errors like the one shown at the bottom, which happens when a user hasn't logged on and requests public pages with sections that are dynamically removed using role-based access-restrictions. It now behave

Re: [Mono-dev] [PATCH] Fix Roles.IsUserInRole and enhance WebTestFramework

2010-02-11 Thread Eyal Alaluf
Hi, Tiaan. It seems to me you'd want to use 'string.IsNullOrEmpty(username)' instead of '(username != null && username.Length <= 0)' Eyal. -Original Message- From: mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list-boun...@lists.ximian.com] On Behalf Of Tiaan Geldenhuys Sen

Re: [Mono-dev] [PATCH] Fix Roles.IsUserInRole and enhance WebTest Framework

2010-02-11 Thread Marek Habersack
On Thu, 11 Feb 2010 03:16:33 -0600 "Tiaan Geldenhuys" wrote: Hello, > The attached patch is a fix for System.Web.Security.Roles.IsUserInRole to > prevent ASP.NET MVC errors like the one shown at the bottom, which happens > when a user hasn't logged on and requests public pages with sections that

Re: [Mono-dev] [PATCH] Fix Roles.IsUserInRole and enhance WebTestFramework

2010-02-11 Thread Tiaan Geldenhuys
Actually, this should not be changed; that expression reads "is not null BUT ONLY empty" as it was intended. The case for null is supposed to throw an ArgumentNullException, which should happen when the RoleProvider is called (if the provider is implemented according to spec) or a check for null c

[Mono-dev] connecting a debugger to an embedded mono

2010-02-11 Thread Matt Grasse
Hi, I'm embedding mono into a C++ application. Getting mono embedded and loading assemblies has gone pretty smoothly, and now I would like to connect the managed code to a debugger. If it matters, I'm doing my development on Windows, but will eventually be running on Linux as well. I've played

Re: [Mono-dev] [PATCH] Fix Roles.IsUserInRole and enhance WebTest Framework

2010-02-11 Thread Tiaan Geldenhuys
Hi Marek: Thanks for committing almost all the changes, especially the ones to WebTest. However, I would still like to get some ideas about a better way to then isolate the Web.config settings between different Tests and Test Fixtures -- because that seems to be the main issue with the changes th

Re: [Mono-dev] [PATCH] Fix Roles.IsUserInRole and enhance WebTest Framework

2010-02-11 Thread Marek Habersack
On Thu, 11 Feb 2010 11:58:53 -0600 "Tiaan Geldenhuys" wrote: > Hi Marek: Hey, > > Thanks for committing almost all the changes, especially the ones to > WebTest. However, I would still like to get some ideas about a better way > to then isolate the Web.config settings between different Tests a

Re: [Mono-dev] Mono.Simd AltiVec port

2010-02-11 Thread Rodrigo Kumpera
The way to handle those situations is to have a arch decomposition pass that converts MULPS into a VZERO + MULADD. For bonus points, you can add to the arch peephole code to fuse MULPS + ADDPS. For an example of that, take a look at mini-x86.c / mono_arch_decompose_opts. Rodrigo On Tue, Feb 9, 2

Re: [Mono-dev] Custom Uri Parsing

2010-02-11 Thread Alan McGovern
Hey, The main reason why I didn't actually do any work on this at the time is that it would probably take 1 man month to do the rewrite, pass the existing tests and write more tests for the new behaviours and I didn't have a month free to do it ;) Proper support for the new parser API is required

Re: [Mono-dev] [PATCH] Fix for Type.GetMember returning private property of base class

2010-02-11 Thread Rodrigo Kumpera
Hi Eberhard, I'll take the time to review your patch tomorrow. Changes to reflection code require a lot of testing since they can break a lot of stuff. Thanks, Rodrigo On Mon, Feb 8, 2010 at 12:41 PM, Eberhard Beilharz wrote: > Bump! > > > On 01/28/2010 03:13 PM, Eberhard Beilharz wrote: > >

[Mono-dev] [PATCH] Fix HashSet when used with nulls and non-default comparer

2010-02-11 Thread Tiaan Geldenhuys
This patch is for System.Collections.Generic.HashSet to fix the error shows at the bottom, which happens when you create a hash-set with a non-default comparer like StringComparer.Ordinal and then attempt to populate it with a null value. The hash-set should always be able to store null values (fo