Re: [Mono-dev] [PATCH] WCF more detail on Destination Unreachable

2010-03-24 Thread Atsushi Eno
Thanks for the test, it cleared some things up :) So - first, I cannot apply your HttpRequestChannel change. The code you removed was introduced to fix real problem regarding HTTP 4xx; when HTTP 4xx is returned, the response stream is inaccessible and the channel should not try to read it. Instea

Re: [Mono-dev] [PATCH] Two patches to make SGen work on Darwin/x86

2010-03-24 Thread Mark Probst
On Wed, Mar 24, 2010 at 11:37 AM, Paolo Molaro wrote: > One solution is to introduce a function similar to > GC_call_with_alloc_lock() in the Boehm GC, so that the unsafe table > manipulation can be done without risk of interruption from the GC. > Another one is to expose the critical region enter

[Mono-dev] [PATCH] Implement guarded finally blocks

2010-03-24 Thread Rodrigo Kumpera
Hey, Attached is the initial patch that implemented guarded finally blocks. It only works on unix/x86. It solves the problem of Thread::Abort been delivered in the middle of a handler blocks. The correct behavior is to raise the exception right after the handler finishes. This applies to catch, f

Re: [Mono-dev] Bug 582502 - System.Linq.Enumerable.OrderByDescending is not a stable sort

2010-03-24 Thread Jb Evain
Hi Richard, On Wed, Mar 24, 2010 at 6:18 PM, Richard Kiene wrote: > I've attached a patch which I release under the MIT/X11 license. Thanks for the patch! -- Jb Evain ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.xi

Re: [Mono-dev] Bug 582502 - System.Linq.Enumerable.OrderByDescending is not a stable sort

2010-03-24 Thread Richard Kiene
Well by definition a stable sort preserves the order of the collection for equal elements, but I get what you're saying. After reading what you've said, it would appear that what needs to happen is second_index - first_index in the case of descending and first_index - second_index in the case o

[Mono-dev] [PATCH] let gnome-sharp build without Mono.GetOptions

2010-03-24 Thread Jay R. Wren
Yes, its a trivial patch, but it Mono.GetOptions is removed from trunk so allowing gnome-sharp samples to build with the newer Mono.Options seems like a good idea. -- Jay Index: sample/gnomevfs/Mono.Options.cs === --- sample/gnomevfs/

[Mono-dev] Bug 582502 - System.Linq.Enumerable.OrderByDescending is not a stable sort

2010-03-24 Thread dinonet
> It would appear that the Compare method in SortSequenceContext.cs (lines 58 - > 70 revision 152310) does not allow for equality. > > If a comparison returns zero on line 60 and a non-zero child context > comparison is never found then Compare will return first_index - second_index > on line

Re: [Mono-dev] Mono.Security - ssl certificate datetime parsing causes crash on some cultures. (patch)

2010-03-24 Thread Stifu
Looking at the patch, it's done within a "#if NET_2_0" compilation condition. Shouldn't the same fix be applied in the "#else" just below (ie: replace "null" with "CultureInfo.InvariantCulture")? Sebastien Pouliot wrote: > > Fixed on HEAD (r154135), 2-6 (r154136) and 2-4 (r154137) > Thanks! > S

Re: [Mono-dev] Mono.Security - ssl certificate datetime parsing causes crash on some cultures. (patch)

2010-03-24 Thread Sebastien Pouliot
Fixed on HEAD (r154135), 2-6 (r154136) and 2-4 (r154137) Thanks! Sebastien On Wed, 2010-03-24 at 11:26 +0200, yoni shalom wrote: > A crash occurs on windows machines when the process culture info > doesn't support the string format representing the x509 certificate > timestamp. > Certificate time

Re: [Mono-dev] [PATCH] WCF multithreaded and property handling

2010-03-24 Thread Matt Dargavel
The problem I was trying to fix was that it's possible for wait to be set to null after: if (wait != null) and before: wait.WaitOne(...) causing a null reference exception. Looking at MSDN it sounds like an AutoResetEvent should remain signalled until a thread calls WaitOne? The problem is i

Re: [Mono-dev] [PATCH] WCF multithreaded and property handling

2010-03-24 Thread Atsushi Eno
After examining the patch, I have applied some parts of your patch. -wait = new AutoResetEvent (false); -source.ListenerManager.GetHttpContextAsync (timeout, HttpContextAcquired); -if (wait != null) // in case callback is done before WaitOne() here

Re: [Mono-dev] [PATCH] WCF more detail on Destination Unreachable

2010-03-24 Thread Matt Dargavel
Apologies for the wait- it's the time difference! :-) I've come up with a test for the DestinationUnreachable patch. When I was doing my testing I was using a combination of a .NET client and manually firing in requests using PuTTY and examining the reply. When I use a WCF Client in Mono the exc

Re: [Mono-dev] [PATCH] Two patches to make SGen work on Darwin/x86

2010-03-24 Thread Paolo Molaro
On 03/24/10 Mark Probst wrote: > The first patch make mono-ehash SGen-aware, the second implements > CEE_MONO_TLS on Darwin/x86. > --- a/mono/utils/mono-ehash.c > +++ b/mono/utils/mono-ehash.c [...] > +#ifdef HAVE_SGEN_GC > + if (type < 0 || type > MONO_HASH_KEY_VALUE_GC) > + g_err

[Mono-dev] Mono.Security - ssl certificate datetime parsing causes crash on some cultures. (patch)

2010-03-24 Thread yoni shalom
A crash occurs on windows machines when the process culture info doesn't support the string format representing the x509 certificate timestamp. Certificate timestamps should be parsed to DateTime using InvariantCulture, which is what the patch does. Stack Trace : System.Security.Cryptography.Cryp

Re: [Mono-dev] [PATCH] WCF multiple service contracts on one end point

2010-03-24 Thread Atsushi Eno
I have applied the patch almost as is (with some coding style changes), with few exceptions: - AddBaseAddress (new Uri (baseAddress.BaseAddress)); + base_addresses.Add (new Uri (baseAddress.BaseAddress)); no need for this change. Thanks a lot! Atsushi Eno On 2010/03/23 20:28, Matt Dargavel wr