[Mono-dev] Candidate Fix for 699643

2011-11-23 Thread Neale Ferguson
I am looking to commit the following fix http://pastebin.com/qw2WdzPr to resolve bug 699643 (https://bugzilla.novell.com/show_bug.cgi?id=699643). Would someone be willing to review it? Neale ___ Mono-devel-list mailing list

Re: [Mono-dev] Candidate Fix for 699643

2011-11-23 Thread Rodrigo Kumpera
Silly me, but shouldn't you have a test case for that? Other than that, make a pull request and I'll merge it. On Wed, Nov 23, 2011 at 6:28 PM, Neale Ferguson nealefergu...@verizon.netwrote: I am looking to commit the following fix http://pastebin.com/qw2WdzPr to resolve bug 699643

Re: [Mono-dev] Candidate Fix for 699643

2011-11-23 Thread Rodrigo Kumpera
Oh, just in case. I'm merging not because I have a clue on how TDS works, but since I trust your change. On Wed, Nov 23, 2011 at 6:36 PM, Rodrigo Kumpera kump...@gmail.com wrote: Silly me, but shouldn't you have a test case for that? Other than that, make a pull request and I'll merge it.

Re: [Mono-dev] Candidate Fix for 699643

2011-11-23 Thread Veerapuram Varadhan
Hi Neale, First part of the fix would be good to go. The later part will have issues with earlier versions of TDS, which people still use. V. Varadhan On Wed, 2011-11-23 at 13:28 -0500, Neale Ferguson wrote: I am looking to commit the following fix http://pastebin.com/qw2WdzPr to resolve bug

Re: [Mono-dev] Candidate Fix for 699643

2011-11-23 Thread Veerapuram Varadhan
Having said that.. it would be good to have a test case built around this patch and run with the existing connected-mode-tests of System.Data assembly. V. Varadhan On Thu, 2011-11-24 at 00:24 +0530, Veerapuram Varadhan wrote: Hi Neale, First part of the fix would be good to go. The later