Hey Rodrigo, by looking at
https://github.com/mono/mono/commit/04c641a21c2ba92c3262948ed1b68eb22c643b11
as you point out, it would make sense to find the call to
GetContextFromQueue() inside the lock, but maybe ares.Complete() can be
outside for better performance? (And then inside again when a
Thanks for the info Daniel!
Then, a review on this pull request is appreciated, to bring ADO.NET's
Connection Lifetime support to Mono:
https://github.com/mono/mono/pull/517
On 05/12/12 18:09, Daniel Morgan wrote:
The assembly Mono.Data.Tds can be thought of as internal to the assembly
Sys
The assembly Mono.Data.Tds can be thought of as internal to the assembly
System.Data for the SqlClient implementation. So, you can change the API of
Mono.Data.Tds as long as you change the assembly System.Data too.
The reason the assembly Mono.Data.Tds exists is historic: Mono.Data.Tds was
c
I did see it (and comment). Thought there might be something more to it.
On Wed, Dec 5, 2012 at 4:05 PM, Rodrigo Kumpera wrote:
> Did you look at the git history for those changes to see why those changes
> have been made?
>
> 04c641a21c2ba92c3262948ed1b68eb22c643b11 seens relevant.
>
>
> On We
Did you look at the git history for those changes to see why those changes
have been made?
04c641a21c2ba92c3262948ed1b68eb22c643b11 seens relevant.
On Wed, Dec 5, 2012 at 8:52 AM, Greg Young wrote:
> CheckDisposed ();
> if (!listening)
> throw new InvalidOperationException ("Please, call Star
I was in looking at some code today in httplistener and didn't understand
some of the stuff going on (was hitting a performance penalty due to it).
In particular I was a bit confused when looking at Begin and EndGetContext
(included below).. It would seem harmful to call ares.Complete below while
On śro, 2012-12-05 at 13:56 +0100, Konrad M. Kruczynski wrote:
> Hi all,
> it is rather known fact that adding a finalizer to the class can hurt
> performance quite badly with generational garbage collectors. This is
> due to the premortem finalization used by CLR. If an object is not
> reachable d
Hi all,
it is rather known fact that adding a finalizer to the class can hurt
performance quite badly with generational garbage collectors. This is
due to the premortem finalization used by CLR. If an object is not
reachable during GC, but has a finalizer, it will survive and probably
be promoted t
