[Mono-dev] PR #1337 Review

2014-10-29 Thread RyanMelenaNoesis
It was requested that I notify the mailing list about this pull request ( https://github.com/mono/mono/pull/1337 ) in order to facilitate conversation. The changes were implemented to support JWT authentication in our web application and required a couple changes to existing Mono code. The change

Re: [Mono-dev] PR #1337 Review

2014-10-29 Thread Miguel de Icaza
Thanks for pointing this out. Imlemented. Miguel On Wed, Oct 29, 2014 at 2:52 PM, RyanMelenaNoesis < ryan.melena+mono-devel-l...@noesislabs.com> wrote: > It was requested that I notify the mailing list about this pull request ( > https://github.com/mono/mono/pull/1337 ) in order to facilitate >

[Mono-dev] PR944 - Improve COM error handling

2014-10-29 Thread Eberhard Beilharz
Hi, To revive one of my old pull requests: #944 implements some missing pieces related to COM error handling. Namely it sets the error info in GetHRForException() and converts the HRESULT values to managed exceptions. https://github.com/mono/mono/pull/944 Thanks, Eberhard ___

Re: [Mono-dev] Review of PR1363: MembershipPasswordAttribute

2014-10-29 Thread Martin Thwaites
Hi all, I've got a slight problem with this PR, and need some help to fix it. It's a dependency issue, System.Web now depends on System.ComponentModel.DataAnnotations. However, the Makefile puts the component model well after it in the compile order. https://github.com/martinjt/mono/blob/master

Re: [Mono-dev] PR1375: cleanup

2014-10-29 Thread Rodrigo Kumpera
I know that :) is in there. On Tue, Oct 28, 2014 at 11:16 AM, Greg Young wrote: > Can I buy a vowel? > > > On Tuesday, October 28, 2014, Miguel de Icaza wrote: > >> >> >> ▉, ▉▉ . ▉▉▉ - ▉▉. ▉▉, "", , >> ▉▉ >> >> MIguel >> >> On Tue, Oct 28, 2014 at 1

Re: [Mono-dev] PR944 - Improve COM error handling

2014-10-29 Thread Rodrigo Kumpera
The code in your pull request is windows specific so it won't work on unix. Mono works with unix com implementations such as xpcom. On Wed, Oct 29, 2014 at 3:06 PM, Eberhard Beilharz wrote: > Hi, > > To revive one of my old pull requests: #944 implements some missing > pieces related to COM err