Re: [Mono-dev] Behavior change in XmlWriterSettings/XmlTextWriter

2015-09-28 Thread Martin Potter
Atsushi, Were you (or someone else) going to get this fixed before 4.2 is ready to ship? Thank you, Martin On 9/8/15, 8:03 PM, "Atsushi Eno" wrote: >I had no idea when that commit was made, but that change was wrong. >Microsoft behavior is the one we should use in that case. > >Atsushi Eno > >

Re: [Mono-dev] Behavior change in XmlWriterSettings/XmlTextWriter

2015-09-28 Thread Atsushi Eno
Current Microsoft-based implementation is the correct one and it's been there in post-4.0 versions. Atsushi Eno On 2015年09月28日 22:46, Martin Potter wrote: > Atsushi, > > Were you (or someone else) going to get this fixed before 4.2 is ready to > ship? > > Thank you, > Martin > > On 9/8/15, 8:0

Re: [Mono-dev] Behavior change in XmlWriterSettings/XmlTextWriter

2015-09-28 Thread Martin Potter
The default for XamlWriterSettings NewLineChars was changed from "\r\n" to "\n" when you imported the reference source and is what is present on the 4.2 branch. This is not what the previous behavior was, nor what the documentation on MSDN, https://msdn.microsoft.com/en-us/library/system.xml.xmlwri

Re: [Mono-dev] Behavior change in XmlWriterSettings/XmlTextWriter

2015-09-28 Thread Atsushi Eno
MSDN documentation describes the behavior how .NET Framework works on Windows, hence it says \r\n. As the referencesource is explicitly implemented, it is NOT the case on non-Windows platform. If you are unhappy about Microsoft behavior, you should file a bug to Microsoft. referencesource is not f

Re: [Mono-dev] Behavior change in XmlWriterSettings/XmlTextWriter

2015-09-28 Thread Martin Potter
I wasn’t aware that the MSDN .NET documentation was viewed as being platform specific documentation. I am not sure how this is a Microsoft bug so much as an issue with the fact they did not consider it being run on other platforms. Given that Mono is cross-platform, whereas Microsoft’s implementat

Re: [Mono-dev] Behavior change in XmlWriterSettings/XmlTextWriter

2015-09-28 Thread Atsushi Eno
You have no reason to be afraid of asking Microsoft to change the behavior. I cannot find any justification to just ask Mono to change things against Microsoft code behavior without asking Microsoft about it. Atsushi Eno On 2015年09月29日 01:15, Martin Potter wrote: > I wasn’t aware that the MSDN .N

Re: [Mono-dev] Behavior change in XmlWriterSettings/XmlTextWriter

2015-09-28 Thread Martin Thwaites
I'd have to agree with Martin here. The output of 2 functions should surely match. The fact that the referencesource uses something that defaults to something different per platform should be irrelevant. The only point to consider is, should the output of a method be able to differ per platform