Re: [Mono-dev] FileInfo Replace

2009-05-05 Thread David Uvalle
Thanks, can this be committed? On Mon, May 4, 2009 at 2:36 PM, Max de Lavenne wrote: > Nice, looking good.. > > -- > *From:* David Uvalle [mailto:david.uva...@gmail.com] > *Sent:* Monday, May 04, 2009 2:27 PM > *To:* Max de Lavenne >

Re: [Mono-dev] FileInfo Replace

2009-05-04 Thread David Uvalle
Ok this check first the read-only flag and sends and exception if the destinationFileName is has it. On Sat, May 2, 2009 at 12:59 PM, David Uvalle wrote: > > On Fri, May 1, 2009 at 5:18 PM, Max de Lavenne wrote: > >> Nice, >> >> But... you need to also check fo

Re: [Mono-dev] FileInfo Replace

2009-05-02 Thread David Uvalle
to check if the destination file is read-only before > attempting to replace it." > > You should implement that. > Sure I will. Thanks for your feedback. > > -- > *From:* mono-devel-list-boun...@lists.ximian.com [mailto: > mono-devel-list-b

[Mono-dev] FileInfo Replace

2009-05-01 Thread David Uvalle
FileInfo Replace method and some tests. Index: FileInfo.cs === --- FileInfo.cs (revision 132546) +++ FileInfo.cs (working copy) @@ -286,7 +286,23 @@ public FileInfo Replace (string destinationFileName, string destinationBacku