Re: [Mono-dev] Socket.IsBound wrong behavior

2013-11-12 Thread Stifu
Yeah, sometimes classes are in unexpected folders. Socket isn't under System.Net, but just System, for some reason. https://github.com/mono/mono/blob/master/mcs/class/System/System.Net.Sockets/Socket.cs Marcelo Zabani wrote Hi all, I've found something strange with the Socket.IsBound property.

Re: [Mono-dev] why does DateTime.Now.IsDaylightSavingTime() returns false when it should be true.

2013-11-07 Thread Stifu
I'm in no position to accept or review your patch, but I wanted to thank you for taking the time and putting in the efforts needed to make Mono better for everyone. I hope this pull request gets attention soon. Alistair Bush wrote Hi guys, Please note that I have cleaned this up and bit and

Re: [Mono-dev] A possible implementation for AssemblyName.ReferenceMatchesDefinition

2013-08-27 Thread Stifu
If I'm not mistaken, the last 2 tests are redundant. You're basically doing the same test twice. So I guess this could be simplified to something like: public static bool ReferenceMatchesDefinition (AssemblyName reference, AssemblyName definition) {

Re: [Mono-dev] S.W.F.DataVisualization.Charting

2013-08-11 Thread Stifu
Hi, Thanks for your work! Although I've never used WinForms charting, it's good to see WinForms get some attention. :) I hope someone can review this soon. Francis Fisher wrote Hi, I've recently done some work on System.Windows.Forms.DataVisualization.Charting. It was originally

Re: [Mono-dev] Absolute beginner

2012-12-31 Thread Stifu
Hi, 1. Up to you, you can use any .NET IDE if you're on Windows (Visual Studio, SharpDevelop), otherwise, MonoDevelop is there for Windows, Linux and Mac. 2. Indeed. Well, just create your .NET app, then test it with Mono. I believe there is an addon to run an app with Mono from VS (not free

Re: [Mono-dev] Patches for mono-winforms

2012-08-19 Thread Stifu
it? Stifu wrote The OneIdlePerThread test does not seem to run on Windows, for some reason. It doesn't fail, but it doesn't run... Therefore, maybe it shouldn't pass on Linux. Steven Boswell II wrote https://github.com/mono/mono/commit/38bdbad5071487a11f4330077c383375dce39840

Re: [Mono-dev] Patches for mono-winforms

2012-08-18 Thread Stifu
The OneIdlePerThread test does not seem to run on Windows, for some reason. It doesn't fail, but it doesn't run... Therefore, maybe it shouldn't pass on Linux. Steven Boswell II wrote https://github.com/mono/mono/commit/38bdbad5071487a11f4330077c383375dce39840 This change introduced a

Re: [Mono-dev] Patches for mono-winforms

2012-08-11 Thread Stifu
I had a look at the unit test for patch 20. The EditingControlShowingTest_Unbound test method fails with .NET (ArgumentOutOfRangeException). Something must be wrong with it. Stifu wrote Let's not take bad habits. :) Thanks for the test. I did make the unit test for ermshiperete's patch

Re: [Mono-dev] Patches for mono-winforms

2012-08-08 Thread Stifu
Let's not take bad habits. :) Thanks for the test. I did make the unit test for ermshiperete's patch, since he doesn't seem to be active anymore. It was that one with the Assert.Throws. :\ I just committed it separately, since the author was different. Anyway... I missed patch 19 somehow, but it

Re: [Mono-dev] Patches for mono-winforms

2012-08-07 Thread Stifu
Sounds good. But you can probably tell what's on my mind... Is it testable? Steven Boswell II wrote https://github.com/mono/mono/commit/ecef298bcaf571a3d50e022318b20117f9d0388c introduced another bug that I found today.  Enclosed is the fix. DataGridViewTextBoxCell was creating a single

Re: [Mono-dev] 6198, Opinion? (not a fix)

2012-08-01 Thread Stifu
Although you ask, you probably already know the answer: correctness is preferable to speed. Sure, if we can have both, that'd be great, but if we had to choose, let's be correct. Rob Wilkens wrote 1) My original fix for 2663 i knew would be slower than the original without it because it had

Re: [Mono-dev] Newly broken WinForms unit tests

2012-07-29 Thread Stifu
could find was external/cecil//Test/libs/nunit-2.5.10/nunit.framework.dll, and that doesn't appear to be built from source. Am I in an evil parallel universe again? :-) Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Saturday

Re: [Mono-dev] Patches for mono-winforms

2012-07-29 Thread Stifu
Ah, thanks for the fix. It's in. I overlooked these regressions as I was solely focused on the new test. Out of curiosity, do you also see 5 remaining failing WinForms tests? Steven Boswell II wrote The following patch fixes the two recently-broken WinForms unit tests. Stifu?  You checked

Re: [Mono-dev] Patches for mono-winforms

2012-07-28 Thread Stifu
It's in (https://github.com/mono/mono/commit/75714e424afd2ee458e1288d756c914a4df2554f), thanks again. Steven Boswell II wrote Enclosed is the third patch for TableLayoutPanel.  Our application has a table-layout with column-spanning controls, and no control started in one particular column.

Re: [Mono-dev] Patches for mono-winforms

2012-07-28 Thread Stifu
fire twice rather than once (despite the fact I said in the bug comments that the bug seemed fixed). If you can't think of a way to fix this, it's alright. Just thought I'd bring that up. Stifu wrote It's in (https://github.com/mono/mono/commit/75714e424afd2ee458e1288d756c914a4df2554f), thanks

Re: [Mono-dev] Newly broken WinForms unit tests

2012-07-28 Thread Stifu
Hmm, Assert.Throws() has been introduced in NUnit 2.5. It's also used in MenuTest, by the way. Not sure what's wrong. Steven Boswell II wrote Some time after 7pm MST last night, changes were checked in that broke three WinForms unit tests. 1) 

Re: [Mono-dev] Patch for bug 6198/2263(Revision)

2012-07-27 Thread Stifu
You got me confused for a second. You mean bug 2663, not 2263. Rob Wilkens wrote I'm attaching a patch to bug2263 fix which was reported in bug6198. I am unable to submit it via git right now due to connection issues and a corrupt linux install. Please review/comment or just apply if

Re: [Mono-dev] Patches for mono-winforms

2012-07-26 Thread Stifu
is updated improperly.  Enclosed is the unit test, patch, and project, as usual. Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Tuesday, July 24, 2012 10:53 PM Subject: Re: [Mono-dev] Patches for mono-winforms

Re: [Mono-dev] Patches for mono-winforms

2012-07-24 Thread Stifu
fixes I hadn't sent you yet.  Enclosed is a new version of the unit test that works around the visual artifact by adding another button to the layout. Any thoughts on my fix for mixed-mode checkboxes? Steven Boswell From: Stifu lt;stifu@gt; To: mono

Re: [Mono-dev] Patches for mono-winforms

2012-07-24 Thread Stifu
have two more table-layout bug fixes to submit after this one. From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Monday, July 23, 2012 11:49 PM Subject: Re: [Mono-dev] Patches for mono-winforms Hmm, so the patch is exactly the same, only

Re: [Mono-dev] Patches for mono-winforms

2012-07-24 Thread Stifu
Patch applied, thanks! https://github.com/mono/mono/commit/a1e7e4ebf7737572e349c69fc0ae56bd28517891 Steven Boswell II wrote OK, here's a much simpler patch. It draws a mixed-mode checkbox with a grey checkmark. Let me know if there's any problems. Steven Boswell

Re: [Mono-dev] Mono and Microsoft open sourced Entity Framework

2012-07-24 Thread Stifu
I somehow missed that news. Great stuff! Marek Safar-2 wrote Hi, Yes, we are working on EF integration. Marek On Tue, Jul 24, 2012 at 9:09 PM, Daniel Morgan lt;monodanmorg@gt;wrote: Since Microsoft has open sourced the Entity Framework, is anyone working on getting it to work on

Re: [Mono-dev] Patches for mono-winforms

2012-07-24 Thread Stifu
The TableLayoutPanelTest2 project works properly without patching Mono. No errors, same rendering as .NET. http://mono.1490590.n4.nabble.com/file/n4650550/mono_tablelayout2.png mono_tablelayout2.png Steven Boswell II wrote Enclosed is bug fix #2 of 3 for TableLayoutPanel.

Re: [Mono-dev] Patches for mono-winforms

2012-07-23 Thread Stifu
project, superimposed over your screenshot.  As you can see, the layout is the same as the .NET one in your screenshot. Thanks for looking at my patches. Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Sunday, July 22, 2012

Re: [Mono-dev] Patches for mono-winforms

2012-07-22 Thread Stifu
Any ideas why your test case looks different depending on the framework? http://mono.1490590.n4.nabble.com/file/n4650502/mono_patch12.png mono_patch12.png From left to right: Mono unpatched, Mono patched, .NET. Steven Boswell II wrote Here's the first of what I hope will be several

Re: [Mono-dev] Patches for mono-winforms

2012-06-24 Thread Stifu
. From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Saturday, June 23, 2012 4:19 PM Subject: Re: [Mono-dev] Patches for mono-winforms I just noticed patch 6 (https://github.com/mono/mono/commit/3d04a14a278d6160e33c16b52b86d68fe45d80b1

Re: [Mono-dev] Patches for mono-winforms

2012-06-24 Thread Stifu
Sorry, I was wrong: bug 5834 *is* caused by patch 6, too. (I messed up my tests as I'm juggling between .NET 2.0 or 4.0 depending on the application I'm testing, which have separate WinForms DLLs.) I'll go ahead and commit my fix, then. Stifu wrote The thought crossed my mind, but I'm

Re: [Mono-dev] Patches for mono-winforms

2012-06-23 Thread Stifu
this screenshot is from: http://epicedit.stifu.fr/download/EpicEdit_2.5.zip By the way, I just reported bug 5834 (https://bugzilla.xamarin.com/show_bug.cgi?id=5834), which may be related, except that one isn't a regression. Maybe we can kill two birds with one stone. Stifu wrote PS: there's

Re: [Mono-dev] Patches for mono-winforms

2012-06-21 Thread Stifu
the unit test succeed.  You can also run the enclosed project to see it succeed under .NET, fail with unpatched Mono, and succeed with patched Mono. There doesn't seem to be any existing bug reports on this issue. Hopefully this patch is a slam dunk, and Stifu doesn't have to waste his time

Re: [Mono-dev] Patches for mono-winforms

2012-06-21 Thread Stifu
, then apply the patch, and watch the unit test succeed.  You can also run the enclosed project to see it succeed under .NET, fail with unpatched Mono, and succeed with patched Mono. There doesn't seem to be any existing bug reports on this issue. Hopefully this patch is a slam dunk, and Stifu

Re: [Mono-dev] Patches for mono-winforms

2012-06-20 Thread Stifu
Steven, about the strange test issues you mentioned, were you talking about the OneClickComboBoxCell method, or not? Because I just realized this test passes when run individually, but fails when run along with others. Steven Boswell II wrote I just ran into a puzzler...I was trying to write

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-19 Thread Stifu
so, i think we can read xml from a string using a stringreader.. I just wasn't thinking it through. Give me some time today to get that done, it's 5:40am and i haven't had coffee yet. -Rob On 06/19/2012 01:56 AM, Stifu wrote: Can't we simplify the test to avoid having to include

Re: [Mono-dev] Patches for mono-winforms

2012-06-18 Thread Stifu
wrong...here's a patch to make the just-checked-in unit-test correct. Thanks for supporting my bug fixes! Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Sunday, June 17, 2012 3:08 PM Subject: Re: [Mono-dev] Patches

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-18 Thread Stifu
: Rob Wilkens lt;robwilkens@gt; To: mono-devel-list@.ximian lt;mono-devel-list@.ximiangt;; Stifu lt;stifu@gt; Sent: Sunday, June 17, 2012 6:05 PM Subject: [Mono-dev] Win Patches for Datagrid (first here) then idle [... If you want me to create a unit test for something you don't see a unit

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-18 Thread Stifu
the sample crash as is and not crash with my fix. -Rob On 06/18/2012 02:42 AM, Stifu wrote: A lot of work ahead, I see. About patch 1... I cannot manage to run the concerned test case with Mono master, for some reason (I get a NullReferenceException in the DataGrid constructor). I can run

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-18 Thread Stifu
Alright, the first patch is in (https://github.com/mono/mono/commit/42ebb31fc143a171a6a5930bc647627c557842ee). I took the liberty to change the coding style. Thanks. Rob Wilkens wrote This is for Stifu: Please follow this sequence when applying or testing the patches listed below. Doing

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-18 Thread Stifu
test for that bug if you want it (attached)... -Rob On 06/18/2012 04:39 PM, Stifu wrote: Alright, the first patch is in (https://github.com/mono/mono/commit/42ebb31fc143a171a6a5930bc647627c557842ee). I took the liberty to change the coding style. Thanks. Rob Wilkens wrote

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-18 Thread Stifu
PLUS the current column (which may be invalid) width.. I don't think it'll be a problem though and can probably stand as-is. -Rob On 06/18/2012 04:39 PM, Stifu wrote: Alright, the first patch is in (https://github.com/mono/mono/commit/42ebb31fc143a171a6a5930bc647627c557842ee). I took

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-18 Thread Stifu
result is probably OK. The version below is probably good if you're ok with it. -Rob On 06/18/2012 04:58 PM, Stifu wrote: Hah, that thought did cross my mind. Did you just wait for me to push it before saying that? :p We could go for: int next_pixel_offset

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-18 Thread Stifu
it wrong myself (I don't recall now).. :-) I'm sure in the case where this version you wrote would result in a zero result, the zero result is probably OK. The version below is probably good if you're ok with it. -Rob On 06/18/2012 04:58 PM, Stifu wrote: Hah, that thought did cross my mind

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-18 Thread Stifu
If it took me 3 tries to get such a simple patch in, I think I'd rather resign. :) Anyway, I'll check out the other patches another day. Is patch 2 hard to test? I haven't looked at it yet. Rob Wilkens wrote Thanks for not blindly trusting me :-) On 06/18/2012 05:20 PM, Stifu wrote

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-18 Thread Stifu
If you could just write the unit test, that should be all I need. Rob Wilkens wrote In an automatable way, yes. By hand, not that hard. I can try to describe how to test it if you need. -Rob On 06/18/2012 05:27 PM, Stifu wrote: If it took me 3 tries to get such a simple patch in, I

Re: [Mono-dev] Win Patches for Datagrid (first here) then idle

2012-06-18 Thread Stifu
5511. The 5487 testing is a bonus because its part of the test, and 5510 was one that i only reported once and never happened after i put this patch on. -Rob On 06/18/2012 05:35 PM, Stifu wrote: If you could just write the unit test, that should be all I need. Rob Wilkens wrote

Re: [Mono-dev] Patches for mono-winforms

2012-06-17 Thread Stifu
it to succeed in .NET was plenty helpful. Stifu...whether I build it with .NET or Mono, I get the error I mentioned, running the application with Mono on Windows...if you ran it with unpatched Mono, that's what I expect to happen.  If you ran it with patched Mono or with .NET, I wouldn't.  What

Re: [Mono-dev] Patches for mono-winforms

2012-06-17 Thread Stifu
(and not building,, though i've got a tree half-built that fixes that) version of mono. -rob On Jun 17, 2012, at 4:21 AM, Stifu wrote: To clear things up, when running with .NET, I do *not* get the error. I was just making it clear that whether I *build* the application with .NET or Mono doesn't make

Re: [Mono-dev] Patches for mono-winforms

2012-06-17 Thread Stifu
it matter whether i tested with my older robwilkens/mono tree or do i need to test with the latest and greatest (and not building,, though i've got a tree half-built that fixes that) version of mono. -rob On Jun 17, 2012, at 4:21 AM, Stifu wrote: To clear things up, when running with .NET, I do

Re: [Mono-dev] Patches for mono-winforms

2012-06-17 Thread Stifu
. In this case, i didn't commit anything. git checkout file did work for me though, it checked out the one from the current copy of my tree, replacing the modified file which i never did a git add on. I will try tortoisegit in my windows install. -Rob On 06/17/2012 07:15 AM, Stifu wrote: Heh. So

Re: [Mono-dev] Patches for mono-winforms

2012-06-17 Thread Stifu
previously only used the one in cygwin).. So i'll wait till that install is done before i consider reinstalling tortoise and trying the other option . On 06/17/2012 07:31 AM, Stifu wrote: I will try tortoisegit in my windows install. When installing it, make sure not to pick the Putty

Re: [Mono-dev] Restart my fork?

2012-06-17 Thread Stifu
Can't really give Git-related advices, I suck at it, but I can easily review WinForms patches if you simply attach them to your messages the old-school way. Robert Wilkens wrote My master branch contains two unrelated winforms changes (one change for idle, one change for DataGrid - not

Re: [Mono-dev] Restart my fork?

2012-06-17 Thread Stifu
go out. -Rob On 06/17/2012 08:21 AM, Stifu wrote: Can't really give Git-related advices, I suck at it, but I can easily review WinForms patches if you simply attach them to your messages the old-school way. Robert Wilkens wrote My master branch contains two unrelated winforms changes

Re: [Mono-dev] Restart my fork?

2012-06-17 Thread Stifu
on the pull page, but i will try to separate the changes out into what fixes what. -Rob On 06/17/2012 09:26 AM, Stifu wrote: Please separate each patch, so I can review them one by one. This is just too big to review, and I don't know even know what it's trying to fix. Also, please

Re: [Mono-dev] Restart my fork?

2012-06-17 Thread Stifu
that, but in that cases, at least some of the commits will have to be applied in the same order because they have a dependency on a previous commit going through. -Rob On 06/17/2012 09:34 AM, Stifu wrote: Alright, I'm not in a hurry. Rob Wilkens wrote I won't have time to do that right now

Re: [Mono-dev] Patches for mono-winforms

2012-06-17 Thread Stifu
patience -- the fact that you got it to succeed in .NET was plenty helpful. Stifu...whether I build it with .NET or Mono, I get the error I mentioned, running the application with Mono on Windows...if you ran it with unpatched Mono, that's what I expect to happen.  If you ran it with patched

Re: [Mono-dev] Patches for mono-winforms

2012-06-17 Thread Stifu
it successfully FINALLY get this patch committed. MY GOD, building Mono under MS Windows is slow.  I don't realize how spoiled I am by Linux until times like this. Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Sunday, June 17, 2012

Re: [Mono-dev] Patches for mono-winforms

2012-06-17 Thread Stifu
Patch 2 is in (https://github.com/mono/mono/commit/508b0c06680caa89e8ef9a0d0cd6c05d3126a6ab). Thanks for your work. Stifu wrote What I do on Windows is only build WinForms, and that takes 2 seconds. But this requires fixing the WinForms project first. (By the way, I tried building Mono

Re: [Mono-dev] .net winforms and windows

2012-06-13 Thread Stifu
Just to make sure, you mean you get these issues with .NET, with Mono, or with both? Anyway, to clear things up, as far as GDI+ and WinForms are concerned, the goal is to be as compatible with them as possible, not to make something better or more powerful. Ideally, the same things should work or

Re: [Mono-dev] Patches for mono-winforms

2012-06-11 Thread Stifu
Patch 7 has been pushed (https://github.com/mono/mono/commit/1743a005ccdc0d8c93795e236d2a5a32043b722c). Only one left. Stifu wrote I'll take care of this soon. For the record, I'll go ahead and change the visibility of all new test classes and struct to private. I don't think they need

Re: [Mono-dev] Threading and Winforms on Win32 only

2012-06-11 Thread Stifu
From http://www.mono-project.com/FAQ:_Winforms: Mono's implementation of WinForms does not support Forms or Controls being created on multiple threads. All Forms/Controls must be created on the same thread. Note this only applies to creation. You can still write multithreaded applications that

Re: [Mono-dev] Patches for mono-winforms

2012-06-10 Thread Stifu
Patch 9 has been slam dunked (https://github.com/mono/mono/commit/33831c2a77cd6a7369051022df385de29f3970a6). Thanks for the quick patch. Steven Boswell II wrote Enclosed is a new patch, one that fixes the differences in DataGridView's firing of SelectionChanged events between .NET and Mono,

Re: [Mono-dev] I think i've fixed the whitespace

2012-06-10 Thread Stifu
I might be able to look at your fixes at some point, but no promises. Testing only on X11 isn't an issue for most changes. By the way, I'm a Windows user but don't bother with cygwin anymore. I just can't stand that thing. I just grab the sources from Git and build them with my IDE (that

Re: [Mono-dev] I think i've fixed the whitespace

2012-06-10 Thread Stifu
of these finish in reasonable time because both systems go to 'sleep' often (the mac automatically, and the laptop, when i close the lid). The cygwin build seems slow, not sure what to expect from the mac. -Rob On Jun 10, 2012, at 8:10 AM, Stifu wrote: I might be able to look at your

Re: [Mono-dev] I think i've fixed the whitespace

2012-06-10 Thread Stifu
, should i expect problems? I'm working on my mac at the moment, autogen complained that it needed get text so i downloaded and am installing/building-from-scratch that now. Thanks Rob On Jun 10, 2012, at 8:34 AM, Stifu wrote: Yes, if you change the driver parts, you should test

Re: [Mono-dev] Patches for mono-winforms

2012-06-10 Thread Stifu
tests, though I thought I had the new ones, hence the confusion. Thanks! Stifu wrote Patch 9 has been slam dunked (https://github.com/mono/mono/commit/33831c2a77cd6a7369051022df385de29f3970a6). Thanks for the quick patch. Steven Boswell II wrote Enclosed is a new patch, one that fixes

Re: [Mono-dev] Patches for mono-winforms

2012-06-10 Thread Stifu
I don't know for sure, but if there seems to be no nicer way, let's go for that. It can still be changed later anyway. Other unit tests are certainly not perfect anyway, there are a couple that fail with .NET. Steven Boswell II wrote I figured out why my unit-test project for patch #7 wasn't

Re: [Mono-dev] Patches for mono-winforms

2012-06-10 Thread Stifu
From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Sunday, June 10, 2012 1:45 PM Subject: Re: [Mono-dev] Patches for mono-winforms I don't know for sure, but if there seems to be no nicer way, let's go for that. It can still be changed later anyway

Re: [Mono-dev] Patches for mono-winforms

2012-06-09 Thread Stifu
, especially since it's a visual change so it's pretty much impossible to make a unit test for it. BTW, I couldn't find any bug reports for this issue. Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Thursday, June 7, 2012 11:13 PM

Re: [Mono-dev] Patches for mono-winforms

2012-06-09 Thread Stifu
for committing my other patch.  I had totally forgotten about my account on GitHub.  Kudos for finding it. :-) Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Saturday, June 9, 2012 12:03 AM Subject: Re: [Mono-dev] Patches

Re: [Mono-dev] Patches for mono-winforms

2012-06-09 Thread Stifu
Patch 5 has been pushed (https://github.com/mono/mono/commit/f2b0672d8c65ccc08582d1b24783630e1237bcef). Thanks again. Now, let's see... Patch 1: under review Patch 2: waiting for unit test Patch 3: pushed, but with one remaining problem Patch 4: waiting for unit test Patch 5: pushed Patch 6:

Re: [Mono-dev] Patches for mono-winforms

2012-06-09 Thread Stifu
, but not with patched Mono, nor with .NET under MS Windows. See how it works for you. Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Saturday, June 9, 2012 12:41 PM Subject: Re: [Mono-dev] Patches for mono-winforms Patch 4

Re: [Mono-dev] Patches for mono-winforms

2012-06-04 Thread Stifu
mouse-clicks.  Now, it only takes one.  This brings the behavior in line with .NET.  Let me know what you think of this change. Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Sunday, June 3, 2012 3:20 PM Subject: Re: [Mono-dev

Re: [Mono-dev] DataGrid changes recently?

2012-06-04 Thread Stifu
changes and put a description on them) git push . (to send them to github, at least i think that's what this does) and whatever i can figure out by blindly clicking around on github.com. -Rob On 06/03/2012 06:37 PM, Stifu wrote: By the way, make sure to check out the coding guidelines

Re: [Mono-dev] Patches for mono-winforms

2012-06-04 Thread Stifu
.  If the EditingControlShowing event isn't being called from my patched code, I'd like to know where it's being called from. And I'll go ahead and write unit tests for patches 2, 4, 5, and 7, if I can figure out some. Steven Boswell From: Stifu lt;stifu@gt

Re: [Mono-dev] Patches for mono-winforms

2012-06-04 Thread Stifu
tests for patches 2, 4, 5, and 7, if I can figure out some. Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Sunday, June 3, 2012 11:03 PM Subject: Re: [Mono-dev] Patches for mono-winforms Also, as far as I can tell

Re: [Mono-dev] Patches for mono-winforms

2012-06-04 Thread Stifu
of the Control.Focused property isn't consistent during an OnLeave event.  Under .NET, it appears to always be false.  Under Mono, I've seen both true and false. Thanks to all for putting up with me. :-) Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list

Re: [Mono-dev] Patches for mono-winforms

2012-06-03 Thread Stifu
From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Saturday, June 2, 2012 1:09 PM Subject: Re: [Mono-dev] Patches for mono-winforms Hmm, I don't think the added dependency to System.Linq in the tests is OK. The whole thing is supposed

Re: [Mono-dev] Patches for mono-winforms

2012-06-03 Thread Stifu
This patch does not look good to me, because you're changing the public API. In DataGridViewCell, the InitializeEditingControl method expects 2 parameters rather than 3 after your patch, which means we're breaking the API and are no longer compatible with .NET. Steven Boswell II wrote

Re: [Mono-dev] DataGrid changes recently?

2012-06-03 Thread Stifu
If this particular bug hasn't been reported, then yeah, go ahead and report it. And whoever was assigned to WinForms bugs in 2006, don't expect anything to get done (obviously, after 6 years...). The Mono team announced they wouldn't work on WinForms anymore, and that it was up to the community to

Re: [Mono-dev] Patches for mono-winforms

2012-06-03 Thread Stifu
sure the event-handler gets called.  Enclosed is another attempt. Also, do you have any further comments about patch 3?  For your convenience, I've enclosed another copy. From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Sunday, June 3, 2012 8

Re: [Mono-dev] DataGrid changes recently?

2012-06-03 Thread Stifu
that needed more love for spaces. a=b; should be a = b; if (a==b) should be if (a == b), etc Rob Wilkens wrote On 06/03/2012 05:30 PM, Stifu wrote: If this particular bug hasn't been reported, then yeah, go ahead and report it. And whoever was assigned to WinForms bugs in 2006, don't expect anything

Re: [Mono-dev] Patches for mono-winforms

2012-06-02 Thread Stifu
for the other bugs. I'll go read about NUnit now. Thanks for reviewing my bug fixes! Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Friday, June 1, 2012 4:33 PM Subject: Re: [Mono-dev] Patches for mono-winforms You

Re: [Mono-dev] Patches for mono-winforms

2012-06-02 Thread Stifu
to run these unit tests against .NET, to make sure that what Mono does matches up with what .NET does? Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Saturday, June 2, 2012 8:45 AM Subject: Re: [Mono-dev] Patches for mono

Re: [Mono-dev] Patches for mono-winforms

2012-06-01 Thread Stifu
Hello, Thanks for your work. If I'm not mistaken, you reported each of these bugs, right? At least I could find the two first ones in bugzilla, but didn't go further. Anyway, I suggest you make pull requests for each bug separately, specifying the bug number. Also, please include unit tests with

Re: [Mono-dev] Patches for mono-winforms

2012-06-01 Thread Stifu
:-) Steven Boswell From: Stifu lt;stifu@gt; To: mono-devel-list@.ximian Sent: Thursday, May 31, 2012 11:06 PM Subject: Re: [Mono-dev] Patches for mono-winforms Hello, Thanks for your work. If I'm not mistaken, you reported each of these bugs

Re: [Mono-dev] Request for Novell bug maintainer

2012-05-30 Thread Stifu
So, there is nothing left to fix in this bug, and Mono behaves the same as .NET. Is that right? By the way, I think that on bugzilla.novell, anyone can close bugs and all, unlike on xamarin.bugzilla. Robert Wilkens wrote I was just looking at this old 'bug' from the Novell's bugzilla:

Re: [Mono-dev] I'm hooked

2012-05-27 Thread Stifu
fires to put out), and familiarize myself as I go with things i'm uncomfortable with (like setting up an apache/asp.net development environment - as a small example). -Rob On May 26, 2012, at 2:50 AM, Stifu wrote: Tests are part of the fun, IMO. And they prove you're not just randomly

Re: [Mono-dev] I'm hooked

2012-05-26 Thread Stifu
Tests are part of the fun, IMO. And they prove you're not just randomly changing code for the sake of it. I haven't contributed much, but I guess something like 3/4 of the code I submitted it was tests. Rob Wilkens wrote -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Glad to hear it --

Re: [Mono-dev] Mono Maintainers list

2012-04-10 Thread Stifu
Hi, Tom Hindle and myself (Thomas Goldstein) have been maintaining WinForms a little. I'm not very active, but I don't mind reviewing patches if the impacted code is within my knowledge. No IRC for me. Alex wrote Hello folks! I'm planning to write and maintain a page listing maintainers

Re: [Mono-dev] Xamarin Bugzilla issues

2011-11-27 Thread Stifu
About the second point, going to Preferences / Permissions, I see There are no permission bits set on your account.. I take it that's a difference from Novell's Bugzilla, where anyone could edit bugs. Could someone grant me the needed rights? Stifu wrote Hi, 2 problems I'm having

[Mono-dev] Xamarin Bugzilla issues

2011-11-25 Thread Stifu
Hi, 2 problems I'm having with the Xamarin bugzilla: 1- Someone commented on bug #395 (http://bugzilla.xamarin.com/show_bug.cgi?id=395), but I never received notification mails. After having double checked my preferences, I should have. It's not in my spam folder or anything. 2- I cannot edit

Re: [Mono-dev] Hi, I'm new here.

2011-11-20 Thread Stifu
Mono is a framework, which includes compiler and runtime. It's a reimplementation of the .NET framework. How you use it depends on your goals. DeltaAccel wrote: So, what's mono? Is it a compiler or a bunch of DLL I can attach to Visual C#? I'm new at this :P -- View this message in

Re: [Mono-dev] int.Parse possible bug

2011-10-28 Thread Stifu
Could you please file a bug report, so this doesn't get buried and lost? k0l0b0k.void wrote: Hello. I've reached next difference between Mono and .NET fw in mscorlib - on the following code: Console.WriteLine(int.Parse(0x3E0, System.Globalization.NumberStyles.Any)); .NET fw

Re: [Mono-dev] Byte Array to Bitmap

2011-08-30 Thread Stifu
Your questions are Mono / .NET questions, not MonoDevelop (IDE) related. Maybe you could do something like this: System.IO.MemoryStream ms = new System.IO.MemoryStream(data); // data being your byte array System.Drawing.Bitmap image = new System.Drawing.Bitmap(ms); // Don't forget to Dispose

Re: [Mono-dev] substantial performance regression between 2.10 and 2.6 or impl diff?

2011-08-27 Thread Stifu
Here are my results when running your benchmark. My PC: a very old a cheap Windows XP Celeron. I compiled the application with .NET, and ran it with Mono. I ran the benchmark 3 times to make sure results were reliable. Mono 2.6.3: structs: just below 15 seconds classes: just below 40 seconds

Re: [Mono-dev] substantial performance regression between 2.10 and 2.6 or impl diff?

2011-08-27 Thread Stifu
Follow-up: Reminder, my results were: Mono 2.6.3: structs: just below 15 seconds classes: just below 40 seconds Mono 2.10.3: structs: just above 19 seconds classes: just above 40 seconds And this is with Mono 2.8.1: structs: just below 15 seconds classes: just above 40 seconds So structs are

Re: [Mono-dev] Environment.GetFolderPath() behaviour inconsistent with .NET

2011-08-18 Thread Stifu
I understand your points, Miguel, but it sucks not to be able to be consistent / compatible with .NET here. I know it's not possible to get numbers, but how many Mono OSX apps do you think currently rely on this feature vs how many Silverlight / .NET apps could benefit from this change? And it's

Re: [Mono-dev] Mono's future

2011-07-06 Thread Stifu
It's a matter of priorities. You don't spend too much time on something with 2 users. And you don't mind too much if there is no Mono for Oric. But if you want to submit patches related to other platforms or OSes, just ask for them to get reviewed. On a side note, iOS is not OSX, and it's getting

Re: [Mono-dev] JSON Deserialization

2011-04-24 Thread Stifu
I tried it with .NET. It also throws an exception (System.Runtime.Serialization.InvalidDataContractException). Type 'JsonTest.Element' cannot be serialized. Consider marking it with the DataContractAttribute attribute, and marking all of its members you want serialized with the

Re: [Mono-dev] JSON Deserialization

2011-04-24 Thread Stifu
I tried that, and it didn't work here. Maybe I didn't set up something right (which is why self-contained test cases are always welcome). It complains about the fact the token '' was expected, but 'N' was found. Error message (in French): System.Runtime.Serialization.SerializationException: Une

Re: [Mono-dev] Someone to review libgdiplus patches?

2011-03-27 Thread Stifu
He just replied: https://bugzilla.novell.com/show_bug.cgi?id=666245 I'll let you deal with this if you want to, Miguel. If I can help, let me know. Stifu wrote: Alright, I asked for a test case in the bug report. Miguel de Icaza wrote: Hello, Just a quick heads up. Could someone

Re: [Mono-dev] Faster

2011-03-25 Thread Stifu
Huh? I don't get it. In the exception handling code, it checks if x is null, so it'd go to the throw; part instead. No reason it'd act as if x was null. Steve Lessard wrote: I think Sebastian already touched on this issue, but I wanted to shine a little more light on it. If the Something

  1   2   3   >