[Mono-dev] Object data source update fails on nullable field.

2008-12-16 Thread Vladimir Krasnov
Hi Marek, I've found some problems in updating row in GridView control that bound to ObjectDataSource. 1. ObjectDataSource fails to convert values to Nullable<> properties while creating data object. 2. BoundField should return null when no value entered by the user, it returns empty string and

[Mono-dev] Performance improvement for System.Web.UI.Page.RegisterRequiresPostBack

2008-02-19 Thread Vladimir Krasnov
Hello, Please review and approve attached patch that improves Page.RegisterRequiresPostBack method, it will give up to 5% for controls that calls this method. Vladimir Page.cs.patch Description: Page.cs.patch ___ Mono-devel-list mailing list Mono-de

[Mono-dev] Patch for System.Web.UI.Page.DeterminePostBackMode

2008-01-16 Thread Vladimir Krasnov
Hello, This is performance optimization patch, which fixes common flow when no query string in request, please review. Regards, Vladimir HttpRequest.cs.patch Description: HttpRequest.cs.patch Page.cs.patch Description: Page.cs.patch ___ Mono-devel

[Mono-dev] Patch for System.Web.HttpContext

2008-01-16 Thread Vladimir Krasnov
Hello, Please review and approve attached performance optimization patch. Regards, Vladimir HttpContext.cs.patch Description: HttpContext.cs.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listi

Re: [Mono-dev] Patch for System.ComponentModel.TypeDescriptor

2008-01-03 Thread Vladimir Krasnov
N. Zlatev Sent: Thursday, January 03, 2008 2:24 AM To: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] Patch for System.ComponentModel.TypeDescriptor Vladimir Krasnov wrote: > > > Hello, > > Please review and approve attached patch for > TypeDescriptor.GetProperties(

[Mono-dev] Patch for System.ComponentModel.TypeDescriptor

2008-01-02 Thread Vladimir Krasnov
Hello, Please review and approve attached patch for TypeDescriptor.GetProperties() method. This fixes the order of properties in the returning collection which is important for System.Web data bound controls. Vladimir TypeDescriptor.cs.patch Description: TypeDescriptor.cs.patch _

[Mono-dev] Patch for CacheDependency and InternalCache

2007-12-25 Thread Vladimir Krasnov
Hello, Please review and approve attached patch for CacheDependency and InternalCache. When InternalCache used for caching, CacheDependency should be based on public cache. Regards, Vladimir DataSourceCacheManager.cs.patch Description: DataSourceCacheManager.cs.patch HttpRuntime.cs.patch Desc

[Mono-dev] Patch for System.ComponentModel.PropertyDescriptionCollection

2007-12-25 Thread Vladimir Krasnov
Hello, Please review and approve attached patch for System.ComponentModel.PropertyDescriptionCollection. It fixed Find method that should not use culture sensitive string compare. Rwgards, Vladimir PropertyDescriptorCollection.cs.patch Description: PropertyDescriptorCollection.cs.patch Prope

[Mono-dev] Patch for System.Web.HttpApplication

2007-12-20 Thread Vladimir Krasnov
Hello, Please review and approve attached patch that fixes the following bugs: 1. Response.Redirect does not work from Page_Error error handler, instead user gets the source exception 2. Context.ClearError does not work in Page_Error error handler 3. Thread.Abort() call initiated from user code i

[Mono-dev] Patch for System.Web.Compilation.AppSettingsExpressionBuilder

2007-12-18 Thread Vladimir Krasnov
Hello, Please review and approve attached patch for AppSettingsExpressionBuilder.GetAppSetting method, It fixes value conversion to the type of property parameter. Regards, Vladimir AppSettingsExpressionBuilder.cs.patch Description: AppSettingsExpressionBuilder.cs.patch AppSettingsExpressi

[Mono-dev] Patch for System.Web.UI.ListControl

2007-12-17 Thread Vladimir Krasnov
Hello, Please review and approve attached patch for System.Web.UI.ListControl that fixes the following problems in viewstate management of ListItem and ListItemCollection: 1. Setting ListItem.Selected to true cause viewstate generation for selected indeces even if not tracked 2. Modifying ListIte

[Mono-dev] System.Web.Services patch

2007-11-27 Thread Vladimir Krasnov
Hello, Please approve the following patches for System.Web.Services: 1. ProtocolReflector patch fixes ports with the same name declaration when non-default binding used. 2. TypeStubManager patch fixes default binding, when custom bindig declared, but not used. Vladimir ProtocolReflector.cs.pat

[Mono-dev] System.Web.Services.Protocols.BindingInfo.ctor

2007-07-29 Thread Vladimir Krasnov
Hello Atsushi, You've replaced ONLY_1_1 with NET_1_1 (r76113) but I think there should be ONLY_1_1, look at my commit r74057. The problem is that in WSDL document has two ports entries with the same name, which causes wsdl.exe tool to fail. I've reverted your fix, fix me if I'm wrong. Vladimir

[Mono-dev] Performance improvement in System.Web.HttpWriter

2007-05-14 Thread Vladimir Krasnov
Hello, Please approve attached patch that improves performance of HttpWriter. It uses GetMaxByteCount in Write and WriteString methods instead of GetBytesCount. Vladimir HttpWriter.cs.patch Description: HttpWriter.cs.patch ___ Mono-devel-list mailing

[Mono-dev] System.Web.HttpRequest.Params collection optimization

2007-04-12 Thread Vladimir Krasnov
Hello, Please review a performance optimization for HttpRequest.Params collection. This collection contains ServerVariables, Form, QueryString and Cookies collections merged into one and expensive to initialize if someone uses Params collection to get values from query string, for example. So it u

[Mono-dev] (no subject)

2007-03-29 Thread Vladimir Krasnov
Hello, Please review a performance optimization for HttpRequest.Headers and HttpRequest.ServerVariables collections. It implements lazy collection fill because most common flow is to ask for value by name. Only if user ask for enumerator or count, collection will be fully loaded. This gives about

[Mono-dev] System.Web javascript modification for J2EE portal support

2007-02-05 Thread Vladimir Krasnov
Hello, Please approve attached patch that enables validators work correctly on J2EE portal with multiple forms on one page. I've added SetValidatorContext function to WebUIValidation_2.0.js script that will be executed every time before Page_ClientValidate function. This function check if Page

[Mono-dev] Refactiong in WebUIValidation_2.0.js

2007-02-05 Thread Vladimir Krasnov
Hello, There is unclear flow in initialization of evaluation function in ValidatorOnLoad function of WebUIValidation_2.0.js script, I suggest a refactoring that removes it. Please look at the attached patch and approve commit. Vladimir WebUIValidation_2.0.js.patch Description: WebUIValidation_

[Mono-dev] Bug in System.Data.SQLTypes.SqlDateTime

2007-01-30 Thread Vladimir Krasnov
Hello, There is a bug in SqlDateTime's MaxValue member, while initialization is calls SqlDateTime ctor which calls MaxValue that is not initialized yet. Please approve attached patch that fixes this bug. Vladimir SqlDateTime.cs.patch Description: SqlDateTime.cs.patch __

[Mono-dev] Bug in System.Web.UI/SclientScriptManager

2007-01-29 Thread Vladimir Krasnov
Hello Please approve attached patch that fixes bug in System.Web.UI/SclientScriptManager where webform.js and callback.js scripts were always rendered, even within an empty form. Vladimir Page.cs.patch Description: Page.cs.patch ClientScriptManager.cs.patch Description: ClientScriptManager.cs

[Mono-dev] Patch for System.Configuration.SettingsPropertyValue

2007-01-10 Thread Vladimir Krasnov
Hello, Please review attached patch that fixed SettingsPropertyValue.IsDirty property, it aslo corrects default value deserialization when it's null. Vladimir SettingsPropertyValue.cs.patch Description: SettingsPropertyValue.cs.patch SettingsPropertyValueTest.cs.patch Description: SettingsPr

[Mono-dev] FW: Bug System.Web.HttpRequest.IsLocal

2007-01-07 Thread Vladimir Krasnov
5:24 AM To: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] Bug System.Web.HttpRequest.IsLocal On Thu, 2007-01-04 at 06:49 -0800, Vladimir Krasnov wrote: > Hello, > > There is a bug in IsLocal method, it should check all host's ip > addresses, not only 127.0.0.1 Please

[Mono-dev] Bug System.Web.HttpRequest.IsLocal

2007-01-04 Thread Vladimir Krasnov
Hello, There is a bug in IsLocal method, it should check all host's ip addresses, not only 127.0.0.1 Please review attached patch. Vladimir HttpRequest.cs.patch Description: HttpRequest.cs.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.x

[Mono-dev] Bug in System.Web.HttpApplication

2007-01-03 Thread Vladimir Krasnov
Hello, There is a bug in PreStart method, it should not apply invariant culture. Please review attached patch that fixes this bug. Vladimir HttpApplication.cs.patch Description: HttpApplication.cs.patch ___ Mono-devel-list mailing list Mono-devel-list

[Mono-dev] Another bug in System.Configuration.SettingsPropertyValueTest

2007-01-01 Thread Vladimir Krasnov
Hello, There is another bug in SettingsPropertyValueTest class, default value should be desirialized with serialize method specified in the setting property Please review the patch that fixes this bug. Vladimir SettingsPropertyValue.cs.patch Description: SettingsPropertyValue.cs.patch Setti

[Mono-dev] Bug in System.Web.UI.Control.ResolveClientUrl

2006-12-31 Thread Vladimir Krasnov
Hello, There is a bug in ResolveClientUrl method when control that calls this method and the page are in different folders. Please review attached patch that fixes it. Vladimir Control.cs.patch Description: Control.cs.patch ___ Mono-devel-list maili

[Mono-dev] Bug in System.Configuration.SettingsPropertyValue class

2006-12-26 Thread Vladimir Krasnov
Hello, The bug is that default value is not converted to the property type. Please review attached patch that fixes the problem. Vladimir SettingsPropertyValue.cs.patch Description: SettingsPropertyValue.cs.patch ___ Mono-devel-list mailing list Mono

[Mono-dev] Bug in System.Configuration.ConfigurationProperty

2006-12-19 Thread Vladimir Krasnov
Hello, There is a problem with ConfigurationProperty when it has Enum type and it's DefaultValue specified as string. Please review attached patch that fixes the problem. Vladimir ConfigurationProperty.cs.patch Description: ConfigurationProperty.cs.patch

[Mono-dev] Bug in System.Web.UI.WebControls.DataGrid and DataList controls

2006-12-14 Thread Vladimir Krasnov
Hello, There is a bug in accessibility features in DataGrid and DataList controls. Please approve attached patch that fixes this bug. Vladimir DataGrid.cs.patch Description: DataGrid.cs.patch RepeatInfo.cs.patch Description: RepeatInfo.cs.patch ___

[Mono-dev] Patch for System.Configuration.SettingsBase

2006-12-11 Thread Vladimir Krasnov
Hello, Please review attached patch that implements Item property of System.Configuration.SettingsBase class. Vladimir SettingsBase.cs.patch Description: SettingsBase.cs.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://li

Re: [Mono-dev] Bug in System.Web.HttpRequest

2006-12-11 Thread Vladimir Krasnov
ug in System.Web.HttpRequest On Thu, 2006-12-07 at 02:20 -0800, Vladimir Krasnov wrote: > Hello, > > There is a bug in System.Web.HttpRequest. Propety path should return > an unescaped request uri. > Please approve attached patch that fixes the problem. There has to be another way of do

[Mono-dev] Bug in System.Configuration element

2006-12-07 Thread Vladimir Krasnov
Hello, There is another bug in element. Generic element ConfigurationRemoveElement should calculate key for remove by calling GetElementKey method of the collection from which elemnt will be removed. Please approve attached patch that fixes this problem. Vladimir ConfigurationRemoveElement.cs

[Mono-dev] Bug in System.Web.HttpRequest

2006-12-07 Thread Vladimir Krasnov
Hello, There is a bug in System.Web.HttpRequest. Propety path should return an unescaped request uri. Please approve attached patch that fixes the problem. Vladimir HttpRequest.cs.patch Description: HttpRequest.cs.patch ___ Mono-devel-list mailing lis

Re: [Mono-dev] Patch for System.Web.BrowserCapabilities

2006-12-06 Thread Vladimir Krasnov
Hello Miguel, I've checked IE6 and IE7 on my local machine and this is the values that I've got from .net web application. -Original Message- From: Miguel de Icaza [mailto:[EMAIL PROTECTED] Sent: Wednesday, December 06, 2006 5:06 PM To: Vladimir Krasnov Cc: mono-

[Mono-dev] Patch for System.Web.BrowserCapabilities

2006-12-06 Thread Vladimir Krasnov
Hello, Please approve patch that adds implementation of MSDomVersion property to BrowserCapabilities class. Vladimir browscap.ini.patch Description: browscap.ini.patch BrowserCapabilities.cs.patch Description: BrowserCapabilities.cs.patch ___ Mono-d

[Mono-dev] Patch for System.dll

2006-12-05 Thread Vladimir Krasnov
Hello, Please approve attached patch that implements System.Uri.UnescapeDataString method Vladimir system.dll.patch Description: system.dll.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinf

[Mono-dev] FW: Patch for System.Web.UI.FormsAuthenticationModule

2006-12-05 Thread Vladimir Krasnov
Hello, Please approve the patch that fixes exception throwing when authentication cookie value is wrong or empty. Vladimir -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Vladimir Krasnov Sent: Thursday, November 23, 2006 7:22 PM To: mono-devel-list

[Mono-dev] Patch for System.Web.UI.FormsAuthenticationModule

2006-11-23 Thread Vladimir Krasnov
Hello, Please approve the patch that fixes exception throwing when authentication cookie value is wrong or empty. Vladimir FormsAuthenticationModule.cs.patch Description: FormsAuthenticationModule.cs.patch ___ Mono-devel-list mailing list Mono-devel-l

[Mono-dev] Fix for System.Configuration.SettingsPropertyValue

2006-11-02 Thread Vladimir Krasnov
Hello, Please review and approve the attached patch for System.Configuration.SettingsPropertyValue class, it fixes PropertyValue property when it should be deserialized. Vladimir SettingsPropertyValue.cs.patch Description: SettingsPropertyValue.cs.patch _

[Mono-dev] Fix for System.Configuration

2006-11-02 Thread Vladimir Krasnov
Hello, Please review and approve attached paches, this will fix element in all configuration collections Vladimir ConfigurationElementCollection.cs.patch Description: ConfigurationElementCollection.cs.patch ConfigurationRemoveElement.cs.patch Description: ConfigurationRemoveElement.cs.patch

[Mono-dev] Bug in System.Web.HttpWriter

2006-09-10 Thread Vladimir Krasnov
Hello, In case of ResponseEncoding="utf-16", HttpWriter will write crlf not in utf-16 format. Please look at the attached patch that fixes the problem. Vladimir HttpWriter.cs.patch Description: HttpWriter.cs.patch ___ Mono-devel-list mailing list Mono

[Mono-dev] Bug in System.Web.UI.HtmlControls.HtmlInputFile

2006-09-07 Thread Vladimir Krasnov
Hello, Value property of the HtmlInputFile control should have full name of the file on the client's computer, for now, this property is not working. Please review attached patch that solves the problem. Vladimir Krasnov HtmlInputFile.cs.patch Description: HtmlInputFile.cs.

Re: [Mono-dev] Bug System.Web.Services

2006-09-07 Thread Vladimir Krasnov
XmlSchemaExporter are writing to common XmlSchema object. Vladimir Krasnov -Original Message- From: Lluis Sanchez [mailto:[EMAIL PROTECTED] Sent: Wednesday, September 06, 2006 7:23 PM To: Vladimir Krasnov Cc: mono-devel-list@lists.ximian.com Subject: Re: Bug System.Web.Services Hi! Well, the patch

[Mono-dev] Bug System.Web.Services

2006-09-06 Thread Vladimir Krasnov
Hello Lluis, The is a bug in getting wsdl, if web service has a web method with char parameter, it will be declared twice in the wsdl. Please look at the attached patch that fixes the problem. XmlSchemaExporter.cs.patch Description: XmlSchemaExporter.cs.patch ___

Re: [Mono-dev] Bug in System.Configuration

2006-09-03 Thread Vladimir Krasnov
Hello Chris, The previous patch caused a regression, please look at this one. Vladimir -Original Message- From: Chris Toshok [mailto:[EMAIL PROTECTED] Sent: Friday, September 01, 2006 12:40 AM To: Vladimir Krasnov Cc: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] Bug in

[Mono-dev] Bug in System.Configuration

2006-08-31 Thread Vladimir Krasnov
System.Configuration has a bug in processing tag, while deserializaing this element it creates configuration element of the same type as and fails because remove doesnt have required properties. Please look at attached patch that fixes this bug. Vladimir. configuration.patch Description: co

[Mono-dev] Patch for System.Web BulletedList control

2006-07-12 Thread Vladimir Krasnov
Hello, Please reeview attached patches that will fix BulletedList control and implement Enabled property of ListItem that is new in 2.0 Vladimir BulletedList.cs.patch Description: BulletedList.cs.patch ListItemCollection.cs.patch Description: ListItemCollection.cs.patch ListItem.cs.patch D

[Mono-dev] Patch for System.Web MultiView control

2006-07-11 Thread Vladimir Krasnov
Hello, Please review the patch that fixes various ActiveViewIndex bugs. It changes 'initied' state variable to views count in the views collection. Fixed tests: MultiView_ControlState, MultiView_OutOfRange, MultiView_OnBubbleEvent, MultiView_RemoveViewControlEvent, MultiView_SetActiveView in the

[Mono-dev] Bug in System.Web.MultiView and View

2006-07-06 Thread Vladimir Krasnov
* MultiView.ActiveViewIndex retruns wrong value before initied Vladimir Krasnov View.cs.patch Description: View.cs.patch MultiView.cs.patch Description: MultiView.cs.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman

[Mono-dev] System.Web.UI.WebControls.TemplatedWizardStep

2006-06-28 Thread Vladimir Krasnov
Hello, Please review TemplatedWizardStep for Wizard control. Vladimir Krasnov Wizard.cs.patch Description: Wizard.cs.patch TemplatedWizardStep.cs Description: TemplatedWizardStep.cs ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com

[Mono-dev] Patch for System.Web.UI.WebControls.Wizard

2006-06-26 Thread Vladimir Krasnov
Hello, Attached patch that fixes some differences in Wizard control rendering, please review. Vladimir Krasnov Wizard.cs.patch Description: Wizard.cs.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com

[Mono-dev] Patch for SystemWeb.UI.WebControls.WizardStepCollection

2006-06-26 Thread Vladimir Krasnov
Hello, Please review attached patch and a test case that fixes WizardStep.Wizard property, which should have a reference to its Wizard control. Vladimir Krasnov WizardStepCollection.cs.patch Description: WizardStepCollection.cs.patch WizardTest.cs Description: WizardTest.cs

RE: [Mono-dev] Bug in System.Web.UI.WebControls.BaseDataList

2006-06-14 Thread Vladimir Krasnov
Sorry, I've forgot the NET_2_0 ifdef, I will recommit. Vladimir Krasnov -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gonzalo Paniagua Javier Sent: Tuesday, June 13, 2006 5:58 PM To: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] B

RE: [Mono-dev] Bug in System.WebHttpUtility.UrlDecode

2006-05-10 Thread Vladimir Krasnov
esday, April 11, 2006 1:13 AM To: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] Bug in System.WebHttpUtility.UrlDecode On Mon, 2006-03-27 at 01:56 -0800, Vladimir Krasnov wrote: > Hello, > > There is a bug in UrlDecode method in System.WebHttpUtility, when two > precent chars

RE: [Mono-dev] Question about System.Web.UI.WebControls.DataList

2006-04-08 Thread Vladimir Krasnov
Hello, Since no one answered me, I suggest removing this method and all calls to it. Please approve the attached patch. If no one objects I will commit. Vladimir Krasnov -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Vladimir Krasnov Sent: Monday

RE: [Mono-dev] System.Web.Mail and TLS

2006-03-29 Thread Vladimir Krasnov
Hi Gonzalo, What if the response from SMTP server is multi-line? For example, SMTP from IIS 6.0 returns multi-line response on EHLO command. Vladimir Krasnov -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gonzalo Paniagua Javier Sent: Tuesday, March

[Mono-dev] Question about System.Web.UI.WebControls.DataList

2006-03-27 Thread Vladimir Krasnov
itten. I've commented out this method and everything continued working well (this also fixed the problem), so my question is what for is this method is needed? You can look at the test case: /System_Web_UI_WebControls/DataList/DataList_ExtractTemplateRows.aspx Vladim

[Mono-dev] Bug in System.Web.UI.WebControls.RepeatInfo

2006-03-27 Thread Vladimir Krasnov
attached patch that fixes this bug. If no one objects, I will commit. Vladimir Krasnov RepeatInfo.cs.2.patch Description: RepeatInfo.cs.2.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo

RE: [Mono-dev] System.Web.Mail and TLS

2006-03-27 Thread Vladimir Krasnov
Hi Gonzalo, What do you suggest about ReadResponse? Mono SslClientStream does not inherit from NetworkStream, so how can I know if more data is available in the stream and calling Read() again cannot be used because it blocks if no data available. Vladimir Krasnov -Original Message

[Mono-dev] Bug in System.WebHttpUtility.UrlDecode

2006-03-27 Thread Vladimir Krasnov
the patch that fixes this bug. If no one objects I will commit Vladimir Krasnov HttpUtility.cs.patch Description: HttpUtility.cs.patch HttpUtilityTest.cs.patch Description: HttpUtilityTest.cs.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.

[Mono-dev] Accessability features in System.Web controls

2006-03-22 Thread Vladimir Krasnov
Hello, Please take a look at the patches that add an accessibility features to DataGrid and DataList controls. Please approve the patches, if no one objects I will commit. Vladimir Krasnov RepeatInfo.cs.1.patch Description: RepeatInfo.cs.1.patch DataList.cs.9.patch Description: DataList.cs

[Mono-dev] Bug in System.Web.Mail.MailMessageWrapper

2006-03-22 Thread Vladimir Krasnov
Hello, Attached patch fixes a bug in Fields property of MailMessageWrapper class. The bug reproduces when I try to send mail message and add to it's fields non string value, for example: msg.Fields.Add("MyField", 123); Please approve the patch, if no one objects I will commit. V

[Mono-dev] Bug in System.Web.DataGrid control

2006-03-22 Thread Vladimir Krasnov
/DataGrid_AlternatingItemStyle.aspx Please approve the attached patches. if no one objects I will commit. Vladimir Krasnov DataGrid.cs.8.patch Description: DataGrid.cs.8.patch DataGrid.cs.6.patch Description: DataGrid.cs.6.patch ___ Mono-devel-list mailing

RE: [Mono-dev] System.Web.Mail and TLS

2006-03-22 Thread Vladimir Krasnov
March 21, 2006 9:12 PM To: Vladimir Krasnov Cc: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] System.Web.Mail and TLS Hello Vladimir, On Tue, 2006-03-21 at 10:17 -0800, Vladimir Krasnov wrote: > Hello, > > I'm working now on sending email over SSL connection using &

RE: [Mono-dev] PathInfo problem in System.Web

2006-03-21 Thread Vladimir Krasnov
Hi Gonzalo, Sorry for not approved commit, I thought if you've not objected the patch is ok. I've created a test case that reproduces the problem. Vladimir Krasnov -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gonzalo Paniagua Javier Sen

[Mono-dev] System.Web.Mail and TLS

2006-03-21 Thread Vladimir Krasnov
ived form server. Please take a look at this code and suggest what to do. Vladimir Krasnov. SmtpClient.cs.patch Description: SmtpClient.cs.patch SmtpStream.cs.patch Description: SmtpStream.cs.patch ___ Mono-devel-list mailing list Mono-devel-list@lists

[Mono-dev] Bugs in System.Web.UI.HtmlControls

2006-03-15 Thread Vladimir Krasnov
/HtmlInputImage/HtmlInputImage_Src.aspx Please approve these patches, If no one objects, I will commit Vladimir Krasnov HtmlInputImage.cs.patch Description: HtmlInputImage.cs.patch HtmlAnchor.cs.patch Description: HtmlAnchor.cs.patch HtmlForm.cs.1.patch Description: Html

RE: [Mono-dev] Bug in System.Web.Services inSoapMessage.ContentEncoding

2006-03-14 Thread Vladimir Krasnov
Hello, You right, Lluis I've fixed this in different way. Please look at attached files. Vladimir Krasnov -Original Message- From: Lluis Sanchez [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 14, 2006 1:51 AM To: Vladimir Krasnov Cc: mono-devel-list@lists.ximian.com Subject: Re:

RE: [Mono-dev] bug in datagrid

2006-03-06 Thread Vladimir Krasnov
Hi, The attached patch fixes the problem. Please check and approve. I will commit if no one objects. Unfortunately, I cannot create a test case, because a postback is needed to reproduce the problem. Vladimir Krasnov -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED

[Mono-dev] System.Web tests using inline delegates

2006-03-05 Thread Vladimir Krasnov
would like to check in the fixed version that is able to run in pure 1.1 version. Please approve the attached patches. Vladimir Krasnov LinkButtonTest.cs.patch Description: LinkButtonTest.cs.patch CalendarTest.cs.patch Description: CalendarTest.cs.

RE: [Mono-dev] Bug System.Web.UI.WebControls.RadioButton and RadioButtonList

2006-02-20 Thread Vladimir Krasnov
e TabIndex change looks ok. Chris On Thu, 2006-02-16 at 08:20 -0800, Vladimir Krasnov wrote: > Hello, > > The first problem that all radio buttons in RadioButtonList control are > placed into , this is because RadioButtonList adds > value of radio button as attribute. I think it'

RE: [Mono-dev] Bugs in System.Web.UI.WebControls.CheckBox and CheckBoxList

2006-02-20 Thread Vladimir Krasnov
if (!Enabled) w.AddAttribute (HtmlTextWriterAttribute.Disabled, "disabled"); no? Chris On Thu, 2006-02-16 at 06:17 -0800, Vladimir Krasnov wrote: > > Index: CheckBox.cs > === > --- CheckBox.

[Mono-dev] Bug in System.Web.UI.ControlCollection

2006-02-20 Thread Vladimir Krasnov
Hello, There is a bug in CopyTo method of ControlCollection. See attached patch for details. Test case: /System_Web_UI_WebControls/TableCellCollection/TableCellCollection_CopyT o_AI.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov

[Mono-dev] System.Web.Util.DataSourceResolver wrong exceptions

2006-02-20 Thread Vladimir Krasnov
Hello, ResolveDataSource method throws wrong exceptions. See attached patch for details. Test case: /System_Web_UI_WebControls/BaseDataList/BaseDataList_DataMember.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov DataSourceResolver.cs.patch

[Mono-dev] Bug in System.Web.UI.WebControls.DataList.RenderContents

2006-02-20 Thread Vladimir Krasnov
Hello, In case of no items it is nothing to render, so the control should avoid of generating empty table. Test case: /System_Web_UI_WebControls/BaseDataList/BaseDataList_DataSource.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov DataList.cs.8.patch

[Mono-dev] System.Web.UI.WebControls.DataList.RepeatColumns value validation missing.

2006-02-20 Thread Vladimir Krasnov
Hello, There should be value validation in RepeatColumns property, exception should be thrown in case of negative value. Test case: /System_Web_UI_WebControls/DataList/DataList_RepeatColumns.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov

[Mono-dev] Bug in System.Web.UI.WebControl.DataGrid

2006-02-19 Thread Vladimir Krasnov
Hello, While creating item in CreateControlHierarchy, items assigned with wrong DataSetIndex value (if paging enabled). Test case: /System_Web_UI_WebControls/DataGridItem/DataGridItem_DataSetIndex.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov

[Mono-dev] Bug in System.Web.UI.WebControl.DataGrid with no columns

2006-02-19 Thread Vladimir Krasnov
Hello, If no columns generated, no empty table struct should be rendered. Test case: /System_Web_UI_WebControls/DataGrid/DataGrid_AutoGenerateColumns.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov DataGrid.cs.4.patch Description: DataGrid.cs.4

[Mono-dev] Bug in WebControls.Style

2006-02-19 Thread Vladimir Krasnov
objects, I will commit. Vladimir Krasnov Style.cs.1.patch Description: Style.cs.1.patch Style.cs.2.patch Description: Style.cs.2.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel

[Mono-dev] Bug in WebControls.FontInfo

2006-02-19 Thread Vladimir Krasnov
. Test case: /System_Web_UI_WebControls/WebControl/WebControl_Font.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov FontInfo.cs.1.patch Description: FontInfo.cs.1.patch FontInfo.cs.2.patch Description: FontInfo.cs.2.patch

[Mono-dev] Bug in WebControls.DataGridPagerStyle

2006-02-19 Thread Vladimir Krasnov
Hello, Little typo bug in PrevPageText property. Test case: /System_Web_UI_WebControls/DataGridPagerStyle/DataGridPagerStyle_PrevPag eText.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov DataGridPagerStyle.cs.patch Description

[Mono-dev] Bug in System.Web.UI.WebControls.DataGrid in InitializeNumericPager

2006-02-19 Thread Vladimir Krasnov
Hello, In numeric pager, page number that is not link (current page), should be a label. Test case URL: /System_Web_UI_WebControls/DataGrid/DataGrid_AllowCustomPaging.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov DataGrid.cs.3.patch Description

[Mono-dev] Bug in System.Web.UI.WebControl.DataList in PrepareControlHierarchy

2006-02-19 Thread Vladimir Krasnov
attached a better fix to the bug from my previous post. Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov DataList.cs.7.patch Description: DataList.cs.7.patch DataList.cs.6.patch Description: DataList.cs.6.patch

[Mono-dev] Bug in System.Web.UI.WebControl.DataList in

2006-02-19 Thread Vladimir Krasnov
will commit. Vladimir Krasnov DataList.cs.6.patch Description: DataList.cs.6.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list

[Mono-dev] Bug in System.Web.UI.WebControl.DataList in PrepareControlHierarchy

2006-02-19 Thread Vladimir Krasnov
Hello, Using Style instead of TableItemStyle causes loosing of table specified styles, like align and valign. /System_Web_UI_WebControls/DataList/DataList_AlternatingItemStyle.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov DataList.cs.5.patch

[Mono-dev] Bug in System.Web.UI.WebControls.DataGrid columsautogeneration

2006-02-19 Thread Vladimir Krasnov
Sorry, I forgot the patch file -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Vladimir Krasnov Sent: Sunday, February 19, 2006 3:14 PM To: mono-devel-list@lists.ximian.com Subject: [Mono-dev] Bug in System.Web.UI.WebControls.DataGrid columsautogeneration

[Mono-dev] Bug in System.Web.UI.WebControls.DataGrid colums autogeneration

2006-02-19 Thread Vladimir Krasnov
e URL: /System_Web_UI_WebControls/WebControl/WebControl_Attributes.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list

[Mono-dev] Bug in System.Web.UI.WebControl.DataList in InitializeItem

2006-02-19 Thread Vladimir Krasnov
aList/DataList_EditItemStyle.aspx /System_Web_UI_WebControls/DataList/DataList_SelectedItemStyle.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov DataList.cs.4.patch Description: DataList.cs.4.patch ___ Mono-devel-list mailing list

[Mono-dev] Bug in System.Web.UI.WebControl.DataList in CreateControlStyle

2006-02-19 Thread Vladimir Krasnov
lease approve the attached patch If no one objects, I will commit. Vladimir Krasnov DataList.cs.3.patch Description: DataList.cs.3.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list

[Mono-dev] Bug in System.Web.UI.WebControl.DataList in DoItemInLoop

2006-02-19 Thread Vladimir Krasnov
Hello, There is a bug in DoItemInLoop while creating a separator item incorrect itemIndex given. Test case URL: /System_Web_UI_WebControls/DataListItem/DataListItem_ItemIndex.asp Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov DataList.cs.2.patch

[Mono-dev] Bug in System.Web.UI.WebControls.LinkButton

2006-02-19 Thread Vladimir Krasnov
Hello, If validation enabled, some javasript code added, but attribute language="javascript" is not needed. Test case URL: /System_Web_UI_WebControls/LinkButton/LinkButton_CausesValidation.aspx Please approve attached patch Vladimir Krasnov LinkButton.cs.patch D

[Mono-dev] Missing exceptions in System.Web.UI.WebControls.ListControl.TextBox

2006-02-19 Thread Vladimir Krasnov
/System_Web_UI_WebControls/TextBox/TextBox_Rows.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov TextBox.cs.2.patch Description: TextBox.cs.2.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com

[Mono-dev] Bug in TextBox control

2006-02-19 Thread Vladimir Krasnov
Hello, If the Text property of TextBox control is null or empty string, value attribute should not be rendered. Test case URL: /System_Web_UI/Control/Control_ClientID.aspx Please approve the attached patch If no one objects, I will commit. Vladimir Krasnov TextBox.cs.1.patch Description

[Mono-dev] Bug System.Web.UI.WebControls.ListControl.SelectedIndex

2006-02-16 Thread Vladimir Krasnov
Hello, If the value passed to SelectedIndex property is incorrect, selection should not be reset. Test case URL: /System_Web_UI_WebControls/ListControl/ListControl_SelectedIndex.aspx Please approve attached patch If no one objects, I will commit. Vladimir Krasnov ListControl.cs.2.patch

[Mono-dev] Bug System.Web.UI.WebControls.ListControl

2006-02-16 Thread Vladimir Krasnov
Hello, ListControl.DataSource should throw ArgumentException on incorrect value Test case URL: /System_Web_UI_WebControls/ListControl/ListControl_DataSource Please approve attached patch If no one objects, I will commit. Vladimir Krasnov ListControl.cs.1.patch Description: ListControl.cs.1

[Mono-dev] Bug System.Web.UI.WebControls.RadioButton and RadioButtonList

2006-02-16 Thread Vladimir Krasnov
tches that fix both bugs. If no one objects, I will commit. Vladimir Krasnov RadioButtonList.cs.patch Description: RadioButtonList.cs.patch RadioButton.cs.patch Description: RadioButton.cs.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximia

[Mono-dev] Bug in System.Web.UI.WebControls.Image

2006-02-16 Thread Vladimir Krasnov
ill commit. Vladimir Krasnov Image.cs.patch Description: Image.cs.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list

[Mono-dev] Bugs in System.Web.UI.WebControls.CheckBox and CheckBoxList

2006-02-16 Thread Vladimir Krasnov
x Another bug is in text alignment of CheckBoxList. CheckBoxList.patch also fixes it. Test case url: /System_Web_UI_WebControls/CheckBoxList/CheckBoxList_TextAlign.aspx Please approve the fixes. If no one objects, I will commit. Vladimir Krasnov CheckBox.cs.2.patch Description: CheckBox.

[Mono-dev] FW: Bug in System.Web.UI.WebControls.CheckBox

2006-02-16 Thread Vladimir Krasnov
Sorry, I forgot the patch -Original Message- From: Vladimir Krasnov Sent: Thursday, February 16, 2006 3:53 PM To: mono-devel-list@lists.ximian.com Subject: Bug in System.Web.UI.WebControls.CheckBox Hi, I've found a problem in Render function of CheckBox class. It renders an

[Mono-dev] Bug in System.Web.UI.WebControls.CheckBox

2006-02-16 Thread Vladimir Krasnov
ommit. Vladimir Krasnov ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list

  1   2   >