[Mono-dev] [patch] Fixing the «crazy inherit ance chain walking» for parameters custom attribu tes

2009-12-01 Thread Jb Evain
Hey, When using the static methods Attribute.IsDefined or Attribute.GetCustomAttributes on a ParameterInfo that is defined on a virtual method, those methods are supposed to be walking the inheritance chain to collect the attributes over the different parameter definitions. This patch adds suppor

Re: [Mono-dev] [patch] Fixing the «crazy inherit ance chain walking» for parameters custom attribu tes

2009-12-01 Thread Rodrigo Kumpera
The patch looks good, my only concern is how does it interact with UT supplied methods? Do you mind testing MS behavior with non system ParamInfo objects? On Tue, Dec 1, 2009 at 10:30 PM, Jb Evain wrote: > Hey, > > When using the static methods Attribute.IsDefined or > Attribute.GetCustomAttri

Re: [Mono-dev] [patch] Fixing the «crazy inherit ance chain walking» for parameters custom attribu tes

2009-12-02 Thread Jb Evain
Hey, On 12/2/09, Rodrigo Kumpera wrote: > The patch looks good, my only concern is how does it interact with UT > supplied methods? > > Do you mind testing MS behavior with non system ParamInfo objects? I sure don't, but I'd say let's cross one one bridge at a time. The patch doesn't break any c

Re: [Mono-dev] [patch] Fixing the «crazy inherit ance chain walking» for parameters custom attribu tes

2009-12-02 Thread Rodrigo Kumpera
On Wed, Dec 2, 2009 at 12:01 PM, Jb Evain wrote: > Hey, > > On 12/2/09, Rodrigo Kumpera wrote: > > The patch looks good, my only concern is how does it interact with UT > > supplied methods? > > > > Do you mind testing MS behavior with non system ParamInfo objects? > > I sure don't, but I'd say