[Mono-dev] [PATCH] - optimization for System.Xml.XmlNode::SelectSingleNode

2010-05-10 Thread tom hindle
Hi, While performance profiling our code, with mono's nice profiling tools :), I noticed System.Xml.XmlNode::SelectSingleNode was taking 23ms a call while the sum of the methods it was calling took 5ms. SelectSingleNode is a very simple method however it contains a (dynamic) down cast. I

Re: [Mono-dev] [PATCH] - optimization for System.Xml.XmlNode::SelectSingleNode

2010-05-10 Thread Atsushi Eno
Hi, Thanks Tom, it looks like a good catch. The interface is internal, and cast exceptions should not happen there anyways. Once the build got fixed, I'll verify the patch and apply it unless it regresses. Atsushi Eno On 2010/05/11 2:09, tom hindle wrote: Hi, While performance profiling

Re: [Mono-dev] [PATCH] - optimization for System.Xml.XmlNode::SelectSingleNode

2010-05-10 Thread Atsushi Eno
Well, it wasn't really internal, but that does not affect my statement. Atsushi Eno On 2010/05/11 2:55, Atsushi Eno wrote: Hi, Thanks Tom, it looks like a good catch. The interface is internal, and cast exceptions should not happen there anyways. Once the build got fixed, I'll verify the

Re: [Mono-dev] [PATCH] - optimization for System.Xml.XmlNode::SelectSingleNode

2010-05-10 Thread Alan McGovern
Why would a c-cast be so much slower than an 'as' cast? Surely they should be equivalent or the c-cast should be faster. Alan. On Mon, May 10, 2010 at 7:24 PM, Atsushi Eno atsushi...@veritas-vos-liberabit.com wrote: Well, it wasn't really internal, but that does not affect my statement.

Re: [Mono-dev] [PATCH] - optimization for System.Xml.XmlNode::SelectSingleNode

2010-05-10 Thread tom hindle
On Mon, 2010-05-10 at 19:28 +0100, Alan McGovern wrote: Why would a c-cast be so much slower than an 'as' cast? Surely they should be equivalent or the c-cast should be faster. sorry bad terminology... I meant syntactically c-style cast not an actual c-cast. I wasn't sure the C# name for it,

Re: [Mono-dev] [PATCH] - optimization for System.Xml.XmlNode::SelectSingleNode

2010-05-10 Thread Andrés G. Aragoneses
El 10/05/10 21:06, tom hindle escribió: On Mon, 2010-05-10 at 19:28 +0100, Alan McGovern wrote: Why would a c-cast be so much slower than an 'as' cast? Surely they should be equivalent or the c-cast should be faster. sorry bad terminology... I meant syntactically c-style cast not an

Re: [Mono-dev] [PATCH] - optimization for System.Xml.XmlNode::SelectSingleNode

2010-05-10 Thread Atsushi Eno
As I have commented earlier, there is no chance that InvalidCastException could occur, so it is an extraneous suggestion to not use isinst here. Atsushi Eno On 2010/05/11 8:54, Andrés G. Aragoneses wrote: El 10/05/10 21:06, tom hindle escribió: On Mon, 2010-05-10 at 19:28 +0100, Alan