Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-14 Thread Atsushi Eno
BTW I just revisited to run the code, and noticed that it does not work at all. So am going to revert all of your changes (under Miguel's agreement). As I originally suggested, feel free to improve your code *after* my changes so that we don't waste time for the sake of real users. Done.

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-14 Thread Gert Driesen
-Original Message- From: [EMAIL PROTECTED] [mailto:mono-devel-list- [EMAIL PROTECTED] On Behalf Of Atsushi Eno Sent: maandag 14 augustus 2006 8:24 To: Gert Driesen Cc: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] EventLog implementation BTW I just

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-13 Thread Atsushi Eno
Hello Gert, Here are my thoughts: - As I mentioned at #mono, Current code end up to have *no* implementation from the point of already-built System.dll. There should be ways to enable local file impl. and winapi impl. without rebuilding System.dll

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-13 Thread Matthijs ter Woord
Congratulations! - Original Message - From: Gert Driesen [EMAIL PROTECTED] To: 'Atsushi Eno' [EMAIL PROTECTED] Cc: mono-devel-list@lists.ximian.com Sent: Sunday, August 13, 2006 4:35 PM Subject: Re: [Mono-dev] [PATCH] EventLog implementation -Original Message- From: [EMAIL

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-13 Thread Atsushi Eno
Gert Driesen wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:mono-devel-list- [EMAIL PROTECTED] On Behalf Of Atsushi Eno Sent: zondag 13 augustus 2006 15:32 To: Gert Driesen Cc: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] EventLog implementation

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-13 Thread Gert Driesen
-Original Message- From: [EMAIL PROTECTED] [mailto:mono-devel-list- [EMAIL PROTECTED] On Behalf Of Atsushi Eno Sent: zondag 13 augustus 2006 17:15 Cc: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] EventLog implementation Gert Driesen wrote: -Original

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-13 Thread Miguel de Icaza
Hello, - You don't mention that which you are targetting exactly when you talk about registry stuff, so I'm guessing the worst case i.e. you are also trying to make changes on local file based implementation with related to get log store. Not sure what you

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-13 Thread Atsushi Eno
Hello, - You don't mention that which you are targetting exactly when you talk about registry stuff, so I'm guessing the worst case i.e. you are also trying to make changes on local file based implementation with related to get log store. Not sure what you mean with

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-12 Thread Gert Driesen
PROTECTED] [mailto:mono-devel-list- [EMAIL PROTECTED] On Behalf Of Atsushi Eno Sent: vrijdag 11 augustus 2006 5:24 To: Gert Driesen Cc: 'Kornél Pál'; mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] EventLog implementation As we talked on #mono yesterday, feel free to commit your

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-11 Thread Gert Driesen
-Original Message- From: [EMAIL PROTECTED] [mailto:mono-devel-list- [EMAIL PROTECTED] On Behalf Of Atsushi Eno Sent: vrijdag 11 augustus 2006 5:24 To: Gert Driesen Cc: 'Kornél Pál'; mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] EventLog implementation As we

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-10 Thread Atsushi Eno
Just curious, where is my local file implementation which just works? If it isn't in your patch, I'll ignore it and commit my patch so that I don't have to waste customers' time for something unimplemented. Feel free to improve your implementation after that. Atsushi Eno Gert Driesen wrote:

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-10 Thread Gert Driesen
-Original Message- From: [EMAIL PROTECTED] [mailto:mono-devel-list- [EMAIL PROTECTED] On Behalf Of Atsushi Eno Sent: donderdag 10 augustus 2006 19:53 To: Gert Driesen Cc: 'Kornél Pál'; mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] EventLog implementation Just

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-10 Thread Gert Driesen
] [mailto:mono-devel-list- [EMAIL PROTECTED] On Behalf Of Gert Driesen Sent: donderdag 10 augustus 2006 19:59 To: 'Atsushi Eno' Cc: 'Kornél Pál'; mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] EventLog implementation -Original Message- From: [EMAIL PROTECTED

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-10 Thread Kornél Pál
Yeah, I see the same; it hardly does anything. NullEventLog does nothing and you use Win32EventLog that is missing from the diff file. I see that a lot of work is in it and a lot of things are improved but the actual event logging is missing. I think you should let Atsushi Eno to commit his

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-10 Thread Atsushi Eno
PROTECTED] On Behalf Of Atsushi Eno Sent: donderdag 10 augustus 2006 19:53 To: Gert Driesen Cc: 'Kornél Pál'; mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] EventLog implementation Just curious, where is my local file implementation which just works? If it isn't in your patch

Re: [Mono-dev] [PATCH] EventLog implementation

2006-08-10 Thread Atsushi Eno
- [EMAIL PROTECTED] On Behalf Of Atsushi Eno Sent: donderdag 10 augustus 2006 19:53 To: Gert Driesen Cc: 'Kornél Pál'; mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] EventLog implementation Just curious, where is my local file implementation which just works? If it isn't in your