Hi,
This new implementation is based on memset rather than simply using a single
for loop.
Please review and approve the patch.
Kornél
str.diff
Description: Binary data
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.x
Hi,
This new implementation is based on memset rather than simply using a
single
for loop.
May I commit this patch?
Kornél
str.diff
Description: Binary data
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/
On 11/08/07 Kornél Pál wrote:
>> This new implementation is based on memset rather than simply using a
>> single
>> for loop.
>
> May I commit this patch?
No, we're doing a release.
Performance patches (especially if they add unsafe code) should come
with a benchmark and numbers, anyway.
lupus
-
You need to add tests to StringTest.cs for all new code paths.
Do you have numbers on the performance advantage of this change?
Rodrigo
On 11/8/07, Kornél Pál <[EMAIL PROTECTED]> wrote:
>
> Hi,
>
> > This new implementation is based on memset rather than simply using a
> > single
> > for loop.
>
