Patch applied
Thanks
ChangeLog:
Don't make compiler generated classes sealed by default.
Emit and close top level compiler generated classes as well.
ReferenceEquality comparer: Use RuntimeHelpers.GetHashCode that is the
default GetHashCode implementation based. (Also note that some SRE
Thank you.
Marek Safar wrote:
Patch applied
Thanks
ChangeLog:
Don't make compiler generated classes sealed by default.
Emit and close top level compiler generated classes as well.
ReferenceEquality comparer: Use RuntimeHelpers.GetHashCode that is the
default GetHashCode implementation
Hello Kornél,
Don't make compiler generated classes sealed by default.
What is benefit of not doing that?
This is also related to the same class because that was explicitly
removing the sealed modifier to enable the static modifier.
Although currently only a single compiler generated
Hi Marek,
Although currently only a single compiler generated class benefits
from both of these modifications I don't see any drawbacks and in my
opinion the changes result in a more properly designed compiler
generated class infrastructure.
I am not sure what does more properly designed
Hi Kornél,
ChangeLog:
Don't make compiler generated classes sealed by default.
What is benefit of not doing that?
Emit and close top level compiler generated classes as well.
They are already closed.
Marek
___
Mono-devel-list mailing list
Hi Marek,
Emit and close top level compiler generated classes as well.
They are already closed.
Most of the compiler generated classes are nested types and those are
closed.
On the other hand DynamicExpressionStatement.StaticDataClass in
dynamic.cs is a top level compiler generated class.
Attached the same patch with coding style fixed.
Kornél Pál wrote:
Hi Marek,
Emit and close top level compiler generated classes as well.
They are already closed.
Most of the compiler generated classes are nested types and those are
closed.
On the other hand
Hi,
ChangeLog:
Don't make compiler generated classes sealed by default.
Emit and close top level compiler generated classes as well.
ReferenceEquality comparer: Use RuntimeHelpers.GetHashCode that is the
default GetHashCode implementation based. (Also note that some SRE
classes haven no
