Re: [Mono-dev] [PATCH] Minor fixes for XmlElement & XmlTextWriter

2006-01-06 Thread Gert Driesen
>-Original Message- >From: Atsushi Eno [mailto:[EMAIL PROTECTED] >Sent: Thursday, January 5, 2006 04:53 AM >To: 'Gert Driesen' >Cc: [EMAIL PROTECTED] >Subject: Re: [Mono-dev] [PATCH] Minor fixes for XmlElement & XmlTextWriter > >Hi Gert, > >It w

Re: [Mono-dev] [PATCH] Minor fixes for XmlElement & XmlTextWriter

2006-01-05 Thread Atsushi Eno
Gert Driesen wrote: -Original Message- From: Atsushi Eno [mailto:[EMAIL PROTECTED] Sent: Thursday, January 5, 2006 04:53 AM To: 'Gert Driesen' Cc: [EMAIL PROTECTED] Subject: Re: [Mono-dev] [PATCH] Minor fixes for XmlElement & XmlTextWriter Hi Gert, It would be nice

Re: [Mono-dev] [PATCH] Minor fixes for XmlElement & XmlTextWriter

2006-01-04 Thread Atsushi Eno
Hi Gert, It would be nicer if you avoid application/octet-stream to post patches. In XmlElementTests.cs, I think those additional lines could be split to another method and be shared (since null seems equivalent as String.Empty in 2.0). As for your code in general, please conform to coding guid

[Mono-dev] [PATCH] Minor fixes for XmlElement & XmlTextWriter

2005-12-27 Thread Gert Driesen
Hi, I've attached a patch that fixes the following minor issues in XmlElement and XmlTextWriter : - Setting XmlElement.Prefix to null should not result in ArgumentNullException on 2.0 profile - XmlTextWriter.WriteNmToken should throw ArgumentException if name is null or zero-length string - XmlTe