Re: [Mono-dev] [PATCH] ShellExecuteEx

2009-07-10 Thread Gonzalo Paniagua Javier
On Fri, 2009-07-10 at 17:04 -0400, Bill Holmes wrote: > Hi, > > The attached patch fixes Mono on Windows not respecting the > WindowStyle property of the start info when calling Process.Start with > UseShellExecute set to true. Looks good. -Gonzalo _

[Mono-dev] [PATCH] ShellExecuteEx

2009-07-10 Thread Bill Holmes
Hi, The attached patch fixes Mono on Windows not respecting the WindowStyle property of the start info when calling Process.Start with UseShellExecute set to true. -bill 2009-07-10 Bill Holmes * process.c (ves_icall_System_Diagnostics_Process_ShellExecuteEx_internal) : Ap

Re: [Mono-dev] [PATCH] ShellExecuteEx ProcessId support for Windows

2007-11-05 Thread Kornél Pál
Hi, An updated version of the patch is attached. Please review this one as well. Kornél - Original Message - From: "Robert Jordan" <[EMAIL PROTECTED]> To: Sent: Monday, November 05, 2007 2:03 PM Subject: Re: [Mono-dev] [PATCH] ShellExecuteEx ProcessId support for Win

Re: [Mono-dev] [PATCH] ShellExecuteEx ProcessId support for Windows

2007-11-05 Thread Robert Jordan
gwin. What about that? this would be OK. Robert > > Kornél > > - Original Message - > From: "Robert Jordan" <[EMAIL PROTECTED]> > To: > Sent: Monday, November 05, 2007 1:03 PM > Subject: Re: [Mono-dev] [PATCH] ShellExecuteEx ProcessId

Re: [Mono-dev] [PATCH] ShellExecuteEx ProcessId support for Windows

2007-11-05 Thread Kornél Pál
: "Robert Jordan" <[EMAIL PROTECTED]> To: Sent: Monday, November 05, 2007 1:03 PM Subject: Re: [Mono-dev] [PATCH] ShellExecuteEx ProcessId support for Windows Hi Kornél, Kornél Pál wrote: > HAVE_GETPROCESSID depends on WINVER that is not set, so > HAVE_GETPROCESSID is >

Re: [Mono-dev] [PATCH] ShellExecuteEx ProcessId support for Windows

2007-11-05 Thread Robert Jordan
Hi Kornél, Kornél Pál wrote: > HAVE_GETPROCESSID depends on WINVER that is not set, so > HAVE_GETPROCESSID is > never defined on Windows. This means that GetProcessId never gets called on > Windows and process ID is allways 0. > > This patch adds run-time detection for GetProcessId on Windows. >

[Mono-dev] [PATCH] ShellExecuteEx ProcessId support for Windows

2007-11-05 Thread Kornél Pál
Hi, HAVE_GETPROCESSID depends on WINVER that is not set, so HAVE_GETPROCESSID is never defined on Windows. This means that GetProcessId never gets called on Windows and process ID is allways 0. This patch adds run-time detection for GetProcessId on Windows. Note that only Windows XP SP1 and abo

[Mono-dev] [PATCH] ShellExecuteEx ProcessId support for Windows 2000 and Windows XP RTM

2006-03-31 Thread Kornél Pál
Hi, GetProcessId is supported only by Windows XP SP1 and Windows Server 2003 or later. Unlike stated in the comment ProcessId can be obtained without GetProcessId as well. On NT this is quite easy as NtQueryInformationProcess will return it. On Win9x it needs some more hack but as we only su