Re: [Mono-dev] [PATCH] String.Split() broken behavior

Paolo Molaro wrote: > On 10/18/07 [EMAIL PROTECTED] wrote: > >> On the contrary, the code IS optimized, which is why I removed it that >> > > Well, moving the code to always transition to unmanaged is not much > of an optimization. > > Understood. Note, however, that the optimization I

Re: [Mono-dev] [PATCH] String.Split() broken behavior

On 10/18/07 [EMAIL PROTECTED] wrote: > On the contrary, the code IS optimized, which is why I removed it that Well, moving the code to always transition to unmanaged is not much of an optimization. > Fixed (I think). Please double-check my work and make sure I did it right. I fixed up a few sma

Re: [Mono-dev] [PATCH] String.Split() broken behavior

Paolo, can you have a look at the revised patch? This should fix everything that was wrong with the previous version. Paolo Molaro wrote: --- mcs/class/corlib/System/String.cs (revision 87045) +++ mcs/class/corlib/System/String.cs (working copy) @@ -216,12 +216,11 @@ if (count == 1)

Re: [Mono-dev] [PATCH] String.Split() broken behavior

Just a small comment: ... > [ComVisible (false)] > - [MonoDocumentationNote ("optimization")] Since the code is not optimized, please don't remove this. ... Please use "[MonoInternalNote ("optimization")]". Since this is not something one would like to document. It

Re: [Mono-dev] [PATCH] String.Split() broken behavior

On 10/07/07 Tyler Larson wrote: > Attached is a revised patch to the String.Split problem. This patch now > includes code cleanup to bring it in conformance with the published coding > standards as well as unit tests relevant to the changes I made. I guess this is the patch that Joel committed t

Re: [Mono-dev] [PATCH] String.Split() broken behavior

On Tue, Oct 09, 2007 at 06:17:12PM -0700, Tyler Larson wrote: > Miguel de Icaza wrote: > > Hey! > > > > > >> Attached is a revised patch to the String.Split problem. This patch now > >> includes code cleanup to bring it in conformance with the published > >> coding standards as well as unit te

Re: [Mono-dev] [PATCH] String.Split() broken behavior

Miguel de Icaza wrote: > Hey! > > >> Attached is a revised patch to the String.Split problem. This patch now >> includes code cleanup to bring it in conformance with the published >> coding standards as well as unit tests relevant to the changes I made. >> > > Thanks for the contribution!

Re: [Mono-dev] [PATCH] String.Split() broken behavior

Hey! > Attached is a revised patch to the String.Split problem. This patch now > includes code cleanup to bring it in conformance with the published > coding standards as well as unit tests relevant to the changes I made. Thanks for the contribution! > For what its worth, I would suspect that

Re: [Mono-dev] [PATCH] String.Split() broken behavior

Tyler Larson wrote: > For what its worth, I would suspect that this function is probably the > fastest basic tokenization mechanism available though the class > libraries. The reason why I found the bugs in this code to begin with is > because I always used this method to tokenize input strings.

Re: [Mono-dev] [PATCH] String.Split() broken behavior

Rodrigo Kumpera wrote: Hi Tyler, I some coments about our patch, some are just minor details like formating issues. You can read about our coding guidelines in http://www.mono-project.com/Coding_Guidelines For the options it's a good idea to c

Re: [Mono-dev] [PATCH] String.Split() broken behavior

Hi Tyler, I some coments about our patch, some are just minor details like formating issues. You can read about our coding guidelines in http://www.mono-project.com/Coding_Guidelines For the options it's a good idea to create an enum in the c side. "options & SPLIT_OPTIONS_REMOVE_EMPTY_ENTRIES",

[Mono-dev] [PATCH] String.Split() broken behavior

Hey Mono team: This is my first time contributing, so please bear with me if I do something dumb. I've provided a patch for incorrect behavior in the String.Split() function. In particular, String.Split(char[],int,StringSplitOptions) behaves incorrectly when instructed to remove empty entrie