Hi Federico,
Thanks for your work on System.Core.
However, since your last patches, the tuner (the tool to create the
2.1 assemblies for moonlight) now shows warning in System.Core:
[check] in assembly System.Core, Version=2.1.0.0, Culture=neutral,
PublicKeyToken=b77a5c561934e089
[check]
Hello,
I disagree, we should fix StringBuilder in 2.1 profile and not introduce
new hacks everywhere else.
My suggestion for cases like this is to use #ifdef for AppendFormat
in 2.1 profile and compiler will deal with overloads in each profile
automatically.
Marek
Thanks for your work on
Hey,
On 8/15/07, Marek Safar [EMAIL PROTECTED] wrote:
I disagree, we should fix StringBuilder in 2.1 profile and not introduce
new hacks everywhere else.
My suggestion for cases like this is to use #ifdef for AppendFormat
in 2.1 profile and compiler will deal with overloads in each profile
Ok, I've fixed the StringBuilder.AppendFormat for 2.1.
But please, keep an eye on the tuner output for 2.1 (`make
PROFILE=net_2_1 clean all install` in mcs).
If there's an issue, we have to fix it, either by hiding it to the
compiler like in this case, or by using a workaround.
On 8/15/07, Jb
Hey,
I have commited the patch.
Il giorno lun, 13/08/2007 alle 22.07 +0100, Marek Safar ha scritto:
Hi Federico,
attached to this email there is the updated System.Linq.Expressions
patch. I fixed the StringBuilder problem, added unique IDs to all tests,
used Assert.IsNull where
Il giorno dom, 12/08/2007 alle 13.31 -0700, Charlie Poole ha scritto:
The preferred way it's add a message or at least id to each
assertion.
Both statements have a more serious problem in that the aruments are
backwards. The expected value comes first. It makes no difference if
none of
Hi,
Il giorno dom, 12/08/2007 alle 20.09 +0100, Marek Safar ha scritto:
[snip]
* Assert.AreEqual(expr.Method.Name, op_Addition);
The preferred way it's add a message or at least id to each assertion.
Can you make an example of how an id would look like, please?
Everything else will be fixed
Hi,
* Assert.AreEqual(expr.Method.Name, op_Addition);
The preferred way it's add a message or at least id to each assertion.
Can you make an example of how an id would look like, please?
Some details can be found on mono website or check any existing nunit test.
Hi,
attached to this email there is the updated System.Linq.Expressions
patch. I fixed the StringBuilder problem, added unique IDs to all tests,
used Assert.IsNull where appropriate and fixed one more Expression
method (AndAlso). Hope this is good enough for commit.
federico
--
Federico Di
Hi Federico,
attached to this email there is the updated System.Linq.Expressions
patch. I fixed the StringBuilder problem, added unique IDs to all tests,
used Assert.IsNull where appropriate and fixed one more Expression
method (AndAlso). Hope this is good enough for commit.
The patch
Il giorno lun, 13/08/2007 alle 22.07 +0100, Marek Safar ha scritto:
Hi Federico,
attached to this email there is the updated System.Linq.Expressions
patch. I fixed the StringBuilder problem, added unique IDs to all tests,
used Assert.IsNull where appropriate and fixed one more Expression
Hello!
I commited this earlier today, but my mail is down from my laptop.
If you plan on being involved doing some more of that work, we could get
you an account, check www.mono-project.com/SVN
Thanks!
Miguel.
Federico Di Gregorio [EMAIL PROTECTED] 08/13/07 5:31 PM
Il giorno lun,
Hi,
this is the first of a series of patches vs the System.Linq.Expressions
namespace. This patch doesn't change a lot of things but at least adds
some tests (they were completely missing before). Included:
* Added Test/ directory, modified Makefile to build and execute them
* Changed a couple
Hello Federico,
this is the first of a series of patches vs the System.Linq.Expressions
namespace. This patch doesn't change a lot of things but at least adds
some tests (they were completely missing before). Included:
* Added Test/ directory, modified Makefile to build and execute them
*
Hi Guys,
* Assert.AreEqual (expr.Method, null);
It's always better to use most appropriate method. In the
cases like this should be Assert.IsNull or similar.
* Assert.AreEqual(expr.Method.Name, op_Addition);
The preferred way it's add a message or at least id to each assertion.
15 matches
Mail list logo
