[Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms

2008-08-09 Thread Gert Driesen
Hi, The attached patch provides some trivial fixes for XmlDsig transforms in System.Security, and adds/improves unit tests. Let me know if this is ok to commit. Gert Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs

Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms

2008-08-13 Thread Sebastien Pouliot
On Sat, 2008-08-09 at 11:04 +0200, Gert Driesen wrote: > Hi, > > The attached patch provides some trivial fixes for XmlDsig transforms in > System.Security, and adds/improves unit tests. > > Let me know if this is ok to commit. No. It seems there's good stuff (like updating the old syntax of uni

Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms

2008-08-13 Thread Gert Driesen
iesen Cc: [EMAIL PROTECTED] Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms On Sat, 2008-08-09 at 11:04 +0200, Gert Driesen wrote: > Hi, > > The attached patch provides some trivial fixes for XmlDsig transforms in > System.Security, and adds/im

Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms

2008-08-13 Thread Gert Driesen
> Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs > === > --- Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs > (revision 110022) > +++ Test/System.Security.Cryptography.Xml/XmlDsigXsltTran

Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms

2008-08-13 Thread Gert Driesen
TECTED] On Behalf Of Sebastien Pouliot Sent: donderdag 14 augustus 2008 2:58 To: Gert Driesen Cc: [EMAIL PROTECTED] Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms On Sat, 2008-08-09 at 11:04 +0200, Gert Driesen wrote: > Hi, > > The attached patch provides s

Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms

2008-08-14 Thread Sebastien Pouliot
AIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Sebastien > Pouliot > Sent: donderdag 14 augustus 2008 2:58 > To: Gert Driesen > Cc: [EMAIL PROTECTED] > Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig > transforms > > On Sat, 2008-08-09 at

Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms

2008-08-14 Thread Sebastien Pouliot
On Thu, 2008-08-14 at 06:35 +0200, Gert Driesen wrote: > > Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs > > === > > --- Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs > > (revision 1100

Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms

2008-08-14 Thread Gert Driesen
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Sebastien Pouliot Sent: donderdag 14 augustus 2008 14:05 To: Gert Driesen Cc: [EMAIL PROTECTED] Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms > Perhaps we sho

Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms

2008-08-14 Thread Gert Driesen
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Sebastien > Pouliot > Sent: donderdag 14 augustus 2008 14:03 > To: Gert Driesen > Cc: [EMAIL PROTECTED] > Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig

Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms

2008-08-14 Thread Andrés G. Aragoneses
Gert Driesen wrote: >> Perhaps we should include a table that clearly lists the bracing style >> we prefer: >> >>> Namespace same line >>> Types same line >>> Methodsnew line >>> Constructors new line (?) >>> Properties same line