Re: [Mono-dev] [PATCH] System.Text.Encoding.GetEncoding compatibility fixes

2007-02-01 Thread Gert Driesen
- Original Message - From: "Atsushi Eno" <[EMAIL PROTECTED]> To: "Gert Driesen" <[EMAIL PROTECTED]> Cc: Sent: Thursday, February 01, 2007 1:44 PM Subject: Re: [Mono-dev] [PATCH] System.Text.Encoding.GetEncoding compatibility fixes > Hi, > > (I

Re: [Mono-dev] [PATCH] System.Text.Encoding.GetEncoding compatibility fixes

2007-02-01 Thread Atsushi Eno
Hi, (I've already approved the patch but) I had to revert part of it since it broke the build. You can try to use non-Latin1 environment (e.g. CP932) to see how it breaks mcs tree. Atsushi Eno Gert Driesen wrote: > Hi, > > The attached patch fixes some minor differences between our and MS' > En

[Mono-dev] [PATCH] System.Text.Encoding.GetEncoding compatibility fixes

2007-01-31 Thread Gert Driesen
Hi, The attached patch fixes some minor differences between our and MS' Encoding.GetEncoding implementation. * GetEncoding (int): do not allow codepage value below zero and above 0x. * GetEncoding (string): modified NotSupportedException to ArgumentException when encoding is not supported Bo