Re: [Mono-dev] [PATCH] Uri.IsWellFormedUriString should not throw an exception.

2009-01-28 Thread Bill Holmes
Hello Miguel, Thanks for taking a closer look at this. I have attached another patch that should work. -bill On Wed, Jan 28, 2009 at 9:28 AM, Miguel De Icaza mig...@novell.com wrote: Hello, 1) MonoTests.System.UriTest3.IsWellFormedUriString_BadUriKind : System.ArgumentException was

Re: [Mono-dev] [PATCH] Uri.IsWellFormedUriString should not throw an exception.

2009-01-28 Thread Miguel de Icaza
Hello! This looks fine; Can you commit to trunk and 2-4? Hello Miguel, Thanks for taking a closer look at this. I have attached another patch that should work. -bill On Wed, Jan 28, 2009 at 9:28 AM, Miguel De Icaza mig...@novell.com wrote: Hello, 1)

Re: [Mono-dev] [PATCH] Uri.IsWellFormedUriString should not throw an exception.

2009-01-27 Thread Bill Holmes
With the changes I get a test failure. I will not be committing this. 1) MonoTests.System.UriTest3.IsWellFormedUriString_BadUriKind : System.ArgumentException was expected On Sat, Jan 24, 2009 at 9:06 PM, Miguel De Icaza mig...@novell.com wrote: Hello Bill, Any chance of redoing the code as

Re: [Mono-dev] [PATCH] Uri.IsWellFormedUriString should not throw an exception.

2009-01-24 Thread Miguel De Icaza
Hello Bill, Any chance of redoing the code as suggested by Robert? If so, it is OK to get this on the 2.4 branch. Miguel. On Jan 21, 2009, at 12:01 PM, Bill Holmes wrote: Hi, The attached patch fixes the attached test.cs. Uri.IsWellFormedUriString calls the .ctor which throws an

Re: [Mono-dev] [PATCH] Uri.IsWellFormedUriString should not throw an exception.

2009-01-22 Thread Jonathan Anderson
I had submitted a similar patch to this in bugzilla back in November that seems to have gone unnoticed. https://bugzilla.novell.com/show_bug.cgi?id=376692 Jonathan Anderson Robert Jordan wrote: Hi Bill, Bill Holmes wrote: Uri.IsWellFormedUriString calls the .ctor which throws an

Re: [Mono-dev] [PATCH] Uri.IsWellFormedUriString should not throw an exception.

2009-01-21 Thread Robert Jordan
Hi Bill, Bill Holmes wrote: Uri.IsWellFormedUriString calls the .ctor which throws an exception. The .ctor throwing the exception is expected behavior, IsWellFormedUriString throwing is not expected. + try { + Uri uri = new Uri (uriString,