Gert Driesen wrote:
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Atsushi Eno
Sent: zondag 25 december 2005 15:39
To: Gert Driesen
Cc: [EMAIL PROTECTED]
Subject: Re: [Mono-dev] [PATCH] Validation for
attributes.
Gert Driesen wrote
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf
> Of Atsushi Eno
> Sent: zondag 25 december 2005 15:39
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: Re: [Mono-dev] [PATCH] Validation for
> attribut
Gert Driesen wrote:
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Atsushi Eno
Sent: zondag 25 december 2005 4:44
To: Gert Driesen
Cc: [EMAIL PROTECTED]
Subject: RE: [Mono-dev] [PATCH] Validation for
attributes.
It indeed is "indent&
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf
> Of Atsushi Eno
> Sent: zondag 25 december 2005 4:44
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: RE: [Mono-dev] [PATCH] Validation for
> attributes.
>
&g
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf
> Of Atsushi Eno
> Sent: zondag 25 december 2005 4:45
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: RE: [Mono-dev] [PATCH] Validation for
> attributes.
>
&
> ... and here's the patch ;-)
>
> Sorry for the noise !
It looks good. Please apply exactly the same patch by the time you
commit
anything else.
Thanks,
Atsushi Eno
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.xim
> > It indeed is "indent" part matter. Anyways you don't have to touch
> > the code anymore. I fixed the bug. There is no failing NUnit tests
> > and no more regressions in standalone tests now.
>
> It also applies to "standalone" and "omit-xml-declaration" attributes (see
> the new tests I added
... and here's the patch ;-)
Sorry for the noise !
> -Original Message-
> From: Gert Driesen [mailto:[EMAIL PROTECTED]
> Sent: zaterdag 24 december 2005 19:24
> To: 'Atsushi Eno'
> Cc: '[EMAIL PROTECTED]'
> Subject: RE: [Mono
> -Original Message-
> From: Atsushi Eno [mailto:[EMAIL PROTECTED]
> Sent: zaterdag 24 december 2005 3:54
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: Re: [Mono-dev] [PATCH] Validation for
> attributes.
>
> Atsushi Eno wr
> -Original Message-
> From: Atsushi Eno [mailto:[EMAIL PROTECTED]
> Sent: zaterdag 24 december 2005 14:48
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: Re: [Mono-dev] [PATCH] Validation for
> attributes.
>
> Gert Driesen wrote:
> >
Gert Driesen wrote:
-Original Message-
From: Atsushi Eno [mailto:[EMAIL PROTECTED]
Sent: zaterdag 24 december 2005 11:16
To: Gert Driesen
Cc: [EMAIL PROTECTED]
Subject: Re: [Mono-dev] [PATCH] Validation for
attributes.
Gert Driesen wrote:
I submitted my initial patch the the
> -Original Message-
> From: Atsushi Eno [mailto:[EMAIL PROTECTED]
> Sent: zaterdag 24 december 2005 17:27
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: RE: [Mono-dev] [PATCH] Validation for
> attributes.
>
> It indeed is "indent" part ma
> -Original Message-
> From: Atsushi Eno [mailto:[EMAIL PROTECTED]
> Sent: zaterdag 24 december 2005 11:16
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: Re: [Mono-dev] [PATCH] Validation for
> attributes.
>
> Gert Driesen wrote:
> > I submit
Gert Driesen wrote:
I submitted my initial patch the the mono-dev list, and you definitely
reviewed this part.
It is incorrect. It was the first reply I precisely pointed out that
HTML output is broken here, and after my reply you committed what
you haven't posted.
Our behaviour now matches t
ilto:[EMAIL PROTECTED]
> > Sent: zaterdag 24 december 2005 14:48
> > To: Gert Driesen
> > Cc: [EMAIL PROTECTED]
> > Subject: Re: [Mono-dev] [PATCH] Validation for
> > attributes.
> >
> > Gert Driesen wrote:
> > >
> > >
> > >>
Atsushi Eno wrote:
Gert Driesen wrote:
-Original Message-
From: Atsushi Eno [mailto:[EMAIL PROTECTED] Sent: vrijdag 23
december 2005 20:31
To: Gert Driesen
Cc: [EMAIL PROTECTED]
Subject: Re: [Mono-dev] [PATCH] Validation for attributes.
Gert Driesen wrote:
Comments inline
Gert Driesen wrote:
-Original Message-
From: Atsushi Eno [mailto:[EMAIL PROTECTED]
Sent: vrijdag 23 december 2005 20:31
To: Gert Driesen
Cc: [EMAIL PROTECTED]
Subject: Re: [Mono-dev] [PATCH] Validation for
attributes.
Gert Driesen wrote:
Comments inline
-Original Message
> -Original Message-
> From: Atsushi Eno [mailto:[EMAIL PROTECTED]
> Sent: vrijdag 23 december 2005 20:31
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: Re: [Mono-dev] [PATCH] Validation for
> attributes.
>
> Gert Driesen wrote:
> > Comment
Gert Driesen wrote:
Comments inline
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Atsushi Eno
Sent: dinsdag 20 december 2005 6:26
To: Gert Driesen
Cc: [EMAIL PROTECTED]
Subject: Re: [Mono-dev] [PATCH] Validation for
attributes.
Hi,
The
> -Original Message-
> From: Atsushi Eno [mailto:[EMAIL PROTECTED]
> Sent: vrijdag 23 december 2005 18:54
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: RE: [Mono-dev] [PATCH] Validation for
> attributes.
>
> > Comments inline
> >
> &g
> Comments inline
>
> > -Original Message-
> > From: [EMAIL PROTECTED]
> > [mailto:[EMAIL PROTECTED] On Behalf
> > Of Atsushi Eno
> > Sent: dinsdag 20 december 2005 6:26
> > To: Gert Driesen
> > Cc: [EMAIL PROTECTED]
> > Subject:
Comments inline
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf
> Of Atsushi Eno
> Sent: dinsdag 20 december 2005 6:26
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: Re: [Mono-dev] [PATCH] Validation for
> attr
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf
> Of Atsushi Eno
> Sent: zaterdag 24 december 2005 3:47
> To: Gert Driesen
> Cc: mono-devel-list@lists.ximian.com
> Subject: Re: [Mono-dev] [PATCH] Validation for
> at
Gert Driesen wrote:
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Atsushi Eno
Sent: vrijdag 23 december 2005 19:29
To: Gert Driesen
Cc: mono-devel-list@lists.ximian.com
Subject: RE: [Mono-dev] [PATCH] Validation for
attributes
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf
> Of Atsushi Eno
> Sent: vrijdag 23 december 2005 19:29
> To: Gert Driesen
> Cc: mono-devel-list@lists.ximian.com
> Subject: RE: [Mono-dev] [PATCH] Valid
> > -Original Message-
> > From: Atsushi Eno [mailto:[EMAIL PROTECTED]
> > Sent: vrijdag 23 december 2005 18:54
> > To: Gert Driesen
> > Cc: [EMAIL PROTECTED]
> > Subject: RE: [Mono-dev] [PATCH] Validation for
> > attributes.
> >
>
Hi,
The attached patch implements validation for attributes, and
adds unit tests.
Thanks!
I've also added some unit tests for XsltCompileException and XslException.
Some test are marked NotWorking, due to bugs in Mono (for which I'll report
bug reports later).
Some comments:
- Y
Hi,
The attached patch implements validation for attributes, and
adds unit tests.
I've also added some unit tests for XsltCompileException and XslException.
Some test are marked NotWorking, due to bugs in Mono (for which I'll report
bug reports later).
Is it ok to commit ?
Gert
xsl.patch
De
28 matches
Mail list logo
