Re: [Mono-dev] [Patch] AssemblyName ctor (yes, again)

2005-08-25 Thread Carlos Alberto Cortez
> > This break the ABI: is_version_defined is not needed since you can check > the fields anyway. > is_persistent can go away some other way (for example by always having > public_key allocated, but it would be better to find another which > doesn't make us waste memory). No, you can't check the

Re: [Mono-dev] [Patch] AssemblyName ctor (yes, again)

2005-08-25 Thread Sebastien Pouliot
On Thu, 2005-25-08 at 15:42 +0200, Paolo Molaro wrote: > > @@ -1197,8 +1211,35 @@ > > aname->culture = g_strdup (culture); > > } > > > > - if (token && strncmp (token, "null", 4) != 0) > > + if (token && strncmp (token, "null", 4) != 0) { > > + if (strlen

Re: [Mono-dev] [Patch] AssemblyName ctor (yes, again)

2005-08-25 Thread Paolo Molaro
On 08/24/05 Carlos Alberto Cortez wrote: > The attached patches contain some changes to runtime functions to > support the new AssemblyName ctor. They also add an internal call for > this ctor. > > I added a pair of new fields to MonoAssemblyName (is_persistent and > is_version_defined) to define

[Mono-dev] [Patch] AssemblyName ctor (yes, again)

2005-08-24 Thread Carlos Alberto Cortez
Hey, The attached patches contain some changes to runtime functions to support the new AssemblyName ctor. They also add an internal call for this ctor. I added a pair of new fields to MonoAssemblyName (is_persistent and is_version_defined) to define if the public_key was parsed (should be freed)