Re: [Mono-dev] A possible implementation for AssemblyName.ReferenceMatchesDefinition

2013-08-28 Thread Daniel Lo Nigro
To reach the Entity Framework developers, I'd suggest posting to their discussion forums: http://entityframework.codeplex.com/discussions On Wed, Aug 28, 2013 at 9:30 PM, mlgo wrote: > > > Thanks, I had seen that link already. How would I find Entity Framework > developers? > > > > It

Re: [Mono-dev] A possible implementation for AssemblyName.ReferenceMatchesDefinition

2013-08-28 Thread mlgo
Thanks, I had seen that link already. How would I find Entity Framework developers? It looks like EF is using it to while iterating through the cache to select the assembly which matches the assemblyname being passed in. The function it is used in is DefaultAssemblyResolver.Resol

Re: [Mono-dev] A possible implementation for AssemblyName.ReferenceMatchesDefinition

2013-08-28 Thread Marek Safar
Hi, This API is broken by design and it's not clear what it should really do. It'd probably be better to check with EF devs whether they really intended to use it and for what purposes. Even for naive implementation please write unit test and check whether it passes on .net http://stackoverflow.c

Re: [Mono-dev] A possible implementation for AssemblyName.ReferenceMatchesDefinition

2013-08-27 Thread mlgo
That's quite a difference. It must be there for compatibility now if that is the case because it is nothing but a string compare and does not really justify a function with that name. Also it would be a breaking problem if you were expecting the behavior described in the 2.0 docs.. __

Re: [Mono-dev] A possible implementation for AssemblyName.ReferenceMatchesDefinition

2013-08-27 Thread Daniel Lo Nigro
It looks like the behaviour may have changed between .NET versions... The MSDN page for .NET Framework 3.5 onwards (including 4.5) states: Returns a value indicating whether two assembly names are the same. The > comparison is based on the simple assembly names. > return value - true if the simple

Re: [Mono-dev] A possible implementation for AssemblyName.ReferenceMatchesDefinition

2013-08-27 Thread mlgo
Right. Thanks. I hadn't thought about that. I keep suspecting that the documentation is not right though. That in fact what needs to be done is determine if the names actually refer to the same dll. Hopefully someone can reply to this who knows more about the internals of this. Otherwise I need

Re: [Mono-dev] A possible implementation for AssemblyName.ReferenceMatchesDefinition

2013-08-27 Thread Daniel Lo Nigro
You may want to ignore culture and case in your comparison: return reference.Name.Equals(definition.Name, StringComparison.InvariantCultureIgnoreCase) On Wed, Aug 28, 2013 at 1:29 AM, mlgo wrote: > According to > > http://msdn.microsoft.com/en-us/library/system.reflection.assemblyname.referen

Re: [Mono-dev] A possible implementation for AssemblyName.ReferenceMatchesDefinition

2013-08-27 Thread Stifu
If I'm not mistaken, the last 2 tests are redundant. You're basically doing the same test twice. So I guess this could be simplified to something like: public static bool ReferenceMatchesDefinition (AssemblyName reference, AssemblyName definition) {

[Mono-dev] A possible implementation for AssemblyName.ReferenceMatchesDefinition

2013-08-27 Thread mlgo
According to http://msdn.microsoft.com/en-us/library/system.reflection.assemblyname.referencematchesdefinition.aspx The following is what is expected to be returned from ReferenceMatchesDefinition. Returns a value indicating whether two assembly names are the same. The comparison is based on the