Re: [Mono-dev] GroupBy Bug (Bug 601101)

2010-04-30 Thread Adar Wesley
Check out the MSDN documentation of System.Collections.Specialized.OrderedDictionary, you may want to use that. --- Adar Wesley On Fri, Apr 30, 2010 at 12:18 AM, Richard Kiene wrote: > I have filed Bug 601101 https://bugzilla.novell.com/show_bug.cgi?id=601101 for > this issue. In addition; I ha

Re: [Mono-dev] GroupBy Bug (Bug 601101)

2010-04-29 Thread Richard Kiene
Sorry about the white space. Like I said, it basically fixes the issue for our project, but I doubt it is the ideal way to fix the issue. Since the Dictionary will need to be removed from the function perhaps a re-write is in order. I've again attached the patch, and I release it under the MIT/X

Re: [Mono-dev] GroupBy Bug (Bug 601101)

2010-04-29 Thread Alan McGovern
Hey More than 50% of your patch is whitespace noise which makes it hard to see what exactly it is you're fixing. Could you submit a patch without all the extra whitespace changes? Secondly, I'd personally view any code which relies on the element ordering in a dictionary as being a bug an

[Mono-dev] GroupBy Bug (Bug 601101)

2010-04-29 Thread Richard Kiene
I have filed Bug 601101 https://bugzilla.novell.com/show_bug.cgi?id=601101 for this issue. In addition; I have attached a patch which resolves the issue. That said, I'm not really sure this patch is the most desirable way to fix the bug. If you would like to use the patch I release it under the