Re: [Mono-dev] If you accept pull requests on Mono's github

2015-01-14 Thread Edward Ned Harvey (mono)
From: mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list- boun...@lists.ximian.com] On Behalf Of Edward Ned Harvey (mono) Pull Request: https://github.com/mono/mono/pull/1490 Keepalive... No responses for a week... ___

Re: [Mono-dev] If you accept pull requests on Mono's github

2015-01-05 Thread Eberhard Beilharz
Andres G. Aragoneses kno...@gmail.com wrote on 2015-01-03 at 21:51 +0100: On 03/01/15 21:42, Edward Ned Harvey (mono) wrote: I don't know if you want tests that are known to fail. If it fails, you can decorate it with the attribute [Category(NotWorking)], but AFAICT contributing a failing

Re: [Mono-dev] If you accept pull requests on Mono's github

2015-01-04 Thread Edward Ned Harvey (mono)
From: mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list- boun...@lists.ximian.com] On Behalf Of Andres G. Aragoneses If it fails, you can decorate it with the attribute [Category(NotWorking)], but AFAICT contributing a failing test doesn't increase the chances of finding a

[Mono-dev] If you accept pull requests on Mono's github

2015-01-03 Thread Miguel de Icaza
Hey guys, If you are accepting pull requests on Mono's github, please request that pull requests that were iterated multiple-times have their multiple commits squashed into one. Otherwise Mono ends up merging code that does things like: - Commit 1: Implement a feature + reformatted entire

Re: [Mono-dev] If you accept pull requests on Mono's github

2015-01-03 Thread Edward Ned Harvey (mono)
From: mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list- boun...@lists.ximian.com] On Behalf Of Miguel de Icaza If you are accepting pull requests on Mono's github, please request that pull requests that were iterated multiple-times have their multiple commits squashed into

Re: [Mono-dev] If you accept pull requests on Mono's github

2015-01-03 Thread Andres G. Aragoneses
On 03/01/15 21:42, Edward Ned Harvey (mono) wrote: I don't know if you want tests that are known to fail. If it fails, you can decorate it with the attribute [Category(NotWorking)], but AFAICT contributing a failing test doesn't increase the chances of finding a contributor that has the time