On Mon, 2006-06-05 at 17:01 +0200, Juraj Skripsky wrote:
> Hi,
>
> Did anyone had a chance to look at the patches? Is there anything I can
> do the speed up the process?
> http://lists.ximian.com/pipermail/mono-devel-list/2006-May/018667.html
Somehow I didn't get that email.
In the patch for Htt
Hi,
Did anyone had a chance to look at the patches? Is there anything I can
do the speed up the process?
http://lists.ximian.com/pipermail/mono-devel-list/2006-May/018667.html
And there's a bug I've filed almost 4 months ago, including an "naive"
patch. Did anyone look at it?
http://bugzilla.ximi
Hi,
These are the separate and slightly refactored patches for
HttpUtility.cs, HttpRequest.cs and HttpRequestTest.cs:
2006-05-28 Juraj Skripsky <[EMAIL PROTECTED]>
* HttpUtility.cs (ParseQueryString): move core of
ParseQueryString into internal method to make it available to
Hi,
You're right. A small benchmark confirms that the original "scanning"
core is always faster than the "split" one. Only empty query strings
make the new one go faster. So I'll keep the original in HttpUtility and
just prepend "if (query.Length == 0) return;".
- Juraj
On Fri, 2006-05-26 at 15
On Fri, 2006-05-26 at 15:26 +0200, Juraj Skripsky wrote:
> I will do some more testing with a few websites of our own. If
> everything works fine, I would like to commit the changes.
I would prefer to get separated patches with a ChangeLog. Also the
changes that involve UriBuilder might break Path
you should wait for an
approval.
Kornél
- Original Message -
From: "Juraj Skripsky" <[EMAIL PROTECTED]>
To: "Kornél Pál" <[EMAIL PROTECTED]>
Cc: "Miguel de Icaza" <[EMAIL PROTECTED]>;
Sent: Friday, May 26, 2006 3:26 PM
Subject: Re: [Mon
that implements these modifications. (Please review
> however as I didn't test it much.)
>
> Kornél
>
> - Original Message -
> From: "Juraj Skripsky" <[EMAIL PROTECTED]>
> To: "Kornél Pál" <[EMAIL PROTECTED]>
> Cc: "Miguel de I
AIL PROTECTED]>;
Sent: Friday, May 26, 2006 2:31 AM
Subject: Re: [Mono-dev] Patch for HttpRequest.cs
Hi,
Sorry for taking so long to get back to you. A new patch is attached
which does the following:
- get_RootVirtualDir: small cleanup and optimization. get_RootVirtualDir
and get_BaseV
entEncoding to decode the byte array and for
> HttpUtility.UrlDecode
>
> Kornél
>
> - Original Message -
> From: "Juraj Skripsky" <[EMAIL PROTECTED]>
> To: "Miguel de Icaza" <[EMAIL PROTECTED]>
> Cc:
> Sent: Monday, May 08, 2006
t;[EMAIL PROTECTED]>;
Sent: Monday, May 08, 2006 5:16 PM
Subject: Re: [Mono-dev] Patch for HttpRequest.cs
Hi,
The difference you missed (actually I missed this as well as I don't use
this constructor:) is that public HttpRequest(string filename, string url,
string queryS
L PROTECTED]>
Cc: "Miguel de Icaza" <[EMAIL PROTECTED]>;
Sent: Monday, May 08, 2006 1:41 PM
Subject: Re: [Mono-dev] Patch for HttpRequest.cs
Hello,
I was talking about the encoding used during the URL decoding only. My
patch fixes that. Running the attached test program dem
ecode
>
> Kornél
>
> - Original Message -
> From: "Juraj Skripsky" <[EMAIL PROTECTED]>
> To: "Miguel de Icaza" <[EMAIL PROTECTED]>
> Cc:
> Sent: Monday, May 08, 2006 12:22 PM
> Subject: Re: [Mono-dev] Patch for HttpRequest.cs
>
&g
t;Miguel de Icaza" <[EMAIL PROTECTED]>
Cc:
Sent: Monday, May 08, 2006 12:22 PM
Subject: Re: [Mono-dev] Patch for HttpRequest.cs
Hello,
After running more tests, I've found out that on MS.NET the decoding in
HttpRequest.QueryString does _not_ depend on
HttpRequest.ContentEncoding. I
Hello,
After running more tests, I've found out that on MS.NET the decoding in
HttpRequest.QueryString does _not_ depend on
HttpRequest.ContentEncoding. In fact, MS seems to be always using Latin1
here. All other standard encodings fail.
A revised patch is attached, including a NUnit test case. I
On Tue, 2006-05-02 at 17:11 +0200, Juraj Skripsky wrote:
> Hello,
>
> The attached patch makes sure that the get-parameters in QueryString are
> url-decoded using the proper encoding (when creating the
> NameValueCollection).
>
> May I commit?
Please, do.
Thanks.
-Gonzalo
Hello Juraj,
> The attached patch makes sure that the get-parameters in QueryString are
> url-decoded using the proper encoding (when creating the
> NameValueCollection).
>
> May I commit?
Could you provide NUnit tests for this case?
Miguel
___
Mono-d
Hello,
The attached patch makes sure that the get-parameters in QueryString are
url-decoded using the proper encoding (when creating the
NameValueCollection).
May I commit?
- Juraj
Index: ChangeLog
===
--- ChangeLog (revision 60170)
17 matches
Mail list logo
