[Mono-dev] file handle leak in cpu_load

2014-12-02 Thread Markus Beth
Hi all, last week we used the profiler of a mono 3.10.0 installation on Linux x86_64 and we found it leaks file handles (for /proc/loadavg). I located the problem in the function cpu_load in mono/utils/mono-counters.c. If a premature return is taken, the FILE pointer f is not fclose()-ed. I

Re: [Mono-dev] file handle leak in cpu_load

2014-12-02 Thread Alexander Köplinger
Can you send a pull request on GitHub? Date: Tue, 2 Dec 2014 12:01:29 +0100 From: markus.b...@zkrd.de To: mono-devel-list@lists.ximian.com Subject: [Mono-dev] file handle leak in cpu_load Hi all, last week we used the profiler of a mono 3.10.0 installation on Linux x86_64 and we

Re: [Mono-dev] file handle leak in cpu_load

2014-12-02 Thread Markus Beth
Subject: [Mono-dev] file handle leak in cpu_load Hi all, last week we used the profiler of a mono 3.10.0 installation on Linux x86_64 and we found it leaks file handles (for /proc/loadavg). I located the problem in the function cpu_load in mono/utils/mono-counters.c

Re: [Mono-dev] file handle leak in cpu_load

2014-12-02 Thread Alexander Köplinger
I opened a PR on your behalf: https://github.com/mono/mono/pull/1434 -- Alex Date: Tue, 2 Dec 2014 13:02:54 +0100 From: markus.b...@zkrd.de To: alex.koeplin...@outlook.com CC: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] file handle leak in cpu_load Not easily, as I do