Hello Palaniappan, Thank you for your great work for merging the latest changes into our repository.
The patch contains some problems : * Novell.Directory.Ldap/Novell.Directory.Ldap/LdapBindRequest.cs: one of the our latest changes is deleted. Please make sure that in the patch you commit this code is not removed. * Novell.Directory.Ldap/Novell.Directory.Ldap.Utilclass/Utilclass.Resource sHandler.cs: the usage of 'ExceptionMessages' and 'ResultCodeMessages' resources looks suspicious to me - it seems that this code will not work, since you refer to the resources with no namespace prefix (for 'ResultCodeMessages') and with some strange prefix 'Ldap2._1._2' (for 'ExceptionMessages'). Can you please make sure this code is working well? All the rest of the patch is great. Thanks, -- Boris Kirzner Mono R&D team, Mainsoft Corporation. Blogging at http://boriskirzner.blogspot.com/ > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf > Of Nachiappan Palaniappan > Sent: Friday, September 23, 2005 08:06 > To: mono-devel-list@lists.ximian.com > Subject: [Mono-dev] Merging Novell.Directory.Ldap with that > of Novell Forge'supdated one > > Hello, > > I've merged the updated Novell.Directory.Ldap of Novell's > Forge site and that in mono. > > > The folder is made in synch with the Novell Forge's C# LDAP > SDK(v-2.1.4) with the following updates as specified in the > ChangeLog : > > - Changes in Connection.cs regarding appropriate handling > in method ServerCertificateValidation. > - Added support for error code 113 SSL_HANDSHAKE_FAILED. > - Added two files ResultCodeMessages.txt and > ExceptionMessages.txt in > Novell.Directory.Ldap.Utilclass > - Added support for subordinate subtree scope. > - Removed hard coded dependency on Mono Security > - Fix for a race condition in Connection.cs > - Updated with support for Interactiveness of SSL Handshake, > Ldap Events, Edir Events, Intermediate Response > - Connection.cs class is modified by synchronizing the stream > threads so as to avoid > the memory consumption and handle consumption. > - Changed version from 2.1.1 to 2.1.4 in Connection.cs. > - Updated ChangeLog so that latest changes are on the top. > > > I am not very sure of the formalities to commit. Shall I > commit these changes? > > > Enclosed : 'merge.diff' patch. > > > Thanks, > Palaniappan. > _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list