Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-14 Thread Markus Wanner
Hi, Alex Sandro Queiroz e Silva wrote: The lua.h file defines LUA_RELEASE. That's the one I've been using before, which does not make much sense, because it can only serve as a build time check. It's not a runtime check like the global lua variable _VERSION. (And no, there is no _RELEASE

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-14 Thread Markus Wanner
Hi, Zack Weinberg wrote: well, you could always do the moral equivalent in C: lua_getglobal(L, _VERSION); std::string luaversion(lua_tostring(L, -1)); // copies lua_pop(L, 1); Hm.. I've tried that and stumbled over two problems. One is, that mt_version.cc doesn't have access to a

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-14 Thread Jack Lloyd
On Tue, Oct 14, 2008 at 06:07:54AM +0200, Richard Levitte wrote: In message [EMAIL PROTECTED] on Mon, 13 Oct 2008 21:16:59 -0600, Derek Scherger [EMAIL PROTECTED] said: derek On Mon, Oct 13, 2008 at 8:45 PM, Jack Lloyd [EMAIL PROTECTED] wrote: derek derek Attached is a patch for getting

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-14 Thread Alex Sandro Queiroz e Silva
Hallo, Markus Wanner wrote: Hi, Zack Weinberg wrote: well, you could always do the moral equivalent in C: lua_getglobal(L, _VERSION); std::string luaversion(lua_tostring(L, -1)); // copies lua_pop(L, 1); Hm.. I've tried that and stumbled over two problems. One is, that

[Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-13 Thread Richard Levitte
Hello, I've been watching the development of the net.venge.monotone.stripped branch for a bit, and I'm starting to notice some dependencies that I find concerning. Just a moment ago, I saw a change that made the montone code depend on the version of SQLITE as described by a C macro. That's fine

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-13 Thread Richard Levitte
In the same vein, the code to display the versions of SQLite, Botan and so on might be misleading in a shared library environment. Maybe it should display both the versions it was compiled against and the versions it's running against (if that's possible to find out, which isn't always a given).

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-13 Thread Markus Wanner
Hi, Richard Levitte wrote: Just a moment ago, I saw a change that made the montone code depend on the version of SQLITE as described by a C macro. That's fine and dandy provided you link monotone with the static library, but what happens if it's linked with the shared library and then moved

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-13 Thread Markus Wanner
Hi, Richard Levitte wrote: In the same vein, the code to display the versions of SQLite, Botan and so on might be misleading in a shared library environment. Maybe it should display both the versions it was compiled against and the versions it's running against (if that's possible to find

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-13 Thread Markus Wanner
Hi, Markus Wanner wrote: Richard Levitte wrote: Just a moment ago, I saw a change that made the montone code depend on the version of SQLITE as described by a C macro. That's fine and dandy provided you link monotone with the static library, but what happens if it's linked with the shared

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-13 Thread Jack Lloyd
On Mon, Oct 13, 2008 at 11:52:53PM +0200, Markus Wanner wrote: Hi, Richard Levitte wrote: In the same vein, the code to display the versions of SQLite, Botan and so on might be misleading in a shared library environment. Maybe it should display both the versions it was compiled against

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-13 Thread Derek Scherger
On Mon, Oct 13, 2008 at 8:45 PM, Jack Lloyd [EMAIL PROTECTED] wrote: Attached is a patch for getting the PCRE runtime version as well. Committed in ad7d563d114ba37fe5232fa429fecfc1681c3326, thanks again. Would you like to have commit access Jack? I'm not in a position to grant that to you

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-13 Thread Richard Levitte
In message [EMAIL PROTECTED] on Mon, 13 Oct 2008 21:16:59 -0600, Derek Scherger [EMAIL PROTECTED] said: derek On Mon, Oct 13, 2008 at 8:45 PM, Jack Lloyd [EMAIL PROTECTED] wrote: derek derek Attached is a patch for getting the PCRE runtime version as well. derek derek derek Committed in

Re: [Monotone-devel] Concerns about the net.venge.monotone.stripped branch

2008-10-13 Thread Zack Weinberg
On Mon, Oct 13, 2008 at 7:45 PM, Jack Lloyd [EMAIL PROTECTED] wrote: I could not figure out how to get the runtime Lua version (aside from executing a line of Lua that ruturns the value of the Lua _VERSION variable) well, you could always do the moral equivalent in C: lua_getglobal(L,