[Monotone-devel] Re: Bug in monotone lca

2005-05-20 Thread Wim Oudshoorn
Nathaniel Smith <[EMAIL PROTECTED]> writes: > On Thu, May 19, 2005 at 07:29:14PM +0200, Wim Oudshoorn wrote: >> Timothy Brownawell <[EMAIL PROTECTED]> writes: >> > But A *is* the least common ancestor (M->K->B->A; N->L->D->A). That >> > it's also an ancestor of a more distant common ancestor doesn

[Monotone-devel] Re: Bug in monotone lca

2005-05-20 Thread Wim Oudshoorn
Nathaniel Smith <[EMAIL PROTECTED]> writes: > On Fri, May 20, 2005 at 09:48:06AM +0200, Wim Oudshoorn wrote: >> Yes indeed. But a looked at the code a little and although >> the lca code I more or less undestand, I can't figure >> out what lcad is doing. >> >> Is there some precise specificati

[Monotone-devel] Re: Bug in monotone lca

2005-05-20 Thread Wim Oudshoorn
Nathaniel Smith <[EMAIL PROTECTED]> writes: > On Fri, May 20, 2005 at 03:37:38PM +0200, Wim Oudshoorn wrote: >> However in that case lcad has a bug :-) > > Err, yep, sounds like it. Sigh. > >> I have database with this example (artifically constructed). > > I guess I should ask if you could turn

[Monotone-devel] Re: Bug in monotone lca

2005-05-20 Thread Wim Oudshoorn
Florian Weimer <[EMAIL PROTECTED]> writes: > * Wim Oudshoorn: > >> However in that case lcad has a bug :-) >> >> Consider the following graph: >> >> A >> / \ >> B C >> | /| >> | / E >> D |\ >>

Re: [Monotone-devel] Re: Bug in monotone lca

2005-05-20 Thread Nathaniel Smith
On Fri, May 20, 2005 at 09:48:06AM +0200, Wim Oudshoorn wrote: > Nathaniel Smith <[EMAIL PROTECTED]> writes: > > It doesn't make much of a difference for anything > > that monotone uses its LCA algorithm for, though; in fact, "nearest > > common ancestor" is probably better. (We just use LCA when

Re: [Monotone-devel] Re: Bug in monotone lca

2005-05-20 Thread Nathaniel Smith
On Fri, May 20, 2005 at 03:37:38PM +0200, Wim Oudshoorn wrote: > However in that case lcad has a bug :-) Err, yep, sounds like it. Sigh. > I have database with this example (artifically constructed). I guess I should ask if you could turn it into an automated test case? Though part of me would

Re: [Monotone-devel] Re: Bug in monotone lca

2005-05-20 Thread Florian Weimer
* Wim Oudshoorn: > However in that case lcad has a bug :-) > > Consider the following graph: > > A > / \ > B C > | /| > | / E > D |\ > | F \ > | | G >

Re: [Monotone-devel] Re: Bug in monotone lca

2005-05-20 Thread Nathaniel Smith
On Fri, May 20, 2005 at 09:19:19PM +0200, Florian Weimer wrote: > * Wim Oudshoorn: > > > However in that case lcad has a bug :-) > > > > Consider the following graph: > > > > A > > / \ > > B C > > | /| > > | / E

Re: [Monotone-devel] Re: Bug in monotone lca

2005-05-20 Thread Nathaniel Smith
On Fri, May 20, 2005 at 09:29:22PM +0200, Wim Oudshoorn wrote: > Nathaniel Smith <[EMAIL PROTECTED]> writes: > > > On Fri, May 20, 2005 at 03:37:38PM +0200, Wim Oudshoorn wrote: > >> However in that case lcad has a bug :-) > > > > Err, yep, sounds like it. Sigh. > > > >> I have database with this