Re: deprecating (part of) lazy_build

2010-10-01 Thread Randal L. Schwartz
Hans == Hans Dieter Pearcey h...@pobox.com writes: Hans We don't like the fact that lazy_build autogenerates public Hans clear_$attr and has_$attr methods for you. I'm not part of we then. I've used lazy_build everywhere, and I'm perfectly happy that it generates public methods. Just a

deprecating (part of) lazy_build

2010-09-30 Thread Hans Dieter Pearcey
We don't like the fact that lazy_build autogenerates public clear_$attr and has_$attr methods for you. OK, I can get behind that; those often don't belong as part of the public API, and yes, people will consider them public if they don't have a leading underscore, even if they aren't documented.

Re: deprecating (part of) lazy_build

2010-09-30 Thread Karen Etheridge
On Thu, Sep 30, 2010 at 02:35:13PM -0400, Hans Dieter Pearcey wrote: We don't like the fact that lazy_build autogenerates public clear_$attr and has_$attr methods for you 1) reuse 'builder', i.e. 'builder = 1' is special cased to be the same as 'builder = _build_$attr' Someone said what

Re: deprecating (part of) lazy_build

2010-09-30 Thread Sir Robert Burbridge
On 09/30/2010 02:35 PM, Hans Dieter Pearcey wrote: We don't like the fact that lazy_build autogenerates public clear_$attr and has_$attr methods for you. OK, I can get behind that; those often don't belong as part of the public API, and yes, people will consider them public if they don't have a

Re: deprecating (part of) lazy_build

2010-09-30 Thread Jiří Pavlovský
On 30.9.2010 22:34, Sir Robert Burbridge wrote: On 09/30/2010 02:35 PM, Hans Dieter Pearcey wrote: Anyway, we were kicking around ideas for how to get rid of these clearers and predicates in #moose-dev. I suggested 3 things: 1) reuse 'builder', i.e. 'builder = 1' is special cased to be the

Re: deprecating (part of) lazy_build

2010-09-30 Thread Evan Carroll
1) reuse 'builder', i.e. 'builder = 1' is special cased to be the same as 'builder = _build_$attr' Someone said what about subs named '1'? but I think we're probably all OK with ignoring anyone crazy enough to do that. I made this suggestion, *years* ago (even providing a patch for it iirc).

Re: deprecating (part of) lazy_build

2010-09-30 Thread Tom Lanyon
On 01/10/2010, at 7:17 AM, Chris Prather wrote: I am probably an odd man out in that I often want a public clearer and predicate method, or at least I don't mind that one is created for me. I happily however will embrace option three if the Moose::Deprecated::LazyBuildPublicMethods is a Trait