Re: [Moses-support] Weird code in Hypothesis::RecombineCompare()

2015-06-25 Thread Jeroen Vermeulen
On 25/06/15 15:55, Barry Haddow wrote: From memory, I think you are correct. For recombination we only care if the FF states are equal or not equal, the actual order does not matter. The hypotheses are added to an (ordered) set when they get created, where the orderer uses the

Re: [Moses-support] Fwd: A small typo in Moses manual

2015-06-25 Thread Rico Sennrich
Hi Guchun. thanks - fixed. best wishes, Rico On 25.06.2015 16:05, Guchun Zhang wrote: Hi there, In Section 5.13.7 NPLM on Page 267, the option --words_file passed to prepareNeuralLM expects an existing file containing the words to be added in the vocabulary. Considering the line right

[Moses-support] MT Marathon Registration Open, the cheapest student dorms *only this week*

2015-06-25 Thread Ondrej Bojar
Dear all, We have just opened the registration for MT Marathon 2015 in Prague, September 7-12. Participation is free of charge, 100 places available. September is still high season in Prague, so remember to search for accommodation early. We offer a limited number of rooms in two types of

[Moses-support] Weird code in Hypothesis::RecombineCompare()

2015-06-25 Thread Jeroen Vermeulen
Looking at replacing WordsBitmap's implementation with std::vectorbool (less code, less memory) I came across this function: « /** check, if two hypothesis can be recombined. this is actually a sorting function that allows us to keep an ordered list of hypotheses. This makes recombination

Re: [Moses-support] Weird code in Hypothesis::RecombineCompare()

2015-06-25 Thread Marcin Junczys-Dowmunt
I'm pretty sure that's the major bug we missed until now ;) W dniu 2015-06-25 10:09, Jeroen Vermeulen napisał(a): Looking at replacing WordsBitmap's implementation with std::vectorbool (less code, less memory) I came across this function: « /** check, if two hypothesis can be

Re: [Moses-support] Weird code in Hypothesis::RecombineCompare()

2015-06-25 Thread Jeroen Vermeulen
On 25/06/15 15:41, Hieu Hoang wrote: i don't think m_ffStates[i] can be null and compare.m_ffStates[i] can ever be NOT null. it should be an assert of UTIL_THROW_IF(...), rather than an if statement That's a little beyond my ken though... I'm nervous enough about touching code here that

Re: [Moses-support] Weird code in Hypothesis::RecombineCompare()

2015-06-25 Thread Hieu Hoang
i don't think m_ffStates[i] can be null and compare.m_ffStates[i] can ever be NOT null. it should be an assert of UTIL_THROW_IF(...), rather than an if statement On 25/06/2015 12:09, Jeroen Vermeulen wrote: Looking at replacing WordsBitmap's implementation with std::vectorbool (less code,