I have just checked in a little hack that disables the window.open call
during onLoad and onUnload events, top-level scripts, and timeouts. This
should block 99% of pop-up or pop-under ads out there on the Web while
still allowing a page to open a window in response to a mouse click.
It'll be
Mitchell Stoltz wrote:
> Please bear in mind that this is experimental, and it has some flaws:
> If you hit the Stop button while a page is loading, then no calls to
> window.open on that page will work.
Any plans to fix that?
> Please give this a try
OK, will do.
> and post feedback about
Ben Bucksch wrote:
> Mitchell Stoltz wrote:
>
>> Please bear in mind that this is experimental, and it has some flaws:
>> If you hit the Stop button while a page is loading, then no calls to
>> window.open on that page will work.
>
>
> Any plans to fix that?
Yes. I'm also going to general
> page. Please give this a try, and post feedback about how this feature
> could be improved.
Excellent! It works just fine so far, bypassing the need to have a
whitelist. I haven't yet seen a popup that I didn't want, nor have I
not receieved a popup that I did want.
It's interesting b
>> An UI (pref checkbox) would be an improvement :-). (But I guess, it
>> should first be non-experimental.)
>
> That's on my list too.
There's a bug on an entire prefs panel for this stuff. It would probably
be better just to put the pref name in the bug, and wait a bit :-)
Gerv
Jason Bassford wrote:
>I know you said that this patch may *sometimes* <1% give an
> unwanted popup. Is there any chance that it could also sometimes
> prevent a popup that you do want?
Of course. This isn't perfect. Like I said, if you hit Stop during a
load, the blocker bit may not be
Mitchell Stoltz wrote:
> I have just checked in a little hack that disables the window.open call
> during onLoad and onUnload events, top-level scripts, and timeouts. This
> should block 99% of pop-up or pop-under ads out there on the Web while
> still allowing a page to open a window in respo
Mitchell Stoltz wrote:
> Besides, maybe there's something that gets popped up on load or unload
> that you do want to see. I doubt it. I'll build in the ability to
> create an exception list for those cases should one arise.
FWIW, IIRC, there are some poorly written sites which desperately wan
Giuseppe Verde wrote:
> Also, are there any plans to add something along the lines of "NoAction"
> (pretend that the function call worked so that the script thinks all
> is OK and doesn't get aborted, as happens with NoAccess)?
>
Yes, I plan to add that. Although if we make window.open be
Mitchell Stoltz wrote:
> Giuseppe Verde wrote:
>> Also, are there any plans to add something along the lines of "NoAction"
>> (pretend that the function call worked so that the script thinks all
>> is OK and doesn't get aborted, as happens with NoAccess)?
> Yes, I plan to add that. Although i
Mitchell Stoltz <[EMAIL PROTECTED]> wrote:
> you hit the Stop button while a page is loading, then no calls to
> window.open on that page will work. If this happens, just reload the
> page. Please give this a try, and post feedback about how this feature
> could be improved.
Can you also start
[EMAIL PROTECTED] wrote:
> Can you also start a timer to clear this condition? Or maybe clear
> it when the stop button is pressed?
>
> -Mike
>
Not currently, but those are good ideas, so I think I'll use them.
-Mitch
12 matches
Mail list logo
