Re: [MP3 ENCODER] Bug of long block pre-echo control

2000-10-04 Thread Robert Hegemann
Mark Powell schrieb am Mit, 04 Okt 2000: > On Wed, 4 Oct 2000, Naoki Shibata wrote: > > > I found a bug in the long block pre-echo control code. > > This code should be fixed like this. > > > > if (gfc->blocktype_old[gfp->mode == MPG_MD_JOINT_STEREO ? 0 : chn] == SHORT_TYPE ) > > Naoki, >

Re: [MP3 ENCODER] Bug of long block pre-echo control

2000-10-04 Thread Mark Powell
On Wed, 4 Oct 2000, Naoki Shibata wrote: > I found a bug in the long block pre-echo control code. > This code should be fixed like this. > > if (gfc->blocktype_old[gfp->mode == MPG_MD_JOINT_STEREO ? 0 : chn] == SHORT_TYPE ) Naoki, Did this affect quality? I just folded this change back in

[MP3 ENCODER] Bug of long block pre-echo control

2000-10-04 Thread Naoki Shibata
Hi, I found a bug in the long block pre-echo control code. if (gfc->blocktype_old[chn] == SHORT_TYPE ) thr[b] = ecb; /* Min(ecb, rpelev*gfc->nb_1[chn][b]); */ else thr[b] = Min(ecb, Min(rpelev*gfc->nb_1[chn][b],rpelev2*gfc->nb_2[chn][b]) ); In the loop of chn, chn goes up to 3, but t