I pushed Jianpu code changes to github master and it seemed to be successful
(see below).
But the changes did not show up at MuseScore github on web browser.
When I clicked "New pull request" and tried to compare with master branch, it
said they were identical.
Did I do something wrong or am I mi
Update:
The problem was with empty JianpuBeam bbox.
JianpuBeam is working beautifully now.
I'll merge the code changes with master branch and make the pull request
in a couple of days.
Regards,
Brian
On 01/06/2017 03:01 AM, Brian Yan wrote:
JianpuBeam is collected and inserted into Bs
JianpuBeam is collected and inserted into BspTree by "scanElements".
But still JianpuBeam::draw() does not get called.
Probably something to do with settings of JianpuBeam bbox?
On 01/05/2017 02:42 AM, Lasconic wrote:
A bit of a shot in the dark, but make sure that your JianpuBeam is collected by
Update:
One roadblock that prevents me from going further.
Somehow JianpuBeam::draw() does not get called and Jianpu beams do not
get drawn although JianpuBeam::layout() has been called.
I still could not find the root-cause or something that might be missing.
So the pull request will be delayed u
Update on progress:
I now have separate classes JianpuChord, JianpuNote, JianpuRest,
JianpuHook and JianpuBeam.
I'm now doing testing and debugging.
It will take a few or several more days to be ready for the pull request.
Regards,
Brian
-
Thanks, CC.
I added new source files (jianpunote.cpp, jianpunote.h, jianpurest.cpp,
jianpurest.h) in the libmscore directory.
I rebuilt the mscore using "make clean" and "make debug " but the
build did not pick up the new files.
I am using Kubuntu Linux.
Can somebody point out what I might
Hi lasconic,
I don't have much for the JianpuStaffType now, so I can just add it to
StaffType for now.
I'll make a pull request after I re-factor the code to separate
JianpuNote/JianpuRest classes.
I'm now using my local 141581-jianpu branch.
Do you want me to make a pull request to master or a
Hi Nicolas,
Current implementations of TAB and Jianpu is too intrusive to and too
coupled with Standard notation implementation.
It is kind of messy and mingled together, and it will be hard to
understand/maintain and extend functionality in the future.
I'm not trying to change everything overn
Thanks, CC.
Please forward the link to me when you have the forum thread started, so
I can check it time to time.
Regards,
Brian
On 12/12/2016 02:07 AM, Combat Cube wrote:
I got the book from a Chinese bookstore, and indeed it is in Chinese.
It teaches how to read jianpu (not write it) and c
7;d be happy to implement them
myself when appropriate.
Keep it up!
CombatCube
On Dec 10, 2016 11:06 PM, "Brian Yan" <mailto:brian@verizon.net>> wrote:
Staff line is removed and fillRect function is used to draw
note/rest duration dashes.
See the snapshot of
Staff line is removed and fillRect function is used to draw note/rest
duration dashes.
See the snapshot of current implementation below.
Jianpu-4.png
Still, adjustment for ties and note positions in the chord are needed
and other stuff like key signature, etc., need to be added.
-
I use following entry in StaffType _presets vector, for Jianpu staff.
// group, xml-name,
human-readable-name, lin dst clef bars stmless time key ledger
StaffType(StaffGroup::JIANPU, "Jianpu", QObject::tr("Jianpu"),
1, 1, false, true, false, t
Thanks, Ryan.
It's true that the conventional Jianpu has the lower octave dots below
the 8th/16th duration lines.
But I'd prefer to have the dots right underneath the note numbers so
that we do not have any ambiguity in chords.
In chords, some notes may have the dot and some others may not. In
Hi Nicolas,
Thanks for your feedback.
I'll use drawLine or drawRect for the duration dash.
I do not plan to keep the staff line. Jianpu does not have the staff line.
I just did not have a chance to remove it yet. I'll do that when I
have a chance.
I do not have any reference implementation n
Snapshot of current Jianpu display implementation.
Jianpu-3.png
The layouts of under-lines for hooks are not quite right yet.
The layouts of under-lines for beams are quite nice now.
I'm using the whole-rest symbol as Jianpu duration dashes and it looks
too thick to me.
I may need to create a
Thanks, M. Gavioli, for your advice. I appreciate it.
For layout, Jianpu layout is more similar in appearance to the standard
note layout than to the TAB's.
So I'm following the the layout of the standard note.
Here is a snapshot of current implementation.
Jianpu-2.png
Still, I need to add n
I made some changes for adding a linked Jianpu staff to a standard staff
and converting the note pitch/tpc values to Jianpu note numbers.
See the picture below.
I am currently using layout of the standard staff. I still need to to
put all the Jianpu note numbers on the same level and add dashes
ng for you.
A couple developers are in the US too.
lasconic
2016-11-19 18:11 GMT+01:00 Brian Yan mailto:brian@verizon.net>>:
Thanks, Nicolas.
I'll start writing something up in the issue page.
Live chat on IRC may not work out well due to time-zone
Thanks, Nicolas.
I'll start writing something up in the issue page.
Live chat on IRC may not work out well due to time-zone difference -- I
live in Texas, U.S.A.
What time-frame are you usually online on IRC?
Regards,
Brian
On 11/19/2016 02:06 AM, Lasconic wrote:
Hi Brian,
I created an iss
Hi,
I am a software engineer and an amateur musician.
I'd like to contribute in adding support for numbered notation (aka
Jianpu) to MuseScore.
Is there any active development on this feature?
Regards,
Brian
--
___
20 matches
Mail list logo
