Is JianpuBeam or jianpu support available in the latest MuseScore release?
Anson
--
Sent from: http://dev-list.musescore.org/
___
Mscore-developer mailing list
Mscore-developer@lists.sourceforge.net
Hi,
is this support for Jianpu still in development?
We are some software engineers in Germany and would like to contribute a
very similar notation with numbers.
In our choirs this notation is used very often and we tried already
different ways to write it. (Capella, Sibelius).
A little sample:
I pushed Jianpu code changes to github master and it seemed to be successful
(see below).
But the changes did not show up at MuseScore github on web browser.
When I clicked "New pull request" and tried to compare with master branch, it
said they were identical.
Did I do something wrong or am I
Update:
The problem was with empty JianpuBeam bbox.
JianpuBeam is working beautifully now.
I'll merge the code changes with master branch and make the pull request
in a couple of days.
Regards,
Brian
On 01/06/2017 03:01 AM, Brian Yan wrote:
JianpuBeam is collected and inserted into BspTree
JianpuBeam is collected and inserted into BspTree by "scanElements".
But still JianpuBeam::draw() does not get called.
Probably something to do with settings of JianpuBeam bbox?
On 01/05/2017 02:42 AM, Lasconic wrote:
A bit of a shot in the dark, but make sure that your JianpuBeam is collected
A bit of a shot in the dark, but make sure that your JianpuBeam is
collected by "scanElements".
lasconic
2017-01-05 7:36 GMT+01:00 Brian Yan :
> Update:
> One roadblock that prevents me from going further.
> Somehow JianpuBeam::draw() does not get called and Jianpu
Update:
One roadblock that prevents me from going further.
Somehow JianpuBeam::draw() does not get called and Jianpu beams do not
get drawn although JianpuBeam::layout() has been called.
I still could not find the root-cause or something that might be missing.
So the pull request will be delayed
Great ! make sure to get the last changes from master in your branch. It
will make it easier to review and merge your work.
Keep up the good work !
lasconic
2016-12-30 5:44 GMT+01:00 Brian Yan :
> Update on progress:
> I now have separate classes JianpuChord, JianpuNote,
ge.net>
Envoyé le : jeudi 29 décembre 2016 23h44
Objet : Re: [Mscore-developer] Support for numbered notation (Jianpu)
Update on progress:
I now have separate classes JianpuChord, JianpuNote, JianpuRest,
JianpuHook and JianpuBeam.
I'm now doing testing and debugging.
It will take a fe
Update on progress:
I now have separate classes JianpuChord, JianpuNote, JianpuRest,
JianpuHook and JianpuBeam.
I'm now doing testing and debugging.
It will take a few or several more days to be ready for the pull request.
Regards,
Brian
You need to add the files in the CMakeLists.txt file in libmscore.
lasconic
2016-12-20 7:04 GMT+01:00 Brian Yan :
> Thanks, CC.
>
> I added new source files (jianpunote.cpp, jianpunote.h, jianpurest.cpp,
> jianpurest.h) in the libmscore directory.
> I rebuilt the mscore
Thanks, CC.
I added new source files (jianpunote.cpp, jianpunote.h, jianpurest.cpp,
jianpurest.h) in the libmscore directory.
I rebuilt the mscore using "make clean" and "make debug " but the
build did not pick up the new files.
I am using Kubuntu Linux.
Can somebody point out what I
The forum link regarding octave dots can be found here:
https://musescore.org/en/node/151831
On Wed, Dec 14, 2016 at 11:57 PM, Lasconic wrote:
> Hi,
>
> A PR to master is good.
>
> lasconic
>
> 2016-12-15 4:09 GMT+01:00 Brian Yan :
>
>> Hi lasconic,
>>
Hi lasconic,
I don't have much for the JianpuStaffType now, so I can just add it to
StaffType for now.
I'll make a pull request after I re-factor the code to separate
JianpuNote/JianpuRest classes.
I'm now using my local 141581-jianpu branch.
Do you want me to make a pull request to master or a
Hi,
First, the bad news. Werner, the MuseScore lead developer, is currently
working on staff type. He is adding the possibility to change the type of a
staff along the time axis. It means your changes and his changes will need
to be merged.
Regarding StaffType, we used to have a hierarchy for
Hi Nicolas,
Current implementations of TAB and Jianpu is too intrusive to and too
coupled with Standard notation implementation.
It is kind of messy and mingled together, and it will be hard to
understand/maintain and extend functionality in the future.
I'm not trying to change everything
Thanks, CC.
Please forward the link to me when you have the forum thread started, so
I can check it time to time.
Regards,
Brian
On 12/12/2016 02:07 AM, Combat Cube wrote:
I got the book from a Chinese bookstore, and indeed it is in Chinese.
It teaches how to read jianpu (not write it) and
I got the book from a Chinese bookstore, and indeed it is in Chinese. It
teaches how to read jianpu (not write it) and contains a good amount of
(albeit simple) example material. I am also currently learning Chinese, so
it doubly serves as practice reading material.
I'm going to open up a forum
Hi Brian,
I'm very interested in the work you're doing and I'm willing to contribute.
I purchased a book on jianpu notation and I'm going to compile some
references to compare with. It's looking great so far! I'd just like to
recommend adding a few style options to perhaps improve the look of the
Staff line is removed and fillRect function is used to draw note/rest
duration dashes.
See the snapshot of current implementation below.
Jianpu-4.png
Still, adjustment for ties and note positions in the chord are needed
and other stuff like key signature, etc., need to be added.
I use following entry in StaffType _presets vector, for Jianpu staff.
// group, xml-name,
human-readable-name, lin dst clef bars stmless time key ledger
StaffType(StaffGroup::JIANPU, "Jianpu", QObject::tr("Jianpu"),
1, 1, false, true, false,
Thanks, Ryan.
It's true that the conventional Jianpu has the lower octave dots below
the 8th/16th duration lines.
But I'd prefer to have the dots right underneath the note numbers so
that we do not have any ambiguity in chords.
In chords, some notes may have the dot and some others may not. In
Brian, it's looking good. One question, normally jianpu has the lower octave
dots placed below the eighth/sixteenth duration marks, correct?
--
View this message in context:
http://dev-list.musescore.org/Support-for-numbered-notation-Jianpu-tp7580026p7580048.html
Sent from the MuseScore
Hi Nicolas,
Thanks for your feedback.
I'll use drawLine or drawRect for the duration dash.
I do not plan to keep the staff line. Jianpu does not have the staff line.
I just did not have a chance to remove it yet. I'll do that when I
have a chance.
I do not have any reference implementation
Hi Brian,
it looks better every day!
For the duration dash, it might be easier to draw a line instead of relying
on a font symbol. MuseScore uses the SMuFL standard for the font layout
http://w3c.github.io/smufl/gitbook/ and there is nothing for Jianpu in it.
If you miss some symbols we coud
Snapshot of current Jianpu display implementation.
Jianpu-3.png
The layouts of under-lines for hooks are not quite right yet.
The layouts of under-lines for beams are quite nice now.
I'm using the whole-rest symbol as Jianpu duration dashes and it looks
too thick to me.
I may need to create
Thanks, M. Gavioli, for your advice. I appreciate it.
For layout, Jianpu layout is more similar in appearance to the standard
note layout than to the TAB's.
So I'm following the the layout of the standard note.
Here is a snapshot of current implementation.
Jianpu-2.png
Still, I need to add
byan61 wrote
> I made some changes for adding a linked Jianpu staff to a standard staff
> and converting the note pitch/tpc values to Jianpu note numbers. See the
> picture below.
> I am currently using layout of the standard staff. I still need to to put
> all the Jianpu note numbers on the same
Hi Brian,
Good progress!
First remark, the mailing list has a post size limit. When you include
images, try to make them smaller or your post will be blocked until an
admin validates it.
Regarding the layouting, the code is the main documentation
unfortunately... For every element, you will
I made some changes for adding a linked Jianpu staff to a standard staff
and converting the note pitch/tpc values to Jianpu note numbers.
See the picture below.
I am currently using layout of the standard staff. I still need to to
put all the Jianpu note numbers on the same level and add
> The easiest way seems to be to implement Jianpu the same way as the
> TabStaff was implemented.
> So I can just add JIANPU in the StaffGroup type and add variations
> specific to Jianpu in some 20-25 classes.
> enum class StaffGroup : char {
> STANDARD, PERCUSSION, TAB
> };
>
Sounds like a
Hi Nicolas,
I have set up my MuseScore project with GitHub and was able to build and
run/debug on my Kubuntu Linux PC.
I was browsing through the source code yesterday.
The easiest way seems to be to implement Jianpu the same way as the
TabStaff was implemented.
So I can just add JIANPU in
Thanks, Nicolas.
I'll start writing something up in the issue page.
Live chat on IRC may not work out well due to time-zone difference -- I
live in Texas, U.S.A.
What time-frame are you usually online on IRC?
Regards,
Brian
On 11/19/2016 02:06 AM, Lasconic wrote:
Hi Brian,
I created an
Hi Brian,
As far as I know, there is currently no development going on for Jianpu,
and your expertise is welcome!
If you need any help, please ask here on the mailling list or on IRC
#musescore on freenode.net
https://kiwiirc.com/client/irc.freenode.net/?nick=musescore|?#musescore
You can find
Hi,
I am a software engineer and an amateur musician.
I'd like to contribute in adding support for numbered notation (aka
Jianpu) to MuseScore.
Is there any active development on this feature?
Regards,
Brian
--
35 matches
Mail list logo