Re: [MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection

2021-03-08 Thread fredvs
Graeme Geldenhuys wrote > On 07/03/2021 12:58 pm, fredvs wrote: >> Nice (but you are mse-org member so no need to request, just push it). > > I forgot I have read/write access. I've pushed my changes. > > Regards, > Graeme Thanks! Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nab

Re: [MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection

2021-03-08 Thread Graeme Geldenhuys
On 07/03/2021 12:58 pm, fredvs wrote: > Nice (but you are mse-org member so no need to request, just push it). > > By the way, I did commit your code for ideU. I forgot I have read/write access. I've pushed my changes. Regards, Graeme -- fpGUI Toolkit - a cross-platform GUI toolkit using Fre

Re: [MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection

2021-03-07 Thread fredvs
Graeme Geldenhuys wrote > I'll make the remaining changes today and created a pull request for code > review. Hello Graeme. Nice (but you are mse-org member so no need to request, just push it). By the way, I did commit your code for ideU. Fre;D -- Sent from: http://mseide-msegui-talk.1

Re: [MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection

2021-03-07 Thread Graeme Geldenhuys
On 07/03/2021 2:20 am, fredvs wrote: > But if doing this, imho, tactionsmo.enablecomment has no sense anymore and > should be commented. My initial thoughts was not to change existing behaviour, but you are 100% correct. That action doesn't make sense any more - in fact I did not even know that ri

Re: [MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection

2021-03-06 Thread fredvs
Hello Graeme. Indeed, much better. But if doing this, imho, tactionsmo.enablecomment has no sense anymore and should be commented. Otherwise if you use the right-click to show the properties-list, "comment" will be disabled if nothing was selected. procedure tactionsmo.enablecomment(const sender

[MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection

2021-03-06 Thread Graeme Geldenhuys
Hi, Attached is a patch to add new functionality to the text editor. Every programmer editor I have ever used allows you to comment a line of code *without* first having to make a selection. Old behaviour: To comment a line, you had to first select the whole line, starting at column 1 and the t