Re: [Musicpd-dev-team] 4 new patches in mpd-mk: tag library refactoring II

2008-09-06 Thread Max Kellermann
On 2008/09/03 12:05, Eric Wong [EMAIL PROTECTED] wrote: I'm hitting a segfault when running update, the patch below fixes things for me. However I'm thinking the tag_begin_add/tag_end_add() interface is too fragile and error prone to be worth exposing. Perhaps make both tag_begin_add and

Re: [Musicpd-dev-team] [PATCH] client: pass the client struct to processCommand()

2008-09-06 Thread Eric Wong
Max Kellermann [EMAIL PROTECTED] wrote: On 2008/09/06 05:51, Eric Wong [EMAIL PROTECTED] wrote: Why implement lookup algorithms for fd-pointer, when you can use the pointer in the first place? We go through the trouble of passing only file descriptors to other layers because we can

Re: [Musicpd-dev-team] [PATCH] tag: renamed MpdTag and MpdTagItem to struct tag, struct mpd_tag_item

2008-09-06 Thread Eric Wong
Max Kellermann [EMAIL PROTECTED] wrote: On 2008/09/06 05:33, Eric Wong [EMAIL PROTECTED] wrote: I've already merged your tag stuff with struct mpd_tag since that resembles the old name: MpdTag I didn't choose that name because I thought it was somewhat redundant, but it's ok for me. This