On 2011/08/31 01:12, Steven Blackburn <st...@beeka.org> wrote: > I don't know how much explaination of the changes you normally require, so > sorry if I have gone on a bit. Could somebody merge my patch / comment on > any changes it needs / try it with another DLNA device.
Hi Steve, thanks for your code. Looks pretty simple. What I would like to see: If you want to describe your changes, use the commit message, not a long email. If a patch needs an email text for explanation, then the commit message is not good enough! For easier code review, separate changes should be separate patches. I might be convinced of small cleanup patches pretty quickly and merge them immediately, even if other patches need cleanups. In your patch, it is unclear which hunks are needed to supporting DLNA, and which ones are just some generic useful additions. Some other changes (such as logging "unreachable code reached") are not favored by me; I might leave them out until somebody convinces me. (In that case, I'd prefer an assert(false) to make it very clear that something extremely bad has happened, that needs developer attention) Obey the existing coding style; indent with tabs. (The last hunk has normal spaces) > PS: I've used several version control systems in the past, but git is new to > me so this patch is a product of google.... let me know if you need it > another way. git has a difficult learning curve, but once you get used to it ... If you want to do more work on MPD in the future, we can give you a public git repository on git.musicpd.org. Max ------------------------------------------------------------------------------ Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
