Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-04 Thread Max Kellermann
On 2012/09/28 09:29, Jurgen Kramer gtmkra...@xs4all.nl wrote: Patch to enable tag support for DSDIFF and DSF DSD decoders. Sent to Max on 19/09. Post here for completeness. Fails to build: src/decoder/dsdlib.c:130:9: error: use of undeclared identifier 'taggoffset'; did you mean 'tagoffset'?

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-04 Thread Jurgen Kramer
On Thu, 2012-10-04 at 09:59 +0200, Max Kellermann wrote: On 2012/09/28 09:29, Jurgen Kramer gtmkra...@xs4all.nl wrote: Patch to enable tag support for DSDIFF and DSF DSD decoders. Sent to Max on 19/09. Post here for completeness. Fails to build: src/decoder/dsdlib.c:130:9: error: use

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-04 Thread Max Kellermann
On 2012/10/04 18:13, Jurgen Kramer gtmkra...@xs4all.nl wrote: Fixed. I've created a new, clean, commit. Patch to enable tag support for DSDIFF and DSF DSD decoders. You did not fix the stack overflow bug, did you? I still see it in dsdiff_handle_native_tag().

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-04 Thread Max Kellermann
On 2012/10/04 18:35, Jurgen Kramer gtmkra...@xs4all.nl wrote: I went through the e-mails, I do not recall you having problems with dsdiff_handle_native_tag(). You made the same mistake twice. Maybe I didn't point you to the second instance of the same bug. We discussed dsdlib_tagid3() from